Re: [PATCH v9 6/7] pinctrl: s32cc: implement GPIO functionality

[Linus Walleij <linusw@kernel.org>]

On Fri, May 8, 2026 at 11:07 AM Khristine Andreea Barbulescu
<khristineandreea.barbulescu@oss.nxp.com> wrote:

>I don't think the current driver is a good fit for
> a full gpio-regmap conversion. Direction and GPIO mux are
> handled through MSCR/pinctrl state (IBE/OBE/SSS), and the GPIO
> logic spans multiple register regions across two SIUL2 instances.

I don't see the problem with that?

> A conversion would require stronger separation between
> GPIO and pinctrl, leaving mux restoration entirely
> to the pinctrl subsystem.

Why is that so? Sorry I don't get the problem here.

The pinmux operations have these callbacks:

static const struct pinmux_ops s32_pmx_ops = {
(...)
        .gpio_request_enable = s32_pmx_gpio_request_enable,
        .gpio_disable_free = s32_pmx_gpio_disable_free,
        .gpio_set_direction = s32_pmx_gpio_set_direction,
};

So to me it looks like the pinctrl subsystem is *already*
handling all the muxing of GPIO lines in these
callbacks?

> Would it be reasonable to keep the current approach for now
> and revisit gpio-regmap later if needed?

I'd prefer that you look into it now while you already
have all the information at hand and fresh in your mind.

You can forward my comments to your project lead
/ JIRA instance and say it's Linus' fault you have to spend
more time on this right now.

Yours,
Linus Walleij