From: Doug Anderson <dianders@chromium.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>,
Stephen Boyd <swboyd@chromium.org>,
Thierry Reding <thierry.reding@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Rob Clark <robdclark@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 8/8] drm: Config orientation property if panel provides it
Date: Fri, 10 Jun 2022 12:55:33 -0700 [thread overview]
Message-ID: <CAD=FV=X+9+a2EdkpvEneUfcCS=nr34+aGa_ZjvhidF_vfSiLzg@mail.gmail.com> (raw)
In-Reply-To: <20220609072722.3488207-9-hsinyi@chromium.org>
Hi,
On Thu, Jun 9, 2022 at 12:28 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> Panel orientation property should be set before drm_dev_register().
> Some drm driver calls drm_dev_register() in .bind(). However, most
> panels sets orientation property relatively late, mostly in .get_modes()
> callback, since this is when they are able to get the connector and
> binds the orientation property to it, though the value should be known
> when the panel is probed.
>
> In drm_bridge_connector_init(), if a bridge is a panel bridge, use it to
> set the connector's panel orientation property.
>
> Suggested-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> v6->v7: remove redundant check and fix config issue.
> ---
> drivers/gpu/drm/bridge/panel.c | 34 ++++++++++++++++++++++++++
> drivers/gpu/drm/drm_bridge_connector.c | 8 +++++-
> include/drm/drm_bridge.h | 14 +++++++++++
> 3 files changed, 55 insertions(+), 1 deletion(-)
Reviewed-by: Doug Anderson <dianders@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-10 19:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 7:27 [PATCH v7 0/8] Add a panel API to set orientation properly Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 1/8] drm/panel: Add an API to allow drm to set orientation from panel Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 2/8] drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 3/8] drm/panel: panel-edp: " Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 4/8] drm/panel: lvds: " Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 5/8] drm/panel: panel-simple: " Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 6/8] drm/panel: ili9881c: " Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 7/8] drm/panel: elida-kd35t133: " Hsin-Yi Wang
2022-06-09 7:27 ` [PATCH v7 8/8] drm: Config orientation property if panel provides it Hsin-Yi Wang
2022-06-10 19:55 ` Doug Anderson [this message]
2022-06-10 20:21 ` Stephen Boyd
2022-06-15 5:50 ` [PATCH v7 0/8] Add a panel API to set orientation properly Hsin-Yi Wang
2022-06-15 13:36 ` Doug Anderson
2022-06-21 15:58 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X+9+a2EdkpvEneUfcCS=nr34+aGa_ZjvhidF_vfSiLzg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).