From mboxrd@z Thu Jan 1 00:00:00 1970 From: xiechao.mail@gmail.com (Chao Xie) Date: Wed, 29 May 2013 11:58:01 +0800 Subject: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci In-Reply-To: <20130528162415.GA28253@arwen.pp.htv.fi> References: <1368424303-10629-5-git-send-email-chao.xie@marvell.com> <20130528162415.GA28253@arwen.pp.htv.fi> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 29, 2013 at 12:24 AM, Felipe Balbi wrote: > Hi, > > On Mon, May 13, 2013 at 10:13:44AM -0400, Alan Stern wrote: >> On Mon, 13 May 2013, Chao Xie wrote: >> >> > Originaly, ehci driver will call the callbacks in platform data >> > for PHY initialization and shut down. >> > With PHY driver, it will call the APIs provided by PHY driver >> > for PHY initialization and shutdown. It removes the callbacks >> > in platform data, and at same time it removes one block in the >> > way of enabling device tree for ehci driver. >> >> I wonder if this is the sort of thing that should be handled in >> ehci-hcd.c rather than in all the different platform glue drivers. >> >> Felipe, what do you think? Are the required actions now sufficiently >> generic that a single source file can take care of them? > > Sorry for the delay, was on business trip and now on vacations. Anyway, > I agree with you. Our PHY layer should be generic enough that it should > be usable by ehci-hcd itself. If we have any missing method, let's add > it generically. > So what are your idea about making the PHY layer more generic? How ehci-hcd will make use of PHY layer? > cheers > > ps: dropping this from my queue for now. > > -- > balbi