From: xiechao.mail@gmail.com (Chao Xie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci
Date: Thu, 13 Jun 2013 10:45:24 +0800 [thread overview]
Message-ID: <CADApbegr5RBODJD=4UZ5Skn_N91oxwDFDxnS7Qqh5dot0EnU-Q@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1305301020230.1321-100000@iolanthe.rowland.org>
On Thu, May 30, 2013 at 10:23 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Thu, 30 May 2013, Roger Quadros wrote:
>
>> >> So what are your idea about making the PHY layer more generic? How
>> >> ehci-hcd will make use of PHY layer?
>> >
>> >
>> > on probe grab the phy and initialize it. On suspend/resume,
>> > suspend/resume the PHY and so on. Whatever you were going to do on your
>> > ehci glue, do it on generic ehci-hcd.
>> >
>>
>> These operations sound generic enough to be done at HCD layer, no? So no need to
>> replicate the same stuff in ohci, ehci, xhci, etc.
>
> The HCD layer handles suspend and resume only for PCI host controllers.
> Not for other types.
>
> I don't know if the acquire/start and stop/release parts can be moved
> into the USB core. Maybe they can.
>
> Alan Stern
>
hi
The following is my understanding.
I think for PHY initialization and shutdown part, it is generic for
other parts.
PHY initialization need to be called before hc_driver->reset is called.
I think it can be added at usb_add_hcd.
For PHY shutdown, it can be added at usb_remove_hcd.
For suspend/resume, i do not know how to add it. For our EHCI driver,
when system goes to deep idle states, we just directly shutdown the
hcd and initialize it again when the system goes back.
next prev parent reply other threads:[~2013-06-13 2:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 5:51 [V9 PATCH 00/12] mv-usb phy driver Chao Xie
2013-05-13 5:51 ` [PATCh V10 01/12] usb: phy: protect phy init and shutdown for mutiple deivces Chao Xie
2013-05-13 5:51 ` [PATCh V10 02/12] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller Chao Xie
2013-05-13 5:51 ` [PATCh V10 03/12] usb: gadget: mv_udc: use PHY driver for udc Chao Xie
2013-05-13 5:51 ` [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci Chao Xie
2013-05-13 14:13 ` Alan Stern
2013-05-28 16:24 ` Felipe Balbi
2013-05-29 3:58 ` Chao Xie
2013-05-29 17:37 ` Felipe Balbi
2013-05-30 11:45 ` Roger Quadros
2013-05-30 14:23 ` Alan Stern
2013-06-13 2:45 ` Chao Xie [this message]
2013-06-13 15:08 ` Alan Stern
2013-06-14 1:31 ` Chao Xie
2013-06-14 1:55 ` Chao Xie
2013-06-15 2:24 ` Alan Stern
2013-06-14 9:07 ` Roger Quadros
2013-06-14 20:01 ` Alan Stern
2013-06-17 6:12 ` Chao Xie
2013-06-17 14:01 ` Alan Stern
2013-06-17 8:17 ` Roger Quadros
2013-05-13 5:51 ` [PATCh V10 05/12] usb: phy: phy-mv-usb: use USB2 PHY driver for otg Chao Xie
2013-05-13 5:51 ` [PATCh V10 06/12] usb: mv_u3d: usb phy drivers for phy operation Chao Xie
2013-05-13 5:51 ` [PATCh V10 07/12] arm: mmp2: change the defintion of usb devices Chao Xie
2013-05-13 5:51 ` [PATCh V10 08/12] arm: pxa910: " Chao Xie
2013-05-13 5:51 ` [PATCh V10 09/12] arm: ttc_dkb: modify usb support Chao Xie
2013-05-13 5:51 ` [PATCh V10 10/12] arm: mmp: remove unused usb devices Chao Xie
2013-05-13 5:51 ` [PATCh V10 11/12] arm: brownstone: add usb support for the board Chao Xie
2013-05-13 5:51 ` [PATCh V10 12/12] usb: mv_usb: remove the phy callbacks in pdata Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADApbegr5RBODJD=4UZ5Skn_N91oxwDFDxnS7Qqh5dot0EnU-Q@mail.gmail.com' \
--to=xiechao.mail@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).