From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AB0C12002 for ; Thu, 15 Jul 2021 00:16:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAB7961361 for ; Thu, 15 Jul 2021 00:16:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAB7961361 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bcmbEy1Yb02B+FSY3XriF0gO3wMv5Sxppo9BtKg+E3Y=; b=nZynU1YsWgfBhG LGu317NxvMjIRhau7UZ2Zzs3pVY0YVxHlfJGSMuf8gKgTcSUkvX/pQEur1vCyOQYOExReDT7ikCaz 8yVu3DwZBuzEei0xbgmxGl44L0ioTymUmXgIKcwjDFMSd3JabsIbD9H6eSpxtbt6z91k4SevtYpci N7xAOQxnsmVDN+pWVWVdHddDdW1LcI1T7sYpIYRtvApV4DOeDq1aW9jSx6K6smzcRqojCReTOon1y EG3htxBG2hKt55j5JGPRpLf15QrTrZ08JV6rZrVwNzUoL1w0lBJB06XkFtqsFpCQuDySmSVDDxoxg hgc51vrnewGHWUwC+0ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3p0n-00Ga78-WE; Thu, 15 Jul 2021 00:13:58 +0000 Received: from mail-qv1-f51.google.com ([209.85.219.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3nO6-00FrMT-3d for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 22:29:57 +0000 Received: by mail-qv1-f51.google.com with SMTP id c15so1870829qvw.6 for ; Wed, 14 Jul 2021 15:29:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lsctwH0XgpYOHYMIUUkD/PxnFZz1dTw3T5m+9J+nUZo=; b=FXNkqzuLPHQkk7sAXnCtto62vViyLBO4Q3dcemZHbAjS2l8r9CDvh318QZDmOq2WuV llUsv+XwkMv+m8UlSxRDToGzlx4TEjMmMFvGB9tmesHQ+VNb6zof0XKTT62vfMGRZC/i y+U0aiPnnMuY4kUIoAAJbcujOW0U7EnrNhfLJu5EpSJgwMsDKEhiNDX1gqcjJiNgNls9 E1Ia1Bd6fTOrFocs71DEUyJ4r93z5IVXcJ0XApYjRhe3iLscTPRL/JVURDSNGzOo0nkU FxkspFGY3jDiZRlf7/v7TFLmSdHfKGQ1yzduGoc3GiW9cfRktFwPEufGQKS8ILAcK9Ci C7bA== X-Gm-Message-State: AOAM532b7DdEEawsJsNnTjwFXH9qjyWztSk7CFKQf1Zxoa8X8Qt+sNqs ZtgxspuIV8vZqx7KxdIdNFF33zdYUPvdRA== X-Google-Smtp-Source: ABdhPJw6wlJeyTIldqHepY6toTE3vFAVXmKdhw2KfrczJL/1zBd2ckSTfyxrBqWuaCYY09m/DLjgFA== X-Received: by 2002:ad4:4eaf:: with SMTP id ed15mr388443qvb.1.1626301791782; Wed, 14 Jul 2021 15:29:51 -0700 (PDT) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com. [209.85.222.177]) by smtp.gmail.com with ESMTPSA id 12sm1640204qkr.10.2021.07.14.15.29.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jul 2021 15:29:51 -0700 (PDT) Received: by mail-qk1-f177.google.com with SMTP id q190so3289111qkd.2 for ; Wed, 14 Jul 2021 15:29:50 -0700 (PDT) X-Received: by 2002:a37:a58f:: with SMTP id o137mr218663qke.451.1626301790102; Wed, 14 Jul 2021 15:29:50 -0700 (PDT) MIME-Version: 1.0 References: <20210705111250.1513634-1-fido_max@inbox.ru> In-Reply-To: <20210705111250.1513634-1-fido_max@inbox.ru> From: Li Yang Date: Wed, 14 Jul 2021 17:29:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] soc: fsl: qe: convert QE interrupt controller to platform_device To: Maxim Kochetkov Cc: linuxppc-dev , saravanak@google.com, Greg Kroah-Hartman , lkml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Zhao Qiang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_152954_245285_D52C57FE X-CRM114-Status: GOOD ( 26.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 5, 2021 at 6:12 AM Maxim Kochetkov wrote: > > Since 5.13 QE's ucc nodes can't get interrupts from devicetree: > > ucc@2000 { > cell-index = <1>; > reg = <0x2000 0x200>; > interrupts = <32>; > interrupt-parent = <&qeic>; > }; > > Now fw_devlink expects driver to create and probe a struct device > for interrupt controller. > > So lets convert this driver to simple platform_device with probe(). > > [1] - https://lore.kernel.org/lkml/CAGETcx9PiX==mLxB9PO8Myyk6u2vhPVwTMsA5NkD-ywH5xhusw@mail.gmail.com > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""") > Signed-off-by: Maxim Kochetkov > --- > drivers/soc/fsl/qe/qe_ic.c | 38 +++++++++++++++++++++++--------------- > 1 file changed, 23 insertions(+), 15 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c > index 3f711c1a0996..03d291376895 100644 > --- a/drivers/soc/fsl/qe/qe_ic.c > +++ b/drivers/soc/fsl/qe/qe_ic.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -404,27 +405,28 @@ static void qe_ic_cascade_muxed_mpic(struct irq_desc *desc) > chip->irq_eoi(&desc->irq_data); > } > > -static void __init qe_ic_init(struct device_node *node) > +static int qe_ic_init(struct platform_device *pdev) > { > void (*low_handler)(struct irq_desc *desc); > void (*high_handler)(struct irq_desc *desc); > struct qe_ic *qe_ic; > struct resource res; > + struct device_node *node = pdev->dev.of_node; > u32 ret; > > ret = of_address_to_resource(node, 0, &res); > if (ret) > - return; > + return -ENODEV; > > qe_ic = kzalloc(sizeof(*qe_ic), GFP_KERNEL); > if (qe_ic == NULL) > - return; > + return -ENOMEM; > > qe_ic->irqhost = irq_domain_add_linear(node, NR_QE_IC_INTS, > &qe_ic_host_ops, qe_ic); > if (qe_ic->irqhost == NULL) { > kfree(qe_ic); > - return; > + return -ENODEV; > } > > qe_ic->regs = ioremap(res.start, resource_size(&res)); > @@ -437,7 +439,7 @@ static void __init qe_ic_init(struct device_node *node) > if (!qe_ic->virq_low) { > printk(KERN_ERR "Failed to map QE_IC low IRQ\n"); > kfree(qe_ic); > - return; > + return -ENODEV; > } > if (qe_ic->virq_high != qe_ic->virq_low) { > low_handler = qe_ic_cascade_low; > @@ -456,20 +458,26 @@ static void __init qe_ic_init(struct device_node *node) > irq_set_handler_data(qe_ic->virq_high, qe_ic); > irq_set_chained_handler(qe_ic->virq_high, high_handler); > } > + return 0; > } > +static const struct of_device_id qe_ic_ids[] = { > + { .compatible = "fsl,qe-ic"}, > + { .compatible = "qeic"}, >From the original code, this should be type = "qeic". It is not defined in current binding but probably needed for backward compatibility. It would be great if you can also deal with the comments from Dan too. Thanks. > + {}, > +}; > > -static int __init qe_ic_of_init(void) > +static struct platform_driver qe_ic_driver = > { > - struct device_node *np; > + .driver = { > + .name = "qe-ic", > + .of_match_table = qe_ic_ids, > + }, > + .probe = qe_ic_init, > +}; > > - np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic"); > - if (!np) { > - np = of_find_node_by_type(NULL, "qeic"); > - if (!np) > - return -ENODEV; > - } > - qe_ic_init(np); > - of_node_put(np); > +static int __init qe_ic_of_init(void) > +{ > + platform_driver_register(&qe_ic_driver); > return 0; > } > subsys_initcall(qe_ic_of_init); > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel