From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D70C433EF for ; Wed, 29 Sep 2021 21:55:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F30B9613A6 for ; Wed, 29 Sep 2021 21:55:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F30B9613A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9eHEkGhIDsuVNcHqYWvfOD6xC049YmGez1jFr3dq2k0=; b=DADMGizTuBwdlj 2TsNDwx0AG+aInMlmNo50hU/t5RBeQjRIaeMVOUT1ZGwjP6OyWWkLf0Vab027TEsFxuwW6qrJe3E1 xd1ixJF366rctWwq3RNqMFIOgGNuLUcY2WuvzFRNOUiVjichwR8b6lcv0oWWjEE1uJO88FtlT2Pn+ pdtOOd66IaJB/DyfwX+BSARUOFvZrV3Rmh1mnUIHyoFW/0Jgbozu45cxVtSRM1K15okshZJ0cySaD 96bvhTUe2C2KEuIaxVHnG77i/2EZHkWrh6MwSuEMnFssCyW9h7n9QoRu711Zawgdq40HIQavC5HxH /31aU7c1X/D9N38OxEAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVhWa-00CRKD-SK; Wed, 29 Sep 2021 21:54:01 +0000 Received: from mail-qk1-f170.google.com ([209.85.222.170]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVhWU-00CRHO-VV for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 21:53:56 +0000 Received: by mail-qk1-f170.google.com with SMTP id f130so3839539qke.6 for ; Wed, 29 Sep 2021 14:53:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dy7tWacIyVasGr51uylmiHt4pHFLEmjBm7qwT/JIX6s=; b=4SHio/ztCKXIhqOMwmYVPuf5oQ6NyllcBTRzJhA0V2QkxQ+1bLB+meqMxR7nxNKyfO 7fg3H8BqTV1Ozqu/cPIZ46rzgDto9gN1JgmIlbkMDS/6wv+fsdStobUsZwsWyOwdQdE0 cJYBMsLEvkEa6G2JV/MKZGYBpizf18LHtI7AKqgArB3H6mZPDGkH2L6LMe771X8eSfbO gp3UnmVReJyMNUBHLmIqVNr/M6Z/T2Ib7wQQG+nxMfMU+8655HB/bZYjlDqVOj1DDt1n cLCl6ZUCUFBfEaJmJwOKddGGx6ax/5kbPBBH3eTZIjO6Fxg6xupJWkM1T+HvQRy2q5yW 2T9w== X-Gm-Message-State: AOAM533H5sryV2Gso8/dwhB649N3ZY6MSwtyer3uuqKpx6Kpo34IBgGl rWXD+Si0Ya0vjNPUMdp/2PVn0HBVVlE= X-Google-Smtp-Source: ABdhPJwCrBHfssKsDOPIgV2XRCFN719VvXL8J2bp1A8MBIauoc1Se89ew8ICNfaxTSwzwskUWvMHIw== X-Received: by 2002:a37:356:: with SMTP id 83mr1980345qkd.110.1632952426265; Wed, 29 Sep 2021 14:53:46 -0700 (PDT) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com. [209.85.219.49]) by smtp.gmail.com with ESMTPSA id p201sm592608qke.27.2021.09.29.14.53.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 14:53:46 -0700 (PDT) Received: by mail-qv1-f49.google.com with SMTP id x8so2406953qvp.1 for ; Wed, 29 Sep 2021 14:53:45 -0700 (PDT) X-Received: by 2002:a05:6214:1461:: with SMTP id c1mr2230970qvy.19.1632952425407; Wed, 29 Sep 2021 14:53:45 -0700 (PDT) MIME-Version: 1.0 References: <20210928192154.1841889-1-robh@kernel.org> In-Reply-To: <20210928192154.1841889-1-robh@kernel.org> From: Li Yang Date: Wed, 29 Sep 2021 16:53:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: freescale: Fix 'interrupt-map' parent address cells To: Rob Herring Cc: Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkml X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_145355_045960_044FF9E5 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 2:22 PM Rob Herring wrote: > > The 'interrupt-map' in several Layerscape SoCs is malformed. The > '#address-cells' size of the parent interrupt controller (the GIC) is not > accounted for. > > Cc: Shawn Guo > Cc: Li Yang > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring Acked-by: Li Yang > --- > .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 24 +++++++++---------- > .../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 24 +++++++++---------- > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 24 +++++++++---------- > 3 files changed, 36 insertions(+), 36 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index f85e437f80b7..84a31372b3fa 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -241,18 +241,18 @@ extirq: interrupt-controller@14 { > interrupt-controller; > reg = <0x14 4>; > interrupt-map = > - <0 0 &gic GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > - <1 0 &gic GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > - <2 0 &gic GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>, > - <3 0 &gic GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, > - <4 0 &gic GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, > - <5 0 &gic GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>, > - <6 0 &gic GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>, > - <7 0 &gic GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>, > - <8 0 &gic GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > - <9 0 &gic GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > - <10 0 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, > - <11 0 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > + <0 0 &gic 0 0 GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > + <1 0 &gic 0 0 GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > + <2 0 &gic 0 0 GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>, > + <3 0 &gic 0 0 GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, > + <4 0 &gic 0 0 GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, > + <5 0 &gic 0 0 GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>, > + <6 0 &gic 0 0 GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>, > + <7 0 &gic 0 0 GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>, > + <8 0 &gic 0 0 GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > + <9 0 &gic 0 0 GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > + <10 0 &gic 0 0 GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, > + <11 0 &gic 0 0 GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > interrupt-map-mask = <0xffffffff 0x0>; > }; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > index 801ba9612d36..38aea4fce238 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > @@ -293,18 +293,18 @@ extirq: interrupt-controller@14 { > interrupt-controller; > reg = <0x14 4>; > interrupt-map = > - <0 0 &gic GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > - <1 0 &gic GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > - <2 0 &gic GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>, > - <3 0 &gic GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, > - <4 0 &gic GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, > - <5 0 &gic GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>, > - <6 0 &gic GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>, > - <7 0 &gic GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>, > - <8 0 &gic GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > - <9 0 &gic GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > - <10 0 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, > - <11 0 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > + <0 0 &gic 0 0 GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > + <1 0 &gic 0 0 GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > + <2 0 &gic 0 0 GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>, > + <3 0 &gic 0 0 GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, > + <4 0 &gic 0 0 GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, > + <5 0 &gic 0 0 GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>, > + <6 0 &gic 0 0 GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>, > + <7 0 &gic 0 0 GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>, > + <8 0 &gic 0 0 GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > + <9 0 &gic 0 0 GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > + <10 0 &gic 0 0 GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, > + <11 0 &gic 0 0 GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > interrupt-map-mask = <0xffffffff 0x0>; > }; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index c4b1a59ba424..dc8661ebd1f6 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -680,18 +680,18 @@ extirq: interrupt-controller@14 { > interrupt-controller; > reg = <0x14 4>; > interrupt-map = > - <0 0 &gic GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > - <1 0 &gic GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > - <2 0 &gic GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>, > - <3 0 &gic GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, > - <4 0 &gic GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, > - <5 0 &gic GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>, > - <6 0 &gic GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>, > - <7 0 &gic GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>, > - <8 0 &gic GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > - <9 0 &gic GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > - <10 0 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, > - <11 0 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > + <0 0 &gic 0 0 GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > + <1 0 &gic 0 0 GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > + <2 0 &gic 0 0 GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>, > + <3 0 &gic 0 0 GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, > + <4 0 &gic 0 0 GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, > + <5 0 &gic 0 0 GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>, > + <6 0 &gic 0 0 GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>, > + <7 0 &gic 0 0 GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>, > + <8 0 &gic 0 0 GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > + <9 0 &gic 0 0 GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > + <10 0 &gic 0 0 GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, > + <11 0 &gic 0 0 GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > interrupt-map-mask = <0xffffffff 0x0>; > }; > }; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel