From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: Stephen Boyd <sboyd@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] clk: imx: scu: remove the calling of device_is_bound
Date: Thu, 19 Nov 2020 17:44:48 +0000 [thread overview]
Message-ID: <CADVatmNW6L4xH99DVDK_T2y-DcDZQ0YtdpyQvTEK5kGRPOV9Pw@mail.gmail.com> (raw)
In-Reply-To: <AM6PR04MB49667ACF83F057E5591E676080E00@AM6PR04MB4966.eurprd04.prod.outlook.com>
On Thu, Nov 19, 2020 at 3:30 PM Aisheng Dong <aisheng.dong@nxp.com> wrote:
>
> > From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> > Sent: Thursday, November 19, 2020 9:08 PM
> >
> > Hi Dong,
> >
> > On Thu, Nov 19, 2020 at 07:43:02PM +0800, Dong Aisheng wrote:
> > > The device_is_bound() is unvisable to drivers when built as modules.
> > > It's also not aimed to be used by drivers according to Greg K.H.
> > > Let's remove it from clk-scu driver and find another way to do proper
> > > driver loading sequence.
> >
> > Greg was asking to use device_link for this issue. Have you tried something like
> > the following: (untested as I dont have the hardware).
>
> It can't work as expected because it requires supplier devices (scu pd) to be probed first.
> and if scu pd was probed first, then there're already no issues.
hmm.. thats odd. I was expecting that if "scu-pd" has not registered
then device_link_add() will return NULL and then imx_clk_scu_init()
will return -EPROBE_DEFER.
--
Regards
Sudip
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-19 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 11:43 [PATCH 1/1] clk: imx: scu: remove the calling of device_is_bound Dong Aisheng
2020-11-19 13:08 ` Sudip Mukherjee
2020-11-19 15:30 ` Aisheng Dong
2020-11-19 17:44 ` Sudip Mukherjee [this message]
2020-11-24 10:28 ` Aisheng Dong
2020-11-24 10:33 ` Aisheng Dong
2020-11-30 13:54 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADVatmNW6L4xH99DVDK_T2y-DcDZQ0YtdpyQvTEK5kGRPOV9Pw@mail.gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).