From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF22C56201 for ; Thu, 19 Nov 2020 17:46:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE4B521D7A for ; Thu, 19 Nov 2020 17:46:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gDhCFNEX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RZeiNnut" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE4B521D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tsgt3os9J6iHfQmbrzzCmJ8cgpKgxk1Mxb+wvFMvs+o=; b=gDhCFNEXGQnQscLspGPjp0d0Z SfBt0GhHvSh1+XTkNW1jAnWr/jQer4FHSAxiol8TckURPY7t9E3NmWG7oLrwZ0B+zzsm44l9Zrin6 yuuSo/CSJ9UWUe1vHrI7Gn0AYaQ9dMDXK1SopLmp9IxbcX21GI5bvQgO0QQjmCbL9slGV0n2Q3oHa xMGBffyGnTvO5W81KPa1FA5NpwsGVd1ebE87gpmgH5Mni5Q0pCCG4tF1y/d2uqPlw7LtKnDNFh5IS 65QSuE3ZSXHIHAghJ07Ad1gfwYsCwLNnCJkvRtd+SkwKQfnVw3pnnd2vhUB2SKWp1HEOzmn6/jkvK PvDYjIHiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfnzt-00065v-I8; Thu, 19 Nov 2020 17:45:29 +0000 Received: from mail-yb1-xb42.google.com ([2607:f8b0:4864:20::b42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfnzr-00065Y-EX for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 17:45:28 +0000 Received: by mail-yb1-xb42.google.com with SMTP id x17so5979525ybr.8 for ; Thu, 19 Nov 2020 09:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lDetejknLaUSSovij4ZnX5R4PCEm+d0eGVcmHX8A0CA=; b=RZeiNnutMY9tVL33BOXr/9+E3REQinUPqNhcOqCsNGQ6oAOt5wH5WjpvAMrYmoJsRO YAbyjzIyQviIFAT7hEUknzdCH6cpP2PUvuBcVFPbdLcSN4oj6U5gudx2zUK9cK2+rtXv 96M2RN3jCqlQJn+w4uK48IjPomQaYeWP3FzfQqsNHApRAaIUyRafuoFAleu7G+mAAGWo T5ZiqgtGbeaLpnogg/ITO0XjpoL1L0mVRcsteM/GnwROIUn6JD7R1ZDhUNdhi5gTrM1d u68VsPDW7E/s+ImNRLKoSoxXp3/5Gv9AQWE7VuOWzqqmH+oUyo7twbgvMT6qmfCrMKMd VqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lDetejknLaUSSovij4ZnX5R4PCEm+d0eGVcmHX8A0CA=; b=NKUupqQ6weeij+e79RrCuCFI6hMuHD7zPT0O+HImZ5c9MO3c4VCk4KvkrJSjS/CsGk +YEvduGcmgCBHWjAdn9z4Eipmtr2cJkTFJy3Pn57xgcngaQNh5nt5blimv6AIK0bR+7S 2BIty5lEwlnHchg2oV07uhfCAgdrYNTS8CQcSJrF+JOvSkz1rR/7RLyRmgkAwBUV41ov JDsjMtuICOa+g9aXEK/FsnDSYMD9cJ6YrJCPvTkbfSnI6SmAsrCUOYlat1hBCe+8kVY1 9sF7oLJ76qff4zTDuPXWAWdOnmFapsg+hmYxltkrwVF1V4+v1LHWxSJRa1ChDyo8nwSR kNXA== X-Gm-Message-State: AOAM5318n11snDm6wL5rnaeP1o5/Dd55+nzLz7UvCYXGB2Zhfmpt3oP6 IjopAlyh3dN32sgyTPGNohcsTcwwLUue878/ens= X-Google-Smtp-Source: ABdhPJxPm5fxE9uupf75b/arHPlZiey7tjDcCG/rljf78bWzlWsildCPx+xpeO24XY0gC4B7c1bLuB3G2UC34R2ETqM= X-Received: by 2002:a25:d18c:: with SMTP id i134mr15322305ybg.448.1605807924097; Thu, 19 Nov 2020 09:45:24 -0800 (PST) MIME-Version: 1.0 References: <20201119114302.26263-1-aisheng.dong@nxp.com> <20201119130800.boyqn4rtczq4wcvn@debian> In-Reply-To: From: Sudip Mukherjee Date: Thu, 19 Nov 2020 17:44:48 +0000 Message-ID: Subject: Re: [PATCH 1/1] clk: imx: scu: remove the calling of device_is_bound To: Aisheng Dong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_124527_525623_A751B3C4 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , dl-linux-imx , Sascha Hauer , Shawn Guo , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 3:30 PM Aisheng Dong wrote: > > > From: Sudip Mukherjee > > Sent: Thursday, November 19, 2020 9:08 PM > > > > Hi Dong, > > > > On Thu, Nov 19, 2020 at 07:43:02PM +0800, Dong Aisheng wrote: > > > The device_is_bound() is unvisable to drivers when built as modules. > > > It's also not aimed to be used by drivers according to Greg K.H. > > > Let's remove it from clk-scu driver and find another way to do proper > > > driver loading sequence. > > > > Greg was asking to use device_link for this issue. Have you tried something like > > the following: (untested as I dont have the hardware). > > It can't work as expected because it requires supplier devices (scu pd) to be probed first. > and if scu pd was probed first, then there're already no issues. hmm.. thats odd. I was expecting that if "scu-pd" has not registered then device_link_add() will return NULL and then imx_clk_scu_init() will return -EPROBE_DEFER. -- Regards Sudip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel