From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24917C433E0 for ; Wed, 27 May 2020 19:40:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3C602078B for ; Wed, 27 May 2020 19:40:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FMLY0/10"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="hPL8fiE3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3C602078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/vICIcqh35HnEkbap5Yub5flhqqTC+RMXadzAYVpH6o=; b=FMLY0/10G9JWY6 yvnk/7HRY+s2WAd4dz5EeW1PrC/FcJ1yIBOimDpJ0lZv6spvqVJ8pAY+DWutEOBBaXD0knJGnLPHN avrelr3ReHLaho+c/Ffvzn9hzFdhZpy7tpJdIAMCEA6g928Pr68qb0c6lCeWowy7uGo4ejnX4UwDP tliL49bu2nLDYEyiFedmIUywOg7djSf40whkkUvHph7g00HXebHCTIAYIiib1BFfOipJbY4mLOfFW nLJp1936kWW2TokXmj9GpMgCvfOcg0g4wwvx0QGHzjl/Ghn1u70nqcPnGm4y8vbA12JMi/y8wG71X MpsBVejPecase/f+7WoQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1je1uV-0005h2-Sw; Wed, 27 May 2020 19:40:19 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1je1uS-0005fe-6d for linux-arm-kernel@lists.infradead.org; Wed, 27 May 2020 19:40:17 +0000 Received: by mail-lj1-x241.google.com with SMTP id c11so28268549ljn.2 for ; Wed, 27 May 2020 12:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JoA+ltY04rTbNuPqoR5f7m96ZZzh4EiSS3yqsY7/Fkk=; b=hPL8fiE399pTijYYRRViKesbZjUEdR+1xrxi15mivx2UishaS/MyGdfufOhOuh4nJC 9DUnu5lvoCIClNGhanYt78Spn/6lz6zJeb3f1R1yoUauNsfdQgAnT10eHlqd3dA2XxFA Wg3afUHR2XHL8Zs4PeqBof/vcTQa6b4reFBUU69cmsy3v+WHduqyYbNr7/uT0POOWyIb Pd9gtwh9o1vSLmlP5F8Wg9VveNOpMqacFmDDbP1kCj2b8X4Yz6f0DWDOd4IXybnXLHMc rqQth6s35/EOBBV/PYDci0vcE4tOXgfTbpJtEYpdvdMfOxYYHPxZ/7V0n7zGJrXURm7J siEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JoA+ltY04rTbNuPqoR5f7m96ZZzh4EiSS3yqsY7/Fkk=; b=rSw2znI3/GbzmpC0+8SXSnvM8yj9UqXlzFW/EhgPxT45Nk6pVcaYdHEP3Zsa7Rqyy4 /DCdh66U1/Pa2N7q4SE1WRboNbdHW1KCvxcKc6m/UqLHNjd5XiJPYpKP5aVFEYN7FwMb JNkVm7W0nKYKizoIcS72CH6FnSIcD21QnmZXsnxfTeG8X7gqEZ0P4E0CWvSIa1X4RAfU FJ5gjCn3VHTP1QtHxfPYy6i2AjPIAEkfDQMNVQwTq2EBCDhOlQEqxfcn5EldwhxNWTXw DYOq+pRsx1XKUVjIrgbawLZ843/VfKCWRBeA4S5hk56nbCZEhI7bTP/DvvdMnN481LN4 gRMw== X-Gm-Message-State: AOAM530HVYZvnmCscvUluzF1w04LgCOdzUAudjIdBQH5K9lOHd/KqGr0 sbfXGu9YoSPxzlUqHd2XBbWnqP6O6UTCFAffXqBmsQ== X-Google-Smtp-Source: ABdhPJzvKaopQeuSH++NfG6+ePzdECIe55mSMz1vGorLjrgnNGhLypFBTCO3NOV35EuZEgNnmnk7AN6/T2UVknXBfxI= X-Received: by 2002:a2e:8ed3:: with SMTP id e19mr4027321ljl.367.1590608413785; Wed, 27 May 2020 12:40:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Anholt Date: Wed, 27 May 2020 12:40:02 -0700 Message-ID: Subject: Re: [PATCH v3 055/105] drm/vc4: hvs: Introduce a function to get the assigned FIFO To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_124016_248578_21201B8A X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > At boot time, if we detect that a pixelvalve has been enabled, we need to > be able to retrieve the HVS channel it has been assigned to so that we can > disable that channel too. Let's create that function that returns the FIFO > or an error from a given output. > > Signed-off-by: Maxime Ripard > --- > +int vc4_hvs_get_fifo_from_output(struct drm_device *dev, unsigned int output) > +{ > + struct vc4_dev *vc4 = to_vc4_dev(dev); > + u32 reg; > + int ret; > + > + switch (output) { > + case 0: > + return 0; > + > + case 1: > + return 1; > + > + case 2: > + reg = HVS_READ(SCALER_DISPECTRL); > + ret = FIELD_GET(SCALER_DISPECTRL_DSP2_MUX_MASK, reg); > + if (ret == 0) > + return 2; > + > + return 0; > + > + case 3: > + reg = HVS_READ(SCALER_DISPCTRL); > + ret = FIELD_GET(SCALER_DISPCTRL_DSP3_MUX_MASK, reg); > + if (ret == 3) > + return -EPIPE; > + > + return ret; > + > + case 4: > + reg = HVS_READ(SCALER_DISPEOLN); > + ret = FIELD_GET(SCALER_DISPEOLN_DSP4_MUX_MASK, reg); > + if (ret == 3) > + return -EPIPE; > + > + return ret; > + > + case 5: > + reg = HVS_READ(SCALER_DISPDITHER); > + ret = FIELD_GET(SCALER_DISPDITHER_DSP5_MUX_MASK, reg); > + if (ret == 3) > + return -EPIPE; Oh, FIELD_GET is new to me. Looks like we should replace VC4_GET_FIELD usage with just using that header, and also VC4_SET_FIELD with WARN_ON(!FIELD_FIT()); FIELD_PREP. Could you follow up with that? Other than that, 54-67 r-b. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel