From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F13C2BD05 for ; Mon, 24 Jun 2024 11:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QteiONYM0/7wKm8o/iZbfkWsRu+IEcJCYcDxA/UWpZM=; b=DhKTZCBecQ645+oaYZemVG3BPm fpAH8U9llld7qaNZqwrDB3Oj9w1F2Hf/bR567MVjKIZWnrqlduQ0jYvMkEG6v275VXfE5wWkYv4mC vPjSmDm+lY64An7YLurRZXPc+WFkoRSwQMplnCm4cp9EHrLP3/raPtPS4shGJCffgquHSDNdWgos3 9aeMGBVErAIyoK6Wf3YSzA+TKIWRSrY/TNLNZYxb1NrWyzRNuhmLdmeH/hjmvJFaGSyLQ6ohu3lb2 t7bJGebHrFS/a9FEUA97BbmVhHrDy5xhxjn0wghlYbS3AxisIyYAGmO+ye6XR1L1LTeboWMedKy+j 3ExbJQ4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLhsC-0000000GbKQ-3q5p; Mon, 24 Jun 2024 11:28:36 +0000 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLhs7-0000000GbJ7-1AR7 for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 11:28:32 +0000 Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5c1adbcaad3so1883367eaf.1 for ; Mon, 24 Jun 2024 04:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719228510; x=1719833310; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QteiONYM0/7wKm8o/iZbfkWsRu+IEcJCYcDxA/UWpZM=; b=xFgkrtuPN97wsO0BKugskgXE2mfUMevxePkq5BlgOPioCkjCQN3j/WNBGvrey8En7f f3NbSUgtBpKhwB0Ed5hI7K1oz+ZeEFPZxUsPZm433gBiFvjhBf9xl+tsm7D0CzFpXESe EvuYkP9sigrXfJV1VQ215NpKtR/aN4eyHxMe0nVbTObzslPJbZcQ6gNl1yuS9odHU0Gb Q47x2MqmBYv8TUGJjSD6Gr3hblYhfmSwszZYNnWSUYBQTslZFYMsqSWcCfHhKBqi94Yu AoabYXwWSWEJss3FxNShjPfqqH1wnxxGzvbCWm5nm2Ruq3bE8HYykV8YDUmaL3YHgofr EYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719228510; x=1719833310; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QteiONYM0/7wKm8o/iZbfkWsRu+IEcJCYcDxA/UWpZM=; b=AonWlJdEpfdUpaLOTEr/RdtuH5tqx2L+NCez6oSGX4m3I8ONgHZD22loJkb1sVs8JA VQiseKgp9KdX0dtRorKO2zzfE9iAoLfMaVajagkTVO7WglFiHNafmzHjVgLl4LJLpfRv Lk8+G7MOr/b4dQ4sj2zwwGJtog6/7foJDJmlMzOscvHNPiqPxZtzD2rHLLAwWGcLaQKC Qd/5H9pku1BaqyIqj+F5KvneJigOGTP7HUy+oyc06zk+uNd4DULPtQ81IYL3kMIzBQXR c+iS+J8lB823TaI/atLZEedJezy+MMy6DbLcsWLabfrbsJQLBjEaCubVKjg+mGIUz/DA MBMA== X-Forwarded-Encrypted: i=1; AJvYcCWxgyveqsr8IlU92cUyV3jWdib7Su9YHA7EkSCwu3+IUtPyEH0uqzwsWW/HtXxTPR6j0U1pkpu5fl9fHVWQd6zYNiticg/7SyC2WhLYYo8g4k7A7s4= X-Gm-Message-State: AOJu0YwSBN/isw3XqTgoADFjpnXsaW9YauwT3+tIMbTogj7RUfWc5Sox 0xIj+knPvLsmGUdvs1Q11tQL536oNrgKRZxa3PBOfZLPng+UuU9kKZrSHSJHfh7GICMzrhGAkIh 7KBk9U7PWhE9pLgTMOx8UfSosreglEtNjE+dQUw== X-Google-Smtp-Source: AGHT+IFlNv2FZElqgVQlBk87lsFwbs9c65tZcdtCpO79u3aNcvuYkknMUcQr9mTDHrMDvpletr+cOs9nxhTCAnVSEb4= X-Received: by 2002:a05:6820:60f:b0:5c1:e83b:ee10 with SMTP id 006d021491bc7-5c1e83bef4amr2456768eaf.1.1719228509995; Mon, 24 Jun 2024 04:28:29 -0700 (PDT) MIME-Version: 1.0 References: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> In-Reply-To: <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> From: Peter Griffin Date: Mon, 24 Jun 2024 12:28:18 +0100 Message-ID: Subject: Re: [PATCH v3 5/6] phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk To: =?UTF-8?Q?Andr=C3=A9_Draszik?= Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Sam Protsenko , Krzysztof Kozlowski , Tudor Ambarus , Will McVicker , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_042831_679364_FFF63B9A X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andr=C3=A9, On Mon, 17 Jun 2024 at 17:45, Andr=C3=A9 Draszik = wrote: > > Using the regulator_bulk APIs, the handling of power supplies becomes > much simpler. There is no need anymore to check if regulators have been > acquired or not, the bulk APIs will do all the work for us. We can also > drop the various handles to the individual power supplies in the driver > runtime data and instead simply treat them all as one thing. Error > cleanup also becomes much simpler. > > Converting to the regulator_bulk APIs also makes it easier to add > support for those SoCs that have additional power supplies for the PHY. > Google Tensor gs101 is one example of such a SoC. Otherwise we'd have > to add all additional supplies individually via individual calls to > regulator_get() and enable/disable handle them all individually, > including complicated error handling. That doesn't scale and clutters > the code. > > Just update the code to use the regulator_bulk APIs. > > Signed-off-by: Andr=C3=A9 Draszik > --- Reviewed-by: Peter Griffin and Tested-by: Peter Griffin Tested using my Pixel 6 pro device. USB comes up and it is possible to use adb from the host computer to the phone. regards, Peter [..]