From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8774DC41535 for ; Fri, 22 Dec 2023 17:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dEfOXX1WdOqy1G4ivZ/1pnw9CDeCOZlMckFqC1WEVpk=; b=f9H6glOaLHpwk4 cJ4Lm4iMvBl6WoJisM9WcEtEUzc6NoMJNs1XTNFuY7MzO3XA6Poh9CH5MoOaEEOwg6d+5zlls8iyk rTY2f+LJAhT+N3eMBNO/in4ehaXSm/OfLJzKWXWtgU1hLV6ydeQdG1q8bX+hC8i56zHKCu6sVaM10 zZNWY5iJmjmJC0QVj6cN7+fN9G2EdAw/GBer9ZmPbiaYrN2Rb3JfV2aws+PWdV+5faB3RYurPkqGK zWKSsac+nfWdG1+fuh1zvLralJVKJQ4zrGhtc/Wp1llsgrVecAF/s9XTNkQPP/KJWJ2/55yowZ6+A 6qU9MuLn4tcyYXfW6Ffg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGjlK-006bZD-1a; Fri, 22 Dec 2023 17:56:42 +0000 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGjlH-006bYq-2l for linux-arm-kernel@lists.infradead.org; Fri, 22 Dec 2023 17:56:41 +0000 Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-7812bed1c86so56810185a.0 for ; Fri, 22 Dec 2023 09:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703267797; x=1703872597; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/HhLTRm08Y43dtSXWxfZ5KzfsdQRFgDHvFFek/ks+PY=; b=aDHOdbfiS29NOFnDg0OhIAO24FgzCxVXmF6DAIlk+c+L3kbU48wuw8HRemvD1hPh5+ maB07S3gMcXCjRFK2bFeRxbEagh2H6k5SwcKMT5t2VfxAIad2WsTr/cvn3ZwGqgWOBuc 5nAOJgl7pEikaISiPMtRsUifqDk5gAiHJGNkJJbmefNnWXUBs8b0PwM6GLsDkj9MChDD TbzCvmvo6tCU9prUXYqmBA4+RA2UCllGC8qf9GfshyYxM/YNt9eNt5xqMSNaTsEGD0ky tr43UiD1GKnijz4bK9ZfGbEIC3wXFWGVeVQ9jmbympDoCCTlKoqOj6rVDprCfmi1eVEX 84kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703267797; x=1703872597; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/HhLTRm08Y43dtSXWxfZ5KzfsdQRFgDHvFFek/ks+PY=; b=B5RHRMmlFz1aBGxa3M0oU2DbKicC92AJVbE1g4/+ThtYFInS1inuZ75x7erCyq3IWe GKYrX9N4cqfZtwdR68qUdFKPZgZcz+ozQhwxYLMSaysMQG3hRu87SYi2uWKMTz56wnlp 0/VXu+mFte0UCO7ujGIdlYtvuibtB+kn3OobhffaSyoiXdxK3W3/R+j4oyIrNBO6vcfP S0pd6o0+GXPa/gd4cZKO0fju2McUcM+oVq/rWrep0IGXNpdNnc+ly2deQosSlSXr+e0t NCnQdpJG9LUmuZjrkgIc/CTv+YM4OR3KxuwTVflor/w7gZs/0Rp0E3LGxyCnSpl8731z BsuQ== X-Gm-Message-State: AOJu0YzGKzkCFmUztf7wiU50SN8ZFEZrzsSlHfsJnOqgrvsqBmzRtMc0 66vTCgGO9tPnpCfn61VRwxNOVdEWXFvNgEsjSef9/TAubaAG0w== X-Google-Smtp-Source: AGHT+IG9Aiis1ajE6B2jjYD+C15ieRSm6oqpOi9lEtvJS7UBbdBf4Zjd9BXZZQoWAgS4DtHb8E2xzJl/+Kil1Evx0XA= X-Received: by 2002:a05:6214:1301:b0:67f:f64:8dce with SMTP id pn1-20020a056214130100b0067f0f648dcemr1955342qvb.108.1703267797556; Fri, 22 Dec 2023 09:56:37 -0800 (PST) MIME-Version: 1.0 References: <20231214105243.3707730-1-tudor.ambarus@linaro.org> <20231214105243.3707730-3-tudor.ambarus@linaro.org> <20231220150726.GA223267-robh@kernel.org> <173b06ab-2518-49ee-a67f-85256bc5b6a7@linaro.org> In-Reply-To: <173b06ab-2518-49ee-a67f-85256bc5b6a7@linaro.org> From: Peter Griffin Date: Fri, 22 Dec 2023 17:56:26 +0000 Message-ID: Subject: Re: [PATCH 02/13] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit To: Tudor Ambarus Cc: Rob Herring , krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, catalin.marinas@arm.com, will@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231222_095639_902361_5E257E83 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tudor, On Thu, 21 Dec 2023 at 07:20, Tudor Ambarus wrote: > > > > On 12/20/23 15:07, Rob Herring wrote: > > On Thu, Dec 14, 2023 at 10:52:32AM +0000, Tudor Ambarus wrote: > >> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0) > >> clock management unit. > >> > >> Signed-off-by: Tudor Ambarus > >> --- > >> .../bindings/clock/google,gs101-clock.yaml | 25 +++++- > >> include/dt-bindings/clock/google,gs101.h | 86 +++++++++++++++++++ > >> 2 files changed, 109 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > >> index 3eebc03a309b..ba54c13c55bc 100644 > >> --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > >> +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > >> @@ -30,14 +30,15 @@ properties: > >> - google,gs101-cmu-top > >> - google,gs101-cmu-apm > >> - google,gs101-cmu-misc > >> + - google,gs101-cmu-peric0 > >> > >> clocks: > >> minItems: 1 > >> - maxItems: 2 > >> + maxItems: 3 > >> > >> clock-names: > >> minItems: 1 > >> - maxItems: 2 > >> + maxItems: 3 > >> > >> "#clock-cells": > >> const: 1 > >> @@ -88,6 +89,26 @@ allOf: > >> - const: dout_cmu_misc_bus > >> - const: dout_cmu_misc_sss > >> > >> + - if: > >> + properties: > >> + compatible: > >> + contains: > >> + const: google,gs101-cmu-peric0 > >> + > >> + then: > >> + properties: > >> + clocks: > >> + items: > >> + - description: External reference clock (24.576 MHz) > >> + - description: Connectivity Peripheral 0 bus clock (from CMU_TOP) > >> + - description: Connectivity Peripheral 0 IP clock (from CMU_TOP) > >> + > >> + clock-names: > >> + items: > >> + - const: oscclk > >> + - const: dout_cmu_peric0_bus > >> + - const: dout_cmu_peric0_ip > > > > 'bus' and 'ip' are sufficient because naming is local to the module. The > > same is true on 'dout_cmu_misc_bus'. As that has not made a release, > > please fix all of them. > > > > Ok, will fix them shortly. Thanks, Rob! With Robs review comments addressed feel free to add my: Reviewed-by: Peter Griffin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel