From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B477C4167B for ; Mon, 11 Dec 2023 10:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uplkKuozrYjJliwS5TYzG2Lu796lHMHvv+kJer8tKXk=; b=OscCqAJvFYxR2M gLJrF4YpExctGDSOlPdi25FoewSNAQAc3MeRzgkJVnhgo4ji1r40Vcn2RGTq32ONhP3fA1YC2rHCi RZglDCvz1PuGK77pBsj1+KhVPAJULehY/KaBV8czhTJ/v/Ss+O8uSiExSisWIbRvjJKwEVrHsjG0r n9LXc5CsM+gULSTFdXsn3LMpyKUFtmVxOsLbBOJn+YZ3gXjkJmu+c34zxLh3LRVqPVoR5yxaSThAD Dk3nBkZQtxhWD7CQLREm7CiuRX7h5/wUbtyy81yNqScZFrbgmIN6giK2N3xdRlKbosykzp9Bw/m8w ToTJpt6qF3d+KbyjnK5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCdV5-004bVM-0O; Mon, 11 Dec 2023 10:26:59 +0000 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCdUx-004bUq-2W for linux-arm-kernel@lists.infradead.org; Mon, 11 Dec 2023 10:26:57 +0000 Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-677fba00a49so34308246d6.1 for ; Mon, 11 Dec 2023 02:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702290411; x=1702895211; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zBClK4lqtI01tZ9y+a3IQvx46bQqW6gXipVJViDNMLE=; b=iHSCmE0IqlMogBccl9pF1mliVlECUnz8vS6voiTYBK1EX874tK+k6OZ88v9+Utn0mR pBNcvYZn7I1izZ9K7iBC8WK8R058YKfGbi+XDErTN287BlA98iWqpTQDkw5saB30WMaI Xh8Mb0DG8KAWyzwFdEhTXRWJqrbyWz3JJAVfhNo+4gz/dFN1u7D7hAha4qORJh1wbDOz X6oiitcg/RJZiddcF3KBySirtW3PhRR8dgEZUIdsJEgBXq3PHfjKWjLsmz/2jryr6923 Vwn9WP2p2YLF/Mh2PozdlaG5SndST04NyG2Gso1mvoEcfpIOm1DchRtSPybYhvelImaK H8Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702290411; x=1702895211; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zBClK4lqtI01tZ9y+a3IQvx46bQqW6gXipVJViDNMLE=; b=mm0QsNkdyQ6ukzPHq1VPgeV0TiYSYAbSfizQsAjJc4+nndVlDiweFpYbzXDO3uqb2M rS/YA201K6gzqAeX/Dy/0WtjoJuD2Iu0i1oehaAI/80iR2BW5assf5tGkM42EB2y+j/N jx2P+s63UWXboLWjZb56vDd6JsU4BzKetOVK1j0wXwoTcRRXBxuMal4iQvZBTBb5yrTc tqR8GtLGbkQ2GmyxGDrT0yxW1qPAVmMxsnMbNaNypp7EJVNQ5q5SVQU68H8rO9+Nh+D+ v9YNBylp1UDjk9nXMvGjW4feAksuewjzicpzDQlKABPFORzXzvdmwUesdSB5ppCvARXG 8PAw== X-Gm-Message-State: AOJu0YwLKtglybR3RS0cfioUi56mMNvJRQef4GZZd9oVz0y89d/AMC8p 4VTCB03kWlddh0jtPg6phjV5MQGULpqdXnJThOvOFw== X-Google-Smtp-Source: AGHT+IGXuSEmjxGIf3QPro+i3LI5BnTbhCqPp7O7UIiBh/LqSwNTV/bm9Ks6TLe0NeBnUASLNjJvb+hNli7R0WXRvsA= X-Received: by 2002:a0c:fb04:0:b0:67a:ad44:2126 with SMTP id c4-20020a0cfb04000000b0067aad442126mr5413328qvp.60.1702290410972; Mon, 11 Dec 2023 02:26:50 -0800 (PST) MIME-Version: 1.0 References: <20231209233106.147416-1-peter.griffin@linaro.org> <20231209233106.147416-17-peter.griffin@linaro.org> <25533a7f-326f-48d1-a8a6-e5798bdca4b4@linaro.org> In-Reply-To: <25533a7f-326f-48d1-a8a6-e5798bdca4b4@linaro.org> From: Peter Griffin Date: Mon, 11 Dec 2023 10:26:39 +0000 Message-ID: Subject: Re: [PATCH v6 16/20] watchdog: s3c2410_wdt: Add support for Google gs101 SoC To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_022651_820911_86602AAE X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for the review. On Sun, 10 Dec 2023 at 14:26, Krzysztof Kozlowski wrote: > > On 10/12/2023 00:31, Peter Griffin wrote: > > This patch adds the compatibles and drvdata for the Google > > gs101 SoC found in Pixel 6, Pixel 6a & Pixel 6 pro phones. > > > > Similar to Exynos850 it has two watchdog instances, one for > > each cluster and has some control bits in PMU registers. > > > > > > + > > static const struct of_device_id s3c2410_wdt_match[] = { > > { .compatible = "samsung,s3c2410-wdt", > > .data = &drv_data_s3c2410 }, > > @@ -285,6 +318,8 @@ static const struct of_device_id s3c2410_wdt_match[] = { > > .data = &drv_data_exynos850_cl0 }, > > { .compatible = "samsung,exynosautov9-wdt", > > .data = &drv_data_exynosautov9_cl0 }, > > + { .compatible = "google,gs101-wdt", > > + .data = &drv_data_gs101_cl0 }, > > Keep some alphabetical order by compatible, so this should be probably > the first entry in the table. > > Same for s3c2410_wdt_variant structures. Will fix in v7. Thanks, Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel