From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74F5BC433F5 for ; Tue, 1 Feb 2022 10:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5NxRFug5R34N+GYdBS3c2J8eWZfLonYq84XGkz5t4lk=; b=GTUO9YED4DtTrB kC7O4Y8hX2570kAkaZGqfETmvD9WnofJAOTwQZyOUuGeTI3OlWvjb9g3r+GASZHgZZ6/KsT7lxXBx wbI03B2aE6gbfdPszBw++Ecnsm8N1bkczDYqTDdbzHJ2gk42vacO6OWq5nJ3trdltc87fKidUkn15 gS9rVhfZIsWkSwAH1Q628jyi0P8coKQ1nuFsF2yEBOoa6t/OULv0uptusoiq7efBnn5kWaVhorsYi j/Kza5bGi5eD+bIa9Ii3qBAaTxH1sSumYiBMvQ3IPHj4e8XgYohVFKdezoCEWMwX7dUGisx5ToKjb IklhM6dSe2HqJz1iImYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEq0D-00BgcY-FI; Tue, 01 Feb 2022 10:03:09 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEq09-00BgaQ-EG; Tue, 01 Feb 2022 10:03:06 +0000 Received: by mail-ej1-x635.google.com with SMTP id h7so52537741ejf.1; Tue, 01 Feb 2022 02:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mClIZuGiU90N8/wVEGuz0kPrT8HDVsO1SF0mMBp9TKA=; b=m8l3iizy6m+bL/jBYQ1WY3ATqWzlyg2KTCyNULM3eVNvkC5wqKTucOmaIxZWFKKHKC O4vEtqtNwuq399PL5WPFG5Z7vCu6zPPjoimtCnr8vb/5lojlVqjvZJwxMJzVd0Vk35+r ZVAR+4L1KqtGJhgkD+zr3U76KGUGG1P7/BPweFRor+Y6JBV2yCS0CX+UFmYJA0lC10As KSMXOwfQMpM5C1cOo7NxFB454lv8KZ0AWzZzM/pxNJiKv31JpTcyWfsVCUPzCl573dFS WOqZrDF8DuO60afmvVeUg1FCdgzqdmHYIJrUyRb6laaV9nlyKLCU0X2qcosie45x9Rgc yezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mClIZuGiU90N8/wVEGuz0kPrT8HDVsO1SF0mMBp9TKA=; b=lvK/eLm4OhkawIpmpJL2jiTT7+W/Imiak0w+PjM3vLRh+I/nuHtNVqaRfKC61aSKMk 6atYYD3vYx8JlrysPV5CbtYZHpZt44KJ/Ml8NQaZy4YNhIXEzerJWnD9z+m0GOQwSJDB 4sTrjnDM/6IOcSwLdMNG7sm/AkxhJHMtI+4K0kikiCXXlFZBOZZ1wK+1WLRtzpPnO/v8 y6u7NOA3crYywU241yoECGKbyTbqHd0Mx0cMmZ/3UTSFSIirjkwwcGaepsTyepcQjDU5 Pghb4ix8SI+KBF6N8Msw2rYtIZIXPrcehEH1YyZJajqlwfs83C+hWgrmVLD7E/PHGmb1 xquA== X-Gm-Message-State: AOAM532KW9sY/VX+sqo3o02cOcmeMlScO46PNc3Pc7gQdSl5T9zHiPi2 pgysXY1Jiip72eZTm+T0I5W18e5erGoPB9/cj+8= X-Google-Smtp-Source: ABdhPJyfD5PfJ3o2DgbfikfmuisQ6IDuSCV1txCGADlAID79HMnZ8k2HT/445aAlBSn/3Hrxj9wDnw0NxNHNH60hLfE= X-Received: by 2002:a17:907:1c1c:: with SMTP id nc28mr20280513ejc.651.1643709778741; Tue, 01 Feb 2022 02:02:58 -0800 (PST) MIME-Version: 1.0 References: <20220128151540.164759-1-david@redhat.com> In-Reply-To: <20220128151540.164759-1-david@redhat.com> From: Anatoly Pugachev Date: Tue, 1 Feb 2022 13:02:45 +0300 Message-ID: Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() To: David Hildenbrand Cc: Linux Kernel list , linux-mm , Andrew Morton , Greg Kroah-Hartman , Michal Hocko , Oscar Salvador , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Rafael J. Wysocki" , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390 , linux-sh@vger.kernel.org, Sparc kernel list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_020305_504234_13712924 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 31, 2022 at 2:11 PM David Hildenbrand wrote: > > ... and call node_dev_init() after memory_dev_init() from driver_init(), > so before any of the existing arch/subsys calls. All online nodes should > be known at that point. > > This is in line with memory_dev_init(), which initializes the memory > device subsystem and creates all memory block devices. > > Similar to memory_dev_init(), panic() if anything goes wrong, we don't > want to continue with such basic initialization errors. > > The important part is that node_dev_init() gets called after > memory_dev_init() and after cpu_dev_init(), but before any of the > relevant archs call register_cpu() to register the new cpu device under > the node device. The latter should be the case for the current users > of topology_init(). > > RFC because I tested only on x86-64 and s390x, I think I cross-compiled all > applicable architectures except riscv and sparc. Compiled and boot tested on sparc. Tested-by: Anatoly Pugachev (sparc64) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel