From: v1ne2go@gmail.com (Denis Schneider)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem
Date: Wed, 9 Jul 2014 16:31:58 +0200 [thread overview]
Message-ID: <CAE8M+o+c7y9mK531V4NbR4E4bggR3zHzSSJkV7z_ioBYx8NtcA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407081552200.27641@kaball.uk.xensource.com>
2014-07-08 17:40 GMT+02:00 Stefano Stabellini
<stefano.stabellini@eu.citrix.com>:
> Hi all,
> Xen support in Linux for ARM and ARM64 suffers from lack of support for
> multiple mfn to pfn mappings: whenever a frontend grants the same page
> multiple times to the backend, the mfn to pfn accounting in
> arch/arm/xen/p2m.c fails. The issue has become critical since v3.15,
> when xen-netfront/xen-netback switched from grant copies to grant
> mappings, therefore causing the issue to happen much more often.
>
> Fixing the mfn to pfn accounting in p2m.c is difficult and expensive,
> therefore we are looking for alternative solutions. One idea is avoiding
> mfn to pfn conversions altogether. The only code path that needs them is
> swiotlb-xen:unmap_page (and single_for_cpu and single_for_device).
>
> To avoid mfn to pfn conversions we rely on a second p2m mapping done by
> Xen (a separate patch series will be sent for Xen). In Linux we use it
> to perform the cache maintenance operations without mfns conversions.
>
>
> Changes in v2:
> - introduce XENFEAT_grant_map_11;
> - remeber the ptep corresponding to scratch pages so that we don't need
> to calculate it again every time;
> - do not acutally unmap the page on xen_mm32_unmap;
> - properly account preempt_enable/disable;
> - do not check for mfn in xen_add_phys_to_mach_entry.
>
>
> Stefano Stabellini (3):
> xen/arm: introduce XENFEAT_grant_map_11
> xen/arm: reimplement xen_dma_unmap_page & friends
> xen/arm: remove mach_to_phys rbtree
>
> arch/arm/include/asm/xen/page-coherent.h | 25 ++--
> arch/arm/include/asm/xen/page.h | 9 --
> arch/arm/xen/Makefile | 2 +-
> arch/arm/xen/enlighten.c | 6 +
> arch/arm/xen/mm32.c | 202 ++++++++++++++++++++++++++++++
> arch/arm/xen/p2m.c | 66 +---------
> include/xen/interface/features.h | 3 +
> 7 files changed, 220 insertions(+), 93 deletions(-)
> create mode 100644 arch/arm/xen/mm32.c
Tested-by: Denis Schneider <v1ne2go@gmail.com>
Stress-tested with network I/O, disk I/O for hours without any problem. Thanks.
prev parent reply other threads:[~2014-07-09 14:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 15:40 [PATCH v2 0/3] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem Stefano Stabellini
2014-07-08 15:42 ` [PATCH v2 1/3] xen/arm: introduce XENFEAT_grant_map_11 Stefano Stabellini
2014-07-08 15:49 ` Ian Campbell
2014-07-08 15:54 ` Stefano Stabellini
2014-07-08 15:59 ` Ian Campbell
2014-07-08 16:53 ` [Xen-devel] " Julien Grall
2014-07-08 16:16 ` David Vrabel
2014-07-08 15:42 ` [PATCH v2 2/3] xen/arm: reimplement xen_dma_unmap_page & friends Stefano Stabellini
2014-07-08 15:42 ` [PATCH v2 3/3] xen/arm: remove mach_to_phys rbtree Stefano Stabellini
2014-07-08 16:05 ` [Xen-devel] [PATCH v2 0/3] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem Konrad Rzeszutek Wilk
2014-07-09 10:30 ` Stefano Stabellini
2014-07-09 13:47 ` Konrad Rzeszutek Wilk
2014-07-09 14:14 ` Stefano Stabellini
2014-07-09 14:31 ` Denis Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE8M+o+c7y9mK531V4NbR4E4bggR3zHzSSJkV7z_ioBYx8NtcA@mail.gmail.com \
--to=v1ne2go@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).