From: bcm@fixthebug.org (Christian Daudt)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
Date: Wed, 8 Jan 2014 15:38:49 -0800 [thread overview]
Message-ID: <CAEPRUYo0r5YcRTYdgSNLqedVV4D0bsor7USBoxRRpBXRs7wpbw@mail.gmail.com> (raw)
In-Reply-To: <1389120821-12007-1-git-send-email-tim.kryger@linaro.org>
On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
> when card is inserted" so the polarity has been updated to active low.
>
> Polarity is now specified with a GPIO define instead of a magic number.
>
> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> ---
> arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
> index 08e47c2..27dd110 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -13,6 +13,8 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/gpio/gpio.h>
> +
> #include "bcm11351.dtsi"
>
> / {
> @@ -40,7 +42,7 @@
>
> sdio4: sdio at 3f1b0000 {
> max-frequency = <48000000>;
> - cd-gpios = <&gpio 14 0>;
> + cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
> };
> --
> 1.8.0.1
>
Tim,
Does bcm11351-brt not also suffer from the same bug? If it does can
you pls update the patch to also fix it?
Thanks,
csd
next prev parent reply other threads:[~2014-01-08 23:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 18:53 [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO Tim Kryger
2014-01-08 23:38 ` Christian Daudt [this message]
2014-01-09 0:28 ` Tim Kryger
2014-01-09 0:54 ` Christian Daudt
2014-01-24 18:48 ` Tim Kryger
2014-01-31 23:11 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2013-12-05 21:51 Tim Kryger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEPRUYo0r5YcRTYdgSNLqedVV4D0bsor7USBoxRRpBXRs7wpbw@mail.gmail.com \
--to=bcm@fixthebug.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).