From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Jerome Brunet" <jbrunet@baylibre.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH v4 4/4] pwm: meson: make full use of common clock framework
Date: Sun, 23 Apr 2023 22:55:19 +0200 [thread overview]
Message-ID: <CAFBinCCV95Q8eCvUBH0VHgFdm7_kot5oVfPdBTppUQbw2g0+qw@mail.gmail.com> (raw)
In-Reply-To: <7601c976-3195-a35d-236c-9bd386dfe8e0@gmail.com>
Hello Heiner,
apologies for the late reply - I've been busy with offline things.
On Sun, Apr 16, 2023 at 11:34 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
[...]
> >> With a 850MHz input clock we should see a 0.01% duty cycle with 1.2ns
> >> clock pulses. Can we rule out an issue with the measuring equipment?
> >> Is your logic analyzer able to display such short clock pulses?
> > Oh, you're right: my logic analyzer maxes out at 24MHz (~42ns).
> > So we can ignore this case.
> >
> >>> Finally I tried period = 12218, duty cycle = 12218 (typically used for
> >>> the lowest CPU voltage):
> >>> before your patches / after applying your patches:
> >>> PWM: duty cycle: 99.661017% / n/a (constant low output)
> > I have to correct myself: for this case my logic analyzer sees a:
> > constant high signal
> >
> So conclusion is that the PWM output is as expected? If yes, then the
> memory corruption you saw supposedly had another root cause?
You are right:
- For this case my logic analyzer is also too slow
- In the meantime I've been able to reproduce the memory corruption
issue without your patch
> Eventually your Tested-by could be re-instantiated?
Indeed, and in addition to SM1 I have also tested it on Khadas VIM2 (GXM SoC):
[ 4.135944] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4356/2
wl0: Apr 9 2021 00:40:07 version 7.35.349.104 (775a9ab CY) FWID
01-64b609e0
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-23 20:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 5:48 [PATCH v4 0/4] pwm: meson: make full use of common clock framework Heiner Kallweit
2023-04-13 5:49 ` [PATCH v4 1/4] pwm: meson: switch to using struct clk_parent_data for mux parents Heiner Kallweit
2023-04-13 5:50 ` [PATCH v4 2/4] pwm: meson: don't use hdmi/video clock as mux parent Heiner Kallweit
2023-04-13 5:51 ` [PATCH v4 3/4] pwm: meson: change clk/pwm gate from mask to bit Heiner Kallweit
2023-04-13 5:54 ` [PATCH v4 4/4] pwm: meson: make full use of common clock framework Heiner Kallweit
2023-04-14 19:39 ` Martin Blumenstingl
2023-04-15 6:39 ` Heiner Kallweit
2023-04-16 19:26 ` Martin Blumenstingl
2023-04-16 21:34 ` Heiner Kallweit
2023-04-23 20:55 ` Martin Blumenstingl [this message]
2023-04-17 7:23 ` Neil Armstrong
2023-04-17 9:17 ` Thierry Reding
2023-04-17 9:53 ` Heiner Kallweit
2023-04-17 9:59 ` neil.armstrong
2023-04-17 10:36 ` Heiner Kallweit
2023-04-17 12:21 ` neil.armstrong
2023-04-19 19:58 ` Heiner Kallweit
2023-04-21 7:39 ` neil.armstrong
2023-04-23 20:58 ` Martin Blumenstingl
2023-05-01 13:39 ` Heiner Kallweit
2023-05-19 15:30 ` Dmitry Rokosov
2023-05-19 16:53 ` Heiner Kallweit
2023-05-22 13:37 ` Dmitry Rokosov
2023-05-22 20:10 ` Heiner Kallweit
2023-05-23 10:28 ` Dmitry Rokosov
2023-05-23 19:22 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCV95Q8eCvUBH0VHgFdm7_kot5oVfPdBTppUQbw2g0+qw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).