From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAE3C2B9F4 for ; Thu, 17 Jun 2021 22:12:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEE4861369 for ; Thu, 17 Jun 2021 22:12:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEE4861369 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kzFe22iX153V6ODbvcYa0qhj0qjWI1ez6CPpf+EmH/0=; b=UnuquajNgfcukT HI37Ly1shQDfDybiJHJlkXO2jtFpS7zGv9TTsvkz6qND4KSlp1s7q6NRzuszK4WaWh45lkPiWnbKn GjIzsTtoE/0twh3j0MWc/iDk7qwjE6bm1fya7sEmf71HdhFBcLvKZOY4TAiF1O0m29zYfFd3nU0sg BaVBdS8/FBxTkxrzo8NAi+mHK212lsyzsIIPVLld8c2xXhmgKifZ0+nGNl/LjojK9NmqtNIQohxnR aNe6QscsgPmWgtJT0ORuks8MwNFGtZnekGOio6SmQDiKhqJNPlTVUPzI6nRbXjEfON8bJ7v/cxF8x 2PwuhJAyq35Eol5cMUyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lu0EK-00BuiE-CW; Thu, 17 Jun 2021 22:11:20 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lu0EH-00BuhX-24; Thu, 17 Jun 2021 22:11:18 +0000 Received: by mail-ed1-x529.google.com with SMTP id r7so5794298edv.12; Thu, 17 Jun 2021 15:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zesdvlDOTsfJCYMfxYc1eGdUgx4s/GRB2e4AjzOW/PE=; b=c6d/7vzaOUVDMePr0fBGYrzT6WgLmo55vDCeFW1vzWwyGxuLIlhG7gIfj8nzNJV8n4 l9MRyCfWE8korSmGWWISVxk076slUO70E+qg/fu86m+bLv0AFxxLCtx9MADzS3WVZZ8i p5lcuLl2inhxGD5UK+n8/JszeE6MHb0efkxHaYvuLNBVtm1/xczacfrbC3heM9/dN32H E2zuS4aG5Q7IdGDhLzDVluLau1J85kuVISp6NXPdI8zHthb2E0Y8KAVe70C6XW7UPbl7 3TPXjv3Z9RDOZM9idFbHvkrj8av94bUt+JUqqqFEIp+rKTL4Cnnfl+jdfjuQEH+1r8F6 S6eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zesdvlDOTsfJCYMfxYc1eGdUgx4s/GRB2e4AjzOW/PE=; b=pdvfF5oOv+QueJOz5haVkYaIFcL622NY3OgWvvsw0GYlYvvrWYD8rQrvFZO+mdEB5B 4wB1xR5w/0WE8OJ6OhWHv+RnnQVUncou81bTKVu2rLhnElAJjYZSI5NLK19xE7/8+91D ga0LdUTlvDL4s9Ink5u20ncEo8/hGOXgpYbIiCQWpTrkC52mDLshIs0hcRAV5VLi91L9 GoxzWCsS9eWiOXcoXTrpJxlAI9KmOxpXJYTkjcvTzYDLawXC3/Cpj1lO3XBr8FlJhUZ+ /zQneLACapv28ZmU2JjbLG0OjpkppBshi/qEo0WTX84Qkv5xLYsCEvU09isctfGCFnik hamg== X-Gm-Message-State: AOAM533PuRUJ5XSUULQIwOylew0QFsP2+J5f3LKuftx9zdTdkuMaAAO8 0fDGJJFgmjX+AZjvRH7u+BxiV262Xk0MUvgy4TA= X-Google-Smtp-Source: ABdhPJy+s7G8n2muPksCVmlW0yHIS9m4Uk35n+fl3NqiK+lQz3IllqAa/h2ZJAFr1oZZRzDtew4JHXz2WSDJXOYfza0= X-Received: by 2002:a05:6402:177a:: with SMTP id da26mr724355edb.40.1623967873323; Thu, 17 Jun 2021 15:11:13 -0700 (PDT) MIME-Version: 1.0 References: <20210617194154.2397-1-linux.amoon@gmail.com> In-Reply-To: <20210617194154.2397-1-linux.amoon@gmail.com> From: Martin Blumenstingl Date: Fri, 18 Jun 2021 00:11:02 +0200 Message-ID: Subject: Re: [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure To: Anand Moon Cc: --to=linux-phy@lists.infradead.org, --to=linux-arm-kernel@lists.infradead.org, --to=linux-amlogic@lists.infradead.org, --to=linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , Neil Armstrong , Kevin Hilman , Jerome Brunet , Philipp Zabel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_151117_165835_C12A63F1 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anand, On Thu, Jun 17, 2021 at 9:42 PM Anand Moon wrote: > > On Odroid C1+ and Odroid C2 USB feature is broken with "broken" you mean the hotplug and IRQ issues you describe below? I think that these are not PHY related but rather a problem with the dwc2 IP/driver > this code changes are just re-structure the code so that > proper callback function execute in proper order. > > Code changes losely based on phy-meson-gxl-usb2.c there's a big difference between the Meson8 and GXL drivers: GXL requires changing some of the PHY registers at runtime based on the mode (host/peripheral). The Meson8 PHY however (as far as I can tell from the 3.10 and 3.14 kernels) don't require any runtime changes based on the mode. > Initially if we connect USB HDD at initial boot it get detected. > but after that usb hotplug of USB HDD is broken. > I did not observe and USB debug events messages to trace the root cause. > > Another issue I observed is increase of USB interrupts event > even if there is not much activity on USB ports. > I tried some clk changes but it did not workout for me. I suggest reporting this to the dwc2 maintainers and asking for advice on how to debug these issues. Best regards, Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel