linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter.maydell@linaro.org (Peter Maydell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: KVM: Allow host virtual timer irq number to be different from guest virtual timer irq number
Date: Thu, 25 Apr 2013 19:19:44 +0100	[thread overview]
Message-ID: <CAFEAcA_bPHkZX00ccUFg2mUXdmrui3XeBMg-rgxtsE_4-abeiA@mail.gmail.com> (raw)
In-Reply-To: <CAEDV+gLKwrxxdoB9NDBLb7CSnXL1j=O7f=2Y_ftXmLfGtTBnbA@mail.gmail.com>

On 25 April 2013 19:04, Christoffer Dall <cdall@cs.columbia.edu> wrote:
> I prefer not hard-coding this stuff in the kernel, but let user space
> decide this. If we have good technical arguments not to do that (such
> as knowing that this is always defined per-core and not for an SoC
> (ARM guys?) then at least the patch should lookup the target processor
> and set the irq number accordingly.

Well, this is all implementation-defined. The ARM ARM mandates
that the generic timers deliver a PPI, and that it must be the
same PPI for all processors in an MP implementation, but not which
PPI. The A15 and A7 happen to both be hardwired to ID27. You could
in theory design a core which let the SoC configure the virtual
timer ID (or let the guest arbitrarily program it, for that
matter, I suppose), though I'm not sure why you'd want to.

I think I'd take the simple approach of saying "the timer PPI
is a fixed property of the guest CPU" unless somebody actually
builds something where it isn't fixed... (for that CPU we
could then define it as a feature argument to KVM_ARM_VCPU_INIT).

thanks
-- PMM

  reply	other threads:[~2013-04-25 18:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25  8:45 [PATCH] ARM: KVM: Allow host virtual timer irq number to be different from guest virtual timer irq number Anup Patel
2013-04-25 18:04 ` Christoffer Dall
2013-04-25 18:19   ` Peter Maydell [this message]
2013-04-25 18:51     ` Christoffer Dall
2013-04-26  6:27       ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_bPHkZX00ccUFg2mUXdmrui3XeBMg-rgxtsE_4-abeiA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).