linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: achandran@mvista.com (Arun Chandran)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode
Date: Fri, 12 Jun 2015 12:28:48 +0530	[thread overview]
Message-ID: <CAFdej02+PtnRb_s8mxYu2rgAzihEMWekGyDfVGvkmszjf0x1pw@mail.gmail.com> (raw)
In-Reply-To: <5579CFCC.60905@xilinx.com>

On Thu, Jun 11, 2015 at 11:43 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 06/10/2015 04:13 PM, Arun Chandran wrote:
>> earlyprintk messages are not appearing on the terminal
>> emulator during a big endian kernel boot. If we
>> byte swap the sending data it comes properly.
>>
>> Signed-off-by: Arun Chandran <achandran@mvista.com>
>> ---
>> ---
>> This can be tested by adding 'early_print("early print test\n");'
>> to setup_arch() in arch/arm/kernel/setup.c
>> ---
>>  arch/arm/include/debug/zynq.S | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S
>> index bd13ded..0d274fe 100644
>> --- a/arch/arm/include/debug/zynq.S
>> +++ b/arch/arm/include/debug/zynq.S
>> @@ -38,6 +38,7 @@
>>               .endm
>>
>>               .macro  senduart,rd,rx
>> +ARM_BE8(     rev     \rd, \rd )
>>               str     \rd, [\rx, #UART_FIFO_OFFSET]   @ TXDATA
>>               .endm
>>
>>
>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
>

I think just using strb instead of str will do the work
much better. I have send v2 with that logic

Thanks for testing it.

--Arun

  reply	other threads:[~2015-06-12  6:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 14:13 [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode Arun Chandran
2015-06-11 18:13 ` Michal Simek
2015-06-12  6:58   ` Arun Chandran [this message]
2015-06-12  6:53 ` [PATCH v2] " Arun Chandran
2015-06-12  9:25   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFdej02+PtnRb_s8mxYu2rgAzihEMWekGyDfVGvkmszjf0x1pw@mail.gmail.com \
    --to=achandran@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).