* [PATCH] arm: omap3: igep0020: Add console default kernel arguments
@ 2012-12-20 15:41 Ezequiel Garcia
2012-12-21 16:02 ` Enric Balletbo Serra
0 siblings, 1 reply; 6+ messages in thread
From: Ezequiel Garcia @ 2012-12-20 15:41 UTC (permalink / raw)
To: linux-arm-kernel
IGEP v2 boards has console as ttyO2,115200n8.
It's better so simply set this as the default kernel argument
directly in the device tree board file.
Cc: Enric Balletbo i Serra <eballetbo@gmail.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
arch/arm/boot/dts/omap3-igep0020.dts | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
index e2b9849..45ffe21 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -15,6 +15,10 @@
model = "IGEPv2";
compatible = "isee,omap3-igep0020", "ti,omap3";
+ chosen {
+ bootargs = "console=ttyO2,115200n8 earlyprintk";
+ };
+
leds {
compatible = "gpio-leds";
boot {
--
1.7.8.6
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm: omap3: igep0020: Add console default kernel arguments
2012-12-20 15:41 [PATCH] arm: omap3: igep0020: Add console default kernel arguments Ezequiel Garcia
@ 2012-12-21 16:02 ` Enric Balletbo Serra
2012-12-21 18:10 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Enric Balletbo Serra @ 2012-12-21 16:02 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ezequiel,
Thanks for the patch.
2012/12/20 Ezequiel Garcia <ezequiel.garcia@free-electrons.com>:
> IGEP v2 boards has console as ttyO2,115200n8.
> It's better so simply set this as the default kernel argument
> directly in the device tree board file.
>
> Cc: Enric Balletbo i Serra <eballetbo@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> arch/arm/boot/dts/omap3-igep0020.dts | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
> index e2b9849..45ffe21 100644
> --- a/arch/arm/boot/dts/omap3-igep0020.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020.dts
> @@ -15,6 +15,10 @@
> model = "IGEPv2";
> compatible = "isee,omap3-igep0020", "ti,omap3";
>
> + chosen {
> + bootargs = "console=ttyO2,115200n8 earlyprintk";
> + };
> +
The u-boot 'bootargs' env overwrites the one from chosen ?
> leds {
> compatible = "gpio-leds";
> boot {
> --
> 1.7.8.6
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm: omap3: igep0020: Add console default kernel arguments
2012-12-21 16:02 ` Enric Balletbo Serra
@ 2012-12-21 18:10 ` Javier Martinez Canillas
2012-12-22 14:17 ` Ezequiel Garcia
0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2012-12-21 18:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ezequiel,
Thanks for the patch
On Fri, Dec 21, 2012 at 5:02 PM, Enric Balletbo Serra
<eballetbo@gmail.com> wrote:
> Hi Ezequiel,
>
> Thanks for the patch.
>
> 2012/12/20 Ezequiel Garcia <ezequiel.garcia@free-electrons.com>:
>> IGEP v2 boards has console as ttyO2,115200n8.
>> It's better so simply set this as the default kernel argument
>> directly in the device tree board file.
>>
>> Cc: Enric Balletbo i Serra <eballetbo@gmail.com>
>> Cc: Javier Martinez Canillas <javier@dowhile0.org>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>> ---
>> arch/arm/boot/dts/omap3-igep0020.dts | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
>> index e2b9849..45ffe21 100644
>> --- a/arch/arm/boot/dts/omap3-igep0020.dts
>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts
>> @@ -15,6 +15,10 @@
>> model = "IGEPv2";
>> compatible = "isee,omap3-igep0020", "ti,omap3";
>>
>> + chosen {
>> + bootargs = "console=ttyO2,115200n8 earlyprintk";
>> + };
>> +
>
> The u-boot 'bootargs' env overwrites the one from chosen ?
>
I just tested and U-Boot 'bootargs' has precedence over DT bootargs
but I didn't find a way to append boot parameters from U-Boot. You can
either overwrite it completely or not.
That been said I think that is a good idea to have some default
bootargs on the DT but since you can't append any boot option from
U-Boot I would also add root=/dev/mmcblk0p2 rw rootwait so at least it
will be able to mount the rootfs from the uSD/MMC.
Also, many IGEP COM Module base boards also have serial consoles that
are connected to the OMAP3 UART3 (ttyO2), so maybe is better to add
this to omap3-igep.dtsi instead of omap3-igep0020.dts to avoid future
duplication.
Best regards,
Javier
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm: omap3: igep0020: Add console default kernel arguments
2012-12-21 18:10 ` Javier Martinez Canillas
@ 2012-12-22 14:17 ` Ezequiel Garcia
2012-12-23 18:22 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Ezequiel Garcia @ 2012-12-22 14:17 UTC (permalink / raw)
To: linux-arm-kernel
Hi Enric and Javier,
>> The u-boot 'bootargs' env overwrites the one from chosen ?
>>
>
> I just tested and U-Boot 'bootargs' has precedence over DT bootargs
> but I didn't find a way to append boot parameters from U-Boot. You can
> either overwrite it completely or not.
>
Yes. That seems to be the current case.
Perhaps we can merge
ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER
and CMDLINE_EXTEND in one generic config stating
the desired bootargs behavior.
Does this sound sane?
> That been said I think that is a good idea to have some default
> bootargs on the DT but since you can't append any boot option from
> U-Boot I would also add root=/dev/mmcblk0p2 rw rootwait so at least it
> will be able to mount the rootfs from the uSD/MMC.
>
True. Will re-send with those.
> Also, many IGEP COM Module base boards also have serial consoles that
> are connected to the OMAP3 UART3 (ttyO2), so maybe is better to add
> this to omap3-igep.dtsi instead of omap3-igep0020.dts to avoid future
> duplication.
>
Ok.
Thanks and merry xmas,
Ezequiel
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm: omap3: igep0020: Add console default kernel arguments
2012-12-22 14:17 ` Ezequiel Garcia
@ 2012-12-23 18:22 ` Javier Martinez Canillas
2012-12-23 21:27 ` Ezequiel Garcia
0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2012-12-23 18:22 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Dec 22, 2012 at 3:17 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> Hi Enric and Javier,
>
>>> The u-boot 'bootargs' env overwrites the one from chosen ?
>>>
>>
>> I just tested and U-Boot 'bootargs' has precedence over DT bootargs
>> but I didn't find a way to append boot parameters from U-Boot. You can
>> either overwrite it completely or not.
>>
>
> Yes. That seems to be the current case.
> Perhaps we can merge
> ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER
> and CMDLINE_EXTEND in one generic config stating
> the desired bootargs behavior.
>
> Does this sound sane?
>
Hi Ezequiel,
You could enable ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER on
omap2plus_defconfig but just having a sane DTB bootargs default value
is better IMHO.
Best regards,
Javier
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: omap3: igep0020: Add console default kernel arguments
2012-12-23 18:22 ` Javier Martinez Canillas
@ 2012-12-23 21:27 ` Ezequiel Garcia
0 siblings, 0 replies; 6+ messages in thread
From: Ezequiel Garcia @ 2012-12-23 21:27 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Dec 23, 2012 at 3:22 PM, Javier Martinez Canillas
<martinez.javier@gmail.com> wrote:
> On Sat, Dec 22, 2012 at 3:17 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> Hi Enric and Javier,
>>
>>>> The u-boot 'bootargs' env overwrites the one from chosen ?
>>>>
>>>
>>> I just tested and U-Boot 'bootargs' has precedence over DT bootargs
>>> but I didn't find a way to append boot parameters from U-Boot. You can
>>> either overwrite it completely or not.
>>>
>>
>> Yes. That seems to be the current case.
>> Perhaps we can merge
>> ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER
>> and CMDLINE_EXTEND in one generic config stating
>> the desired bootargs behavior.
>>
>> Does this sound sane?
>>
>
> Hi Ezequiel,
>
> You could enable ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER on
> omap2plus_defconfig
Actually, ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER depends
on ARM_ATAG_DTB_COMPAT being selected and it's only compatibility
stuff for bootloaders non DTB capable.
I don't think we should add that to omap2plus_defconfig.
> but just having a sane DTB bootargs default value
> is better IMHO.
>
Agreed. I'll send a v2 with your proposed default command line.
--
Ezequiel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-23 21:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-20 15:41 [PATCH] arm: omap3: igep0020: Add console default kernel arguments Ezequiel Garcia
2012-12-21 16:02 ` Enric Balletbo Serra
2012-12-21 18:10 ` Javier Martinez Canillas
2012-12-22 14:17 ` Ezequiel Garcia
2012-12-23 18:22 ` Javier Martinez Canillas
2012-12-23 21:27 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).