From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39F9C4741F for ; Thu, 5 Nov 2020 15:39:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 074B420782 for ; Thu, 5 Nov 2020 15:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a/RY6TtP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b="ibKi6Xco" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 074B420782 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oKBDaiCoq99xEEFVibzDc8PU3yCzyFAxx+X/TFM+A+8=; b=a/RY6TtPkXPbfIIBL1nm9vmFx jrrOO3CZ2S6eqzaW4Ht+vx9MRMncaNICIKiXTxW7hmHElCkFGv9McBYGasJtSFpnAz6d1TCuDJ41t SsBl0P4Lu/6wOIJq4hppUbJd3HXZDdGpUqnpvWu5qDYlSKhXMbckOuLKzL8U5AvkpciCElkDPbgUI ByBag58RR3gzMwKbbObsh/xlWi4Gsh0aU3xUDJAtIIEmz1mXC45DkN6noe6Ux68l9WtH7kEn1UXgr yqxc5RtthdyrpcJrOF+BaYIppklxkI1OHs2ZkCFf0LwDKQi7xwcEPy9C+0obraTnU7rCHpKi34gkv TaiAluMXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kahLL-00078x-UM; Thu, 05 Nov 2020 15:38:31 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kahLJ-00078G-4X for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 15:38:30 +0000 Received: by mail-qk1-x744.google.com with SMTP id l2so1546019qkf.0 for ; Thu, 05 Nov 2020 07:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oe4W/9IIStX5PS7df8SEBHKooPDTXbwCBDTfcyxclaE=; b=ibKi6Xco8MbXn0RJgBL8wrtu+4b1FSUNJKWqyMWfWNim4CmEOYuxl+56dpkCSXEp1F EKWCuq3aDu78RxAcJc5idAsuNU14Dpg2ZljVY1dm4WShBh7QxwRZAF9efcnsuNUTJlqm IbJOUdV5Td1YLwBQcBjIMGxJxu4n9gwVJgVYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oe4W/9IIStX5PS7df8SEBHKooPDTXbwCBDTfcyxclaE=; b=MYy7zMvBIJChQ/HDJVWr0QNxyjU1NRA0tCbddPtiTUi7Eu7ed21YHDZHAyuD75L2n9 4vQ1nFEjWbB/npnDBXHPxvSyN9cO5EbEL1epavlZNANfQ19FqVI3TijeTAyvaEckp/LF Lqeydn7Q6UdWR3hfy27qd1liOS3stU366J6m0X9zhwB2JlGQZAbmRbjBFgL9QH403UlQ 3vw63B/3YD0tIC62u6IL/Ny84iuem4SdDdphzr5tX14FE+2PUkpQhN/vA+86A6dSrh0q e/3ll2HsAnADzI12PSNGFBB6suowpf+bu/405zjjur8gXRdn658f1y/CFX5S/HbT7TD7 Et1Q== X-Gm-Message-State: AOAM533utG39PeFwKN7nSUbD0rOyCBTpPOAcwFE2lrDSVImZ5jqf54Gt 9INOZfTlitkCCO6kS9J6wzr/EpE8T3mTeyRIGiqylA== X-Google-Smtp-Source: ABdhPJxqzr8GwXgp1slRIIYdEd3E4yBt6kDC1cbU1KcQVJm5YduAh2GloUcUEP6vdSccYfzmfa2M85AqTpiEECH58R8= X-Received: by 2002:a05:620a:1024:: with SMTP id a4mr2677116qkk.390.1604590706076; Thu, 05 Nov 2020 07:38:26 -0800 (PST) MIME-Version: 1.0 References: <20201011024831.3868571-1-daniel@0x0f.com> <20201011024831.3868571-4-daniel@0x0f.com> <20201105093107.GB21245@1wt.eu> In-Reply-To: From: Daniel Palmer Date: Fri, 6 Nov 2020 00:39:13 +0900 Message-ID: Subject: Re: [PATCH 3/5] gpio: msc313: MStar MSC313 GPIO driver To: Linus Walleij X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_103829_191583_76C7C3F9 X-CRM114-Status: GOOD ( 20.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Willy Tarreau , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, Thanks for all of the comments. On Thu, 5 Nov 2020 at 18:42, Linus Walleij wrote: > > On Thu, Nov 5, 2020 at 10:31 AM Willy Tarreau wrote: > > On Thu, Nov 05, 2020 at 10:21:27AM +0100, Linus Walleij wrote: > > > > If your SoC is only used by OpenWrt (like ixp4xx) then it is fine > > > to just use bool because that distribution is always built with an > > > image for a specific hardware, whereas distributions are generic. > > .. snip .. >> It's unlikely that we'll see very > > generic distros there given the limited storage you'd typically have > > in an SPI NOR (16-32 MB) and the small RAM (64MB) which tends to > > discourage anyone from booting a regular distro over other storage > > anyway. > > > > Thus my guess is that most users will keep building their own kernels. > > > > But this just emphasizes your points :-) > > I think that is a good argument to keep this as bool. Thanks. I did change it to a tristate for v3 but I'll change it back. Just a heads up: There is another GPIO driver for this chip (same functionality, totally different register layout for no reason) that'll look pretty similar to this that'll follow soon. It might be similar enough that people confuse the two series as the same thing. Thanks, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel