From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8318CC2BA1A for ; Fri, 21 Jun 2024 12:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; b=390pZ1XKaZeGp4vCF+/SjWhIlP 8iF/tLFqGutvWeetVQ4LItVxC9CfVdDGU/YHnC+iBV2RSAo5gqj+eSPhHZs/dZvSVJL0IyZk7pTLG MaSPtyovnoaz6ECAaAbN7WzzSfV+9Mz6BvROgXVWDRX7dJd/RFm6aTAiY1sQLWOw99ef39wAfZdds cOrMWYRXZtFoNd/r0aRef+XJwXelT427OGUW260TwxOExED4RLwkmryztuexI5xYDhegTekzEJb0h 6Mv/ouvF6aQdbcy2+jIEvPqaIHN7zzpFxtcw82+mztq6N1wgrPrUuF/VZJdFLa0eJgiND4XhfKrxx YyYdG/+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKd40-000000093iJ-2Hl2; Fri, 21 Jun 2024 12:08:20 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKd3v-000000093fK-2Z3p for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 12:08:17 +0000 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-795502843ccso104041885a.1 for ; Fri, 21 Jun 2024 05:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timesys-com.20230601.gappssmtp.com; s=20230601; t=1718971694; x=1719576494; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; b=fa84H4Cb9gr2eIWZrFUywlKHBQdbiy84oPUDccZ5yC5V9NoMBd2bwl77XpRbKnPysc ci8KZPtjS+W8obGWMF9L/ecuYUKQUU76QILHO4JvGyod76wD/MJjsrhNORPbBBsn456R hU9MVWLLYK9F90d1C9BBEDO4xnjnJGmHP+PXvTmtB63pf5kC1PtwkVThjKqoF5ZVpAtf DaKPPVzaX0AQqi0wXTDly4bpc3TGoJJ5A15dysyeijqmelmmG0XNCoKwYtV1Ll8jG/6M +z16zsx9gvzug4RxAHe9s2T7uPi+w/+uwmRmleqoMAxyG7lnvfX8UWPiO4DWrYWR9WEt /6XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718971694; x=1719576494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; b=nosNTUQ3xoGMH9ImIISzUS2RHzH/tbuJCycFjmQRhvJLMvS6g9nrLZ2drF4a4pPQZU RFOFuvTh8zwioGq0gmwAVC0zlkNW+41CPFZH3ABqH9zV5xV24mOVl6N3yQREYIJsXZoy bDkmlYxoyXhhNcLZq3XN6HqWKwpc5ETzcGGSunoaTKVsmv0V46Hzi+bJZbDcXHrmhlSR 4fFhJodAHmdSPNjJgq/iIC2WptaM6h7+1lkrerPLqjNFzMoUvHv++AXN4Fix03gaTfBk kqv3Nfvd+iUWNKDxC+lDPANXvgMXhEqz7Y4gzL/UiaSk4Mym3aqiCgO/7wWs/YkR1dic wo6A== X-Forwarded-Encrypted: i=1; AJvYcCVJCDnJWEe8LPea/tKcZGh/6GuameVg/pzHSnEfMly5qPk3X2eRjjbN7alprXISNV000TMIeuWVtSE2AzYV2PpOmGwPXkSQFdwWsb1DnlBAtcvbnug= X-Gm-Message-State: AOJu0Yy0creUSrlvE/G6CMxBn7WzUnaRViiuIv16+3fHKFDIPMPjrGPT aABJOQ1zKF6X9AKDaruQOIQh2eplv4l+47XbZez8ILuY2+4txmKZ2Fy3GL98FRl4ApPK+gO8e07 vnpErWLpj0XZNm1+sOvJQRR95BZgkroxtFP4t+w== X-Google-Smtp-Source: AGHT+IH9SeiO8vfdoOxDABbDkc1VlJaHvluIQfS8YUVwP2eXorBPvqf3BAKJdJfTNAn0CNJ3/z1faNaXrP6fson02ac= X-Received: by 2002:ad4:4245:0:b0:6b0:6629:bdf9 with SMTP id 6a1803df08f44-6b501e2c710mr72849356d6.21.1718971694039; Fri, 21 Jun 2024 05:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20240620175657.358273-1-piotr.wojtaszczyk@timesys.com> <20240620175657.358273-11-piotr.wojtaszczyk@timesys.com> In-Reply-To: From: Piotr Wojtaszczyk Date: Fri, 21 Jun 2024 14:08:03 +0200 Message-ID: Subject: Re: [Patch v4 10/10] i2x: pnx: Use threaded irq to fix warning from del_timer_sync() To: Andi Shyti Cc: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "J.M.B. Downing" , Vladimir Zapolskiy , Liam Girdwood , Mark Brown , Russell King , Michael Turquette , Stephen Boyd , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jaroslav Kysela , Takashi Iwai , Arnd Bergmann , Yangtao Li , Li Zetao , Chancel Liu , Michael Ellerman , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, Markus Elfring Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_050815_797604_E10661FF X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andi, On Fri, Jun 21, 2024 at 12:57=E2=80=AFAM Andi Shyti = wrote: > On Thu, Jun 20, 2024 at 07:56:41PM GMT, Piotr Wojtaszczyk wrote: > > When del_timer_sync() is called in an interrupt context it throws a war= ning > > because of potential deadlock. Threaded irq handler fixes the potential > > problem. > > > > Signed-off-by: Piotr Wojtaszczyk > > did you run into a lockdep splat? > > Anything against using del_timer(), instead? Have you tried? I didn't get a lockdep splat but console was flooded with warnings from https://github.com/torvalds/linux/blob/v6.10-rc4/kernel/time/timer.c#L1655 In the linux kernel v5.15 I didn't see these warnings. I'm not a maintainer of the driver and I didn't do any research on what kind of impact would have using del_timer() instad. Maybe Vladimir Zapolskiy will know tha= t. --=20 Piotr Wojtaszczyk Timesys