From: jp.francois@cynove.com (jean-philippe francois)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/1] ARM: omap3: Fix regression in dpll4 child clock frequency setting.
Date: Thu, 30 May 2013 10:49:51 +0200 [thread overview]
Message-ID: <CAGGh5h3fjXkmsZDvQVGJ6ehdz7SUghhHcBU-rCcRq_7HQSWN6Q@mail.gmail.com> (raw)
Hi,
The following patch fixes a wrong container_of usage for omap3630.
All sub clock of dpll4 that do not use a reset value as divider are
affected.
For instance CAM_MCLK is 216 MHz instead of the asked 172,8 MHz
Any user of this clock is affected. This is the case for instance if
CAM_XCLKA is used to provide clock for an external camera.
Beyond wrong frequency setting, this is also a potential oops waiting
to bite any omap3isp user, since a wrong pointer is dereferenced, and
content of this pointer is used to do __raw_writel / __raw_readl.
v2 :
Follow Mike Turquette's comment and use clock framework instead of
directly accessing register.
Regards,
Jean-Philippe Fran?ois
reply other threads:[~2013-05-30 8:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGGh5h3fjXkmsZDvQVGJ6ehdz7SUghhHcBU-rCcRq_7HQSWN6Q@mail.gmail.com \
--to=jp.francois@cynove.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).