From: mweseloh42@gmail.com (Marcus Weseloh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] spi: dts: sun4i: Add support for hardware-based wait time between words
Date: Mon, 14 Dec 2015 08:31:55 +0100 [thread overview]
Message-ID: <CAGNoLaOckrgv5NP6eTOt8shj5f069DKFrxx+8afydqcAZH5HMw@mail.gmail.com> (raw)
In-Reply-To: <20151214012937.GA12209@rob-hp-laptop>
Hi,
2015-12-14 2:29 GMT+01:00 Rob Herring <robh@kernel.org>:
> On Mon, Dec 14, 2015 at 12:04:11AM +0100, Marcus Weseloh wrote:
>> Adds a new property "spi-word-wait-ns" to the spi-bus binding that allows
[...]
>> diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt
>> index bbaa857..2d6034f 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-bus.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt
>> @@ -61,6 +61,8 @@ contain the following properties.
>> used for MOSI. Defaults to 1 if not present.
>> - spi-rx-bus-width - (optional) The bus width(number of data wires) that
>> used for MISO. Defaults to 1 if not present.
>> +- spi-word-wait-ns - (optional) Hardware based delay between transmission of
>> + words in nanoseconds
>
> Could be a software delay if the h/w doesn't support delays.
Of course, I was still trapped in my sun4i specific thinking. Will
remove the hardware reference.
[...]
>> + /* Setup wait time between words */
>> + of_property_read_u32(spi->dev.of_node, "spi-word-wait-ns",
>> + &wait_ns);
>
> Read this in probe and save the value rather than fetching every
> transfer.
But this is a slave property I'm using here. If I read and store it in
probe in the spi-sun4i driver, I won't have access to the slave node
property, will I?
Cheers,
Marcus
next prev parent reply other threads:[~2015-12-14 7:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 22:45 [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register Marcus Weseloh
2015-12-12 9:19 ` [linux-sunxi] " Priit Laes
2015-12-12 10:44 ` Marcus Weseloh
2015-12-13 21:07 ` Maxime Ripard
2015-12-13 21:52 ` Marcus Weseloh
2015-12-13 23:04 ` [PATCH v3] spi: dts: sun4i: Add support for hardware-based wait time between words Marcus Weseloh
2015-12-13 23:08 ` Mark Brown
2015-12-13 23:23 ` Marcus Weseloh
2015-12-14 10:57 ` Mark Brown
2015-12-14 1:29 ` Rob Herring
2015-12-14 7:31 ` Marcus Weseloh [this message]
2015-12-14 8:08 ` Marcus Weseloh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGNoLaOckrgv5NP6eTOt8shj5f069DKFrxx+8afydqcAZH5HMw@mail.gmail.com \
--to=mweseloh42@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).