From: Alim Akhtar <alim.akhtar@gmail.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: "Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"David Virag" <virag.david003@gmail.com>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org,
"open list" <linux-kernel@vger.kernel.org>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks
Date: Sun, 19 Dec 2021 16:47:47 +0530 [thread overview]
Message-ID: <CAGOxZ51nmoiiWdr3FYLBpg+WSyfnK3wsK+aDi_Q7NAxVVBQWHQ@mail.gmail.com> (raw)
In-Reply-To: <20211126203641.24005-1-semen.protsenko@linaro.org>
On Mon, Nov 29, 2021 at 7:08 PM Sam Protsenko
<semen.protsenko@linaro.org> wrote:
>
> System Register is used to configure system behavior, like USI protocol,
> etc. SYSREG clocks should be provided to corresponding syscon nodes, to
> make it possible to modify SYSREG registers.
>
> While at it, add also missing PMU and GPIO clocks, which looks necessary
> and might be needed for corresponding Exynos850 features soon.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> include/dt-bindings/clock/exynos850.h | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
Looks good, feel free to add
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> diff --git a/include/dt-bindings/clock/exynos850.h b/include/dt-bindings/clock/exynos850.h
> index 8aa5e82af0d3..0b6a3c6a7c90 100644
> --- a/include/dt-bindings/clock/exynos850.h
> +++ b/include/dt-bindings/clock/exynos850.h
> @@ -82,7 +82,10 @@
> #define CLK_GOUT_I3C_PCLK 19
> #define CLK_GOUT_I3C_SCLK 20
> #define CLK_GOUT_SPEEDY_PCLK 21
> -#define APM_NR_CLK 22
> +#define CLK_GOUT_GPIO_ALIVE_PCLK 22
> +#define CLK_GOUT_PMU_ALIVE_PCLK 23
> +#define CLK_GOUT_SYSREG_APM_PCLK 24
> +#define APM_NR_CLK 25
>
> /* CMU_CMGP */
> #define CLK_RCO_CMGP 1
> @@ -99,7 +102,8 @@
> #define CLK_GOUT_CMGP_USI0_PCLK 12
> #define CLK_GOUT_CMGP_USI1_IPCLK 13
> #define CLK_GOUT_CMGP_USI1_PCLK 14
> -#define CMGP_NR_CLK 15
> +#define CLK_GOUT_SYSREG_CMGP_PCLK 15
> +#define CMGP_NR_CLK 16
>
> /* CMU_HSI */
> #define CLK_MOUT_HSI_BUS_USER 1
> @@ -167,7 +171,9 @@
> #define CLK_GOUT_MMC_EMBD_SDCLKIN 10
> #define CLK_GOUT_SSS_ACLK 11
> #define CLK_GOUT_SSS_PCLK 12
> -#define CORE_NR_CLK 13
> +#define CLK_GOUT_GPIO_CORE_PCLK 13
> +#define CLK_GOUT_SYSREG_CORE_PCLK 14
> +#define CORE_NR_CLK 15
>
> /* CMU_DPU */
> #define CLK_MOUT_DPU_USER 1
> --
> 2.30.2
>
--
Regards,
Alim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-12-19 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 20:36 [PATCH 1/2] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks Sam Protsenko
2021-11-26 20:36 ` [PATCH 2/2] clk: samsung: exynos850: Add missing " Sam Protsenko
2021-11-27 13:18 ` Krzysztof Kozlowski
2021-11-27 13:18 ` [PATCH 1/2] dt-bindings: clock: exynos850: Add bindings for Exynos850 " Krzysztof Kozlowski
2021-12-02 0:12 ` Rob Herring
2021-12-07 20:54 ` Sam Protsenko
2021-12-14 16:15 ` Sam Protsenko
2021-12-14 16:20 ` Krzysztof Kozlowski
2021-12-18 10:50 ` Krzysztof Kozlowski
2021-12-19 11:17 ` Alim Akhtar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGOxZ51nmoiiWdr3FYLBpg+WSyfnK3wsK+aDi_Q7NAxVVBQWHQ@mail.gmail.com \
--to=alim.akhtar@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=virag.david003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).