linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: at91/dt: describe rgmii ethernet phy connected to sama5d3xek boards
Date: Thu, 26 Jun 2014 11:15:13 -0700	[thread overview]
Message-ID: <CAGVrzcbYAEMsU1SFSH761H0isQ4z1M++KK_GLf0OAbGS48YUmw@mail.gmail.com> (raw)
In-Reply-To: <1403777615-25685-2-git-send-email-boris.brezillon@free-electrons.com>

Hi Boris,

2014-06-26 3:13 GMT-07:00 Boris BREZILLON <boris.brezillon@free-electrons.com>:
> Add ethernet-phy node and specify phy interrupt (connected to pin PB25).
>
> The PHY address is not specified here because atmel have 2 different
> designs
> for its CPU modules: one is connecting PHYAD[0-2] pins to pull up resistors
> (Embest design) and the other one is connection PHYAD0 to a pull up
> resistor and PHYAD[1-2] to pull down resistors (Ronetix design).
> As a result, Ronetix design will have its PHY available at address 0x1 and
> Embest design at 0x7.
> Let the net PHY core automatically detect the PHY address by scanning the
> MDIO bus.

I though the compatible string was listed as a required property, but
it is not. The 'reg' property however is listed as required, although
the of_miodbus_register() works just fine without it, although that is
a Linux-specific implementation detail.

>
> Define board specific delays to apply to RGMII signals.
>
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> ---
>  arch/arm/boot/dts/sama5d3xcm.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi b/arch/arm/boot/dts/sama5d3xcm.dtsi
> index b0b1331..fc68bae 100644
> --- a/arch/arm/boot/dts/sama5d3xcm.dtsi
> +++ b/arch/arm/boot/dts/sama5d3xcm.dtsi
> @@ -34,6 +34,21 @@
>
>                         macb0: ethernet at f0028000 {
>                                 phy-mode = "rgmii";
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +
> +                               ethernet-phy {
> +                                       interrupt-parent = <&pioB>;
> +                                       interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> +                                       txen-skew-ps = <800>;
> +                                       txc-skew-ps = <3000>;
> +                                       rxdv-skew-ps = <400>;
> +                                       rxc-skew-ps = <3000>;
> +                                       rxd0-skew-ps = <400>;
> +                                       rxd1-skew-ps = <400>;
> +                                       rxd2-skew-ps = <400>;
> +                                       rxd3-skew-ps = <400>;
> +                               };
>                         };
>
>                         pmc: pmc at fffffc00 {
> --
> 1.8.3.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Florian

  reply	other threads:[~2014-06-26 18:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 10:13 [PATCH v2 0/2] ARM: at91: remove phy fixup for sama5d3xek boards Boris BREZILLON
2014-06-26 10:13 ` [PATCH v2 1/2] ARM: at91/dt: describe rgmii ethernet phy connected to " Boris BREZILLON
2014-06-26 18:15   ` Florian Fainelli [this message]
2014-06-26 20:01     ` Boris BREZILLON
2014-06-27  7:52       ` Nicolas Ferre
     [not found]         ` <20140710110720.03f437eb@bbrezillon>
2014-07-10 15:35           ` Florian Fainelli
2014-07-10 17:19             ` Boris BREZILLON
2014-07-10 17:46               ` Florian Fainelli
2014-07-10 19:32                 ` Boris BREZILLON
2014-06-26 10:13 ` [PATCH v2 2/2] ARM: at91: remove phy fixup for " Boris BREZILLON
2014-07-01 22:38 ` [PATCH v2 0/2] " David Miller
2014-07-02 11:48   ` Boris BREZILLON
2014-07-09 16:34 ` Boris BREZILLON
2014-07-10  2:24   ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGVrzcbYAEMsU1SFSH761H0isQ4z1M++KK_GLf0OAbGS48YUmw@mail.gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).