From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89FF8C61DA4 for ; Thu, 9 Feb 2023 09:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ybQsCwe7lqrfkqs7sPIMrUP8zShXiViu9J3FtkWnPA=; b=yhBkb4R6UXh/aK Ihpy4kbxfd0eIq+KsmeIi1nPjQZpLjDd89mi15ZsfhZTNnclPz2kd3rGYApsafJhEHv8VZy/7+dX0 YErF5rpXwgWKo9/CQHl+fbysZOKPGPb3nxlpMvz6V3JFvtCUpLlU/qTZQUC5UCkiO211EfpFPAg1k yvQM5qcH3dFt534xH6eLd6d7sVQSJZJdymtjr6QaoanYUJ2KcMqwAg494XJaAO/2CcmwsYdo1NI1V PWyZEdRPbCMXYIVJhXwBM1NwGY5BxJBcfsAaViW19m3SrxrXe2d+uKn3MuQQbYN4ktfxrI2kc9eyj skeV9gKVrfEa86zPb5qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ3Uq-000tvs-AF; Thu, 09 Feb 2023 09:45:40 +0000 Received: from mail-vs1-xe33.google.com ([2607:f8b0:4864:20::e33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ3Ul-000tsV-Nr for linux-arm-kernel@lists.infradead.org; Thu, 09 Feb 2023 09:45:37 +0000 Received: by mail-vs1-xe33.google.com with SMTP id g8so1517193vso.3 for ; Thu, 09 Feb 2023 01:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kXhHlY1h7nocfeF1bOOwlqa9GLmp058pSwMc5Nw8eCs=; b=AVQtBu6a+GAA0YuBWAkZuoZ1RiMhYbu91H+uxx6jbo4OyTg1oInL7ybjONKCA9fYgV tXH2621Wu1HMYvV00UxmOK9/0ti5yO/2O700FMrMeyTsHiUghbsmknayRo6UceHPmf2F MS4KjYawZ5imA3BDzv/iFFibjSN2z+XaxLaXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kXhHlY1h7nocfeF1bOOwlqa9GLmp058pSwMc5Nw8eCs=; b=DW7IjvuYcigjE+3u/D4koJTFtrGGSIexmjNogvT/5Oym1r6oA5FC7mRi9M8RwUqoCn E+0qNQen9+JsaVzphWOP0bGDJjeFnmsgaNl59PknET4ctKGzDXT9UmvxZiEiuN0g6JST 5qxbWr+Cse+k50OCSBzWeRFWFOhZIvPFyhB6py0IW7A20Jz6ZzYSHXbFmn2xMUiS4kTE cT4va+kzErCAJikEAZGWa7IdAXEP6mlCKT11K1M3yLJpfmWfHLpufHpEyq7yvLB8jlk8 oJoG//9CUigMUB57W9SbOZfW8XAtpcMKJtLKdfC4gFluWwsSExLNW5Fplbf5lKHMa08q ccQA== X-Gm-Message-State: AO0yUKWA0iYStClSslNm7APsKHTjTiCNzFigYdB7P286m9Z+mYBmAXmI 3snhU4NgRs6EIicpl2eWDJoPWW6Bl+yDKo+FRZXYJQ== X-Google-Smtp-Source: AK7set9hqvzMQiDk15uKKV/k2E6K/8sc6RF0LbaAJ63u86p8XV6MRsIUixqUkVvQiR03JwtLvsvHt9Z3UruyeBFDCFU= X-Received: by 2002:a67:1904:0:b0:3e8:d5a8:3fbe with SMTP id 4-20020a671904000000b003e8d5a83fbemr2433227vsz.9.1675935933578; Thu, 09 Feb 2023 01:45:33 -0800 (PST) MIME-Version: 1.0 References: <20230208103709.116896-1-angelogioacchino.delregno@collabora.com> <20230208103709.116896-6-angelogioacchino.delregno@collabora.com> <7784f5a2-3cfc-9999-0ad6-cb9cfc1f2822@collabora.com> In-Reply-To: <7784f5a2-3cfc-9999-0ad6-cb9cfc1f2822@collabora.com> From: Chen-Yu Tsai Date: Thu, 9 Feb 2023 17:45:22 +0800 Message-ID: Subject: Re: [PATCH 5/9] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186 To: AngeloGioacchino Del Regno Cc: airlied@gmail.com, tomeu.vizoso@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, steven.price@arm.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, alyssa.rosenzweig@collabora.com, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, Fei Shao , Nick Fan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_014535_784667_8C883BA4 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 9, 2023 at 5:20 PM AngeloGioacchino Del Regno wrote: > > Il 09/02/23 09:49, Chen-Yu Tsai ha scritto: > > On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno > > wrote: > >> > >> Get GPU support on MT8186 by adding its compatible. > > > > I'd skip MT8186 for now. We have to work out some binning details for the > > OPP, in particular how to deal with both Panfrost (or Mali) and SVS adding > > the OPP table. We were just looking at the Mali driver today. > > > > Dealing with binning is fairly easy... I have something already done for > that one, but I'm not sure that it would be the best option. > My solution makes use of opp-supported-hw by "standard means", but perhaps > let's have a separated conversation about it? > > I don't think that skipping this would give any benefit though, because > that is only adding a compatible and whatever binning support would have > to be generic and 99% not bound to any mediatek specific compatible. The binning is related to voltage range, not maximum OPP. So it's more like fast/slow example in Documentation/devicetree/bindings/opp/opp-v2.yaml or the opp/allwinner,sun50i-h6-operating-points.yaml, minus the efuse node. The downstream DT currently looks like this: opp-950000000 { opp-hz = /bits/ 64 <950000000>; /* This is Mali specific; ignore opp-hz-real = /bits/ 64 <950000000>, /bits/ 64 <950000000>; */ opp-microvolt = <900000>, <1000000>; opp-microvolt-bin4 = <875000>, <975000>; opp-microvolt-bin5 = <850000>, <950000>; }; ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel