From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA82BC07E99 for ; Mon, 5 Jul 2021 09:56:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95888613C1 for ; Mon, 5 Jul 2021 09:56:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95888613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bqEAtPGwlNMLAVxhQB3vaHJmIpBhhVCUri8qUp6qysU=; b=r9ps8i2BUVknhN b4EVuQVAMfHOCll9Sl+j+6cuXlf41kmgPL1kdAiykXAsmnr0WZFE0fYsYkmhvBuo+cXkfOw09IPRe kw1wq8lIqh/ULjPWN6Iy35UPIfZZru5MKHFaQy9fL8TUZhHjSv5b2sgMuMOxii83LLegmf/A64oMo QYUIRej8fmrcH68aH5Rk4xAN+TRdaA9tLoVZwSmvc67rlTh9PMfbvhxu21Ag/MHZeqsOEC4YODIps PqvO+LKVsh0DCmCd5n5MPFME3WF7CIFMClv3m6Y1bEa2JVj4IX6dddsQqJJSnrpEvJR+G8pMgBFXk pMnQTBoEv8iB+YVhs57w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0LJu-008VBU-84; Mon, 05 Jul 2021 09:55:18 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0LJp-008VAX-H0 for linux-arm-kernel@lists.infradead.org; Mon, 05 Jul 2021 09:55:15 +0000 Received: by mail-lj1-x22a.google.com with SMTP id b40so4138311ljf.12 for ; Mon, 05 Jul 2021 02:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=76UHh0xd3/47lriNsZ56K8AIpOU4AXIgwxQmOqZVOu4=; b=Gur909yNfRrbSLYCj5TF7f3/2EDRhQ6gnhZdbubcP/OR83toGfoysivDTuXmGBIbJd WtGAWjpTPrkhBF0+pFEMzzlzEZzXfQlZRS3H+4s2aQwvo8AfoFG6jF6xPKR6PP+fsjnH aKwgpjD/6Jww1bAokjcLrlvJ1mg2HbSAec8do= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=76UHh0xd3/47lriNsZ56K8AIpOU4AXIgwxQmOqZVOu4=; b=eRHStJWY14H7ZEfLEcWXgC/YS1N75k0JqvLIBUcD+KgJW4FELjaNbUC/Xzz8iJkKL5 cgTb/VFPEzeT8zh+fnLwp43hljXUTWCSJ2SWeMpevIrpYTvTxLUKEKoYb90h1K1Jbfe4 o6ZegSV39KKShhhjgJ+9AQxgrffOu8+veCsXNW01uODn27Tti8ZVQYFVKv2xVYSDYnIo SP0LsNZdA5MPlwcm08jrEqYBskE1Q8nKClKpYeTAEF4+LkEmidenXEBlFuIFCFZ3nJjT edn8x8NH7wPhP3c8Ic8vtdclG1vreBi1GmOYu2971ropC7z6QL2zhW1cn2YlXf0tCMI4 q5zg== X-Gm-Message-State: AOAM530WFrVtmzIC7AFkCkYSMvQ+5BEDjix7n7jj8O9BTVFm4ebr7zeg ug59UNoTVDh02ivYh+yYAxEOEG8YrlTudAOIu3OTJQ== X-Google-Smtp-Source: ABdhPJyd+J7AADwR6pbVkPJj0QpvAzTSciPcJRxaXQx7VKleQjJCQk7Qi8C/Mv/1z/QFK8vAe5+pv0fE9PDIbsI+P4s= X-Received: by 2002:a2e:5c42:: with SMTP id q63mr10340582ljb.23.1625478911337; Mon, 05 Jul 2021 02:55:11 -0700 (PDT) MIME-Version: 1.0 References: <20210630090710.1873559-1-kansho@chromium.org> <20210630180652.1.I88a52644e47e88b15f5db9841cb084dc53c5875c@changeid> <716ab7a7-937d-df88-8d3c-8d35df473b4e@gmail.com> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 5 Jul 2021 17:55:00 +0800 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: mt8183: add audio node To: Kansho Nishida Cc: Matthias Brugger , linux-mediatek@lists.infradead.org, LKML , Jiaxin Yu , devicetree@vger.kernel.org, Rob Herring , Shunli Wang , linux-arm-kernel@lists.infradead.org, Eddie Huang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210705_025513_659566_B476F2AC X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Jul 5, 2021 at 5:40 PM Kansho Nishida wrote: > > On Fri, Jul 2, 2021 at 3:20 AM Matthias Brugger wrote: > > > > > > > > On 30/06/2021 11:07, Kansho Nishida wrote: > > > Add afe (audio front end) device node to the MT8183 dtsi. > > > > > > Signed-off-by: Kansho Nishida > > > --- > > > > > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 94 +++++++++++++++++++++++- > > > 1 file changed, 93 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > > index f90df6439c08..b06acb8d6527 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > > @@ -1115,10 +1115,102 @@ usb_host: usb@11200000 { > > > }; > > > }; > > > > > > - audiosys: syscon@11220000 { > > > + audiosys: clock-controller@11220000 { > > > > Why do you change it from sysecon to clock-controller? > > > > Regards, > > Matthias > > Hi Matthias, > > Thanks for the comments! > This should be "clock-controller" according to the binding description (*1). > Moreover, you suggested doing so even though it's a long time ago (*2). The address space really covers the whole audio subsystem though. The clock controls only span a few registers. In hindsight the clock controls shouldn't have been modelled separately, since they are only used internally within the audio subsystem. See https://lore.kernel.org/linux-mediatek/YOLKxrJin5kkwiIl@google.com/T/#u for issues I raised on the MT8195. Now we are probably not going to be able to fix this for existing bindings, so let's just get the node name right. It should probably be audio-controller or something close instead. Regards ChenYu > *1) https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/mediatek/mediatek%2Caudsys.txt > *2) https://patchwork.kernel.org/project/linux-mediatek/patch/1559360354-22974-1-git-send-email-jiaxin.yu@mediatek.com/ > > Regards, > Kansho > > > > > > compatible = "mediatek,mt8183-audiosys", "syscon"; > > > reg = <0 0x11220000 0 0x1000>; > > > #clock-cells = <1>; > > > + afe: mt8183-afe-pcm { > > > + compatible = "mediatek,mt8183-audio"; > > > + interrupts = ; > > > + resets = <&watchdog MT8183_TOPRGU_AUDIO_SW_RST>; > > > + reset-names = "audiosys"; > > > + power-domains = > > > + <&spm MT8183_POWER_DOMAIN_AUDIO>; > > > + clocks = <&audiosys CLK_AUDIO_AFE>, > > > + <&audiosys CLK_AUDIO_DAC>, > > > + <&audiosys CLK_AUDIO_DAC_PREDIS>, > > > + <&audiosys CLK_AUDIO_ADC>, > > > + <&audiosys CLK_AUDIO_PDN_ADDA6_ADC>, > > > + <&audiosys CLK_AUDIO_22M>, > > > + <&audiosys CLK_AUDIO_24M>, > > > + <&audiosys CLK_AUDIO_APLL_TUNER>, > > > + <&audiosys CLK_AUDIO_APLL2_TUNER>, > > > + <&audiosys CLK_AUDIO_I2S1>, > > > + <&audiosys CLK_AUDIO_I2S2>, > > > + <&audiosys CLK_AUDIO_I2S3>, > > > + <&audiosys CLK_AUDIO_I2S4>, > > > + <&audiosys CLK_AUDIO_TDM>, > > > + <&audiosys CLK_AUDIO_TML>, > > > + <&infracfg CLK_INFRA_AUDIO>, > > > + <&infracfg CLK_INFRA_AUDIO_26M_BCLK>, > > > + <&topckgen CLK_TOP_MUX_AUDIO>, > > > + <&topckgen CLK_TOP_MUX_AUD_INTBUS>, > > > + <&topckgen CLK_TOP_SYSPLL_D2_D4>, > > > + <&topckgen CLK_TOP_MUX_AUD_1>, > > > + <&topckgen CLK_TOP_APLL1_CK>, > > > + <&topckgen CLK_TOP_MUX_AUD_2>, > > > + <&topckgen CLK_TOP_APLL2_CK>, > > > + <&topckgen CLK_TOP_MUX_AUD_ENG1>, > > > + <&topckgen CLK_TOP_APLL1_D8>, > > > + <&topckgen CLK_TOP_MUX_AUD_ENG2>, > > > + <&topckgen CLK_TOP_APLL2_D8>, > > > + <&topckgen CLK_TOP_MUX_APLL_I2S0>, > > > + <&topckgen CLK_TOP_MUX_APLL_I2S1>, > > > + <&topckgen CLK_TOP_MUX_APLL_I2S2>, > > > + <&topckgen CLK_TOP_MUX_APLL_I2S3>, > > > + <&topckgen CLK_TOP_MUX_APLL_I2S4>, > > > + <&topckgen CLK_TOP_MUX_APLL_I2S5>, > > > + <&topckgen CLK_TOP_APLL12_DIV0>, > > > + <&topckgen CLK_TOP_APLL12_DIV1>, > > > + <&topckgen CLK_TOP_APLL12_DIV2>, > > > + <&topckgen CLK_TOP_APLL12_DIV3>, > > > + <&topckgen CLK_TOP_APLL12_DIV4>, > > > + <&topckgen CLK_TOP_APLL12_DIVB>, > > > + /*<&topckgen CLK_TOP_APLL12_DIV5>,*/ > > > + <&clk26m>; > > > + clock-names = "aud_afe_clk", > > > + "aud_dac_clk", > > > + "aud_dac_predis_clk", > > > + "aud_adc_clk", > > > + "aud_adc_adda6_clk", > > > + "aud_apll22m_clk", > > > + "aud_apll24m_clk", > > > + "aud_apll1_tuner_clk", > > > + "aud_apll2_tuner_clk", > > > + "aud_i2s1_bclk_sw", > > > + "aud_i2s2_bclk_sw", > > > + "aud_i2s3_bclk_sw", > > > + "aud_i2s4_bclk_sw", > > > + "aud_tdm_clk", > > > + "aud_tml_clk", > > > + "aud_infra_clk", > > > + "mtkaif_26m_clk", > > > + "top_mux_audio", > > > + "top_mux_aud_intbus", > > > + "top_syspll_d2_d4", > > > + "top_mux_aud_1", > > > + "top_apll1_ck", > > > + "top_mux_aud_2", > > > + "top_apll2_ck", > > > + "top_mux_aud_eng1", > > > + "top_apll1_d8", > > > + "top_mux_aud_eng2", > > > + "top_apll2_d8", > > > + "top_i2s0_m_sel", > > > + "top_i2s1_m_sel", > > > + "top_i2s2_m_sel", > > > + "top_i2s3_m_sel", > > > + "top_i2s4_m_sel", > > > + "top_i2s5_m_sel", > > > + "top_apll12_div0", > > > + "top_apll12_div1", > > > + "top_apll12_div2", > > > + "top_apll12_div3", > > > + "top_apll12_div4", > > > + "top_apll12_divb", > > > + /*"top_apll12_div5",*/ > > > + "top_clk26m_clk"; > > > + }; > > > }; > > > > > > mmc0: mmc@11230000 { > > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel