From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] ARM: gr8: Add missing pwm channel 1 pin
Date: Tue, 25 Oct 2016 12:10:26 +0800 [thread overview]
Message-ID: <CAGb2v64Ai+8sUPyH9aTnKUw1ROmQNxzCEqUXrT4v8Q-nipqR3Q@mail.gmail.com> (raw)
In-Reply-To: <20161020170739.lgt2ywm346vm47zd@lukather>
On Fri, Oct 21, 2016 at 1:07 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Oct 20, 2016 at 10:10:03PM +0800, Chen-Yu Tsai wrote:
>> On Thu, Oct 20, 2016 at 4:12 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > The PWM controller has two different channels, but only the first pin was
>> > exposed in the DTSI. Add the other one.
>> >
>> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>
>> Acked-by: Chen-Yu Tsai <wens@csie.org>
>>
>> > ---
>> > arch/arm/boot/dts/ntc-gr8.dtsi | 7 +++++++
>> > 1 file changed, 7 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/ntc-gr8.dtsi b/arch/arm/boot/dts/ntc-gr8.dtsi
>> > index 74aff795e723..fad7381630f3 100644
>> > --- a/arch/arm/boot/dts/ntc-gr8.dtsi
>> > +++ b/arch/arm/boot/dts/ntc-gr8.dtsi
>> > @@ -854,6 +854,13 @@
>> > allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> > };
>> >
>> > + pwm1_pins_a: pwm1 at 0 {
>>
>> Nit: really don't need "_a" and "@0" here.
>
> Fixed and applied.
Oops, you forgot to fix the label in the chip-pro dts:
DTC arch/arm/boot/dts/ntc-gr8-chip-pro.dtb
ERROR (phandle_references): Reference to non-existent node or label
"pwm1_pins_a"
ERROR: Input tree has errors, aborting (use -f to force output)
scripts/Makefile.lib:313: recipe for target
'arch/arm/boot/dts/ntc-gr8-chip-pro.dtb' failed
ChenYu
next prev parent reply other threads:[~2016-10-25 4:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 8:12 [PATCH 0/8] ARM: gr8: Add support for the CHIP Pro Maxime Ripard
2016-10-20 8:12 ` [PATCH 1/8] mtd: nand: sunxi: fix support for 512bytes ECC chunks Maxime Ripard
2016-10-21 17:55 ` Boris Brezillon
2016-10-20 8:12 ` [PATCH 2/8] mtd: nand: add support for the TC58NVG2S0H chip Maxime Ripard
2016-10-21 17:55 ` Boris Brezillon
2016-10-20 8:12 ` [PATCH 3/8] ARM: gr8: Add the UART3 Maxime Ripard
2016-10-20 14:06 ` Chen-Yu Tsai
2016-10-20 17:06 ` Maxime Ripard
2016-10-20 8:12 ` [PATCH 4/8] ARM: gr8: Fix typo in the i2s mclk pin group Maxime Ripard
2016-10-20 14:07 ` Chen-Yu Tsai
2016-10-20 17:06 ` Maxime Ripard
2016-10-20 8:12 ` [PATCH 5/8] ARM: gr8: Add missing pwm channel 1 pin Maxime Ripard
2016-10-20 14:10 ` Chen-Yu Tsai
2016-10-20 17:07 ` Maxime Ripard
2016-10-25 4:10 ` Chen-Yu Tsai [this message]
2016-10-25 10:42 ` Maxime Ripard
2016-10-20 8:12 ` [PATCH 6/8] ARM: gr8: Add UART2 pins Maxime Ripard
2016-10-20 14:14 ` Chen-Yu Tsai
2016-10-20 17:08 ` Maxime Ripard
2016-10-20 8:12 ` [PATCH 7/8] ARM: gr8: Add UART3 pins Maxime Ripard
2016-10-20 14:16 ` Chen-Yu Tsai
2016-10-20 17:08 ` Maxime Ripard
2016-10-20 8:12 ` [PATCH 8/8] ARM: gr8: Add CHIP Pro support Maxime Ripard
2016-10-20 14:26 ` Chen-Yu Tsai
2016-10-20 17:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v64Ai+8sUPyH9aTnKUw1ROmQNxzCEqUXrT4v8Q-nipqR3Q@mail.gmail.com \
--to=wens@csie.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).