linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Petr Štetiar" <ynezz@true.cz>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
Date: Tue, 31 Mar 2020 09:19:57 +0800	[thread overview]
Message-ID: <CAGb2v66+oT=qfu7oHTs3d_e2hd_8Fc_0ULhHRfMLmrdcfOoe=A@mail.gmail.com> (raw)
In-Reply-To: <20200330175347.r4uam7cybvuxlgog@gilmour.lan>

On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> > to PE17 by default. So lets add this missing bit in the current hardware
> > description.
> >
> > Signed-off-by: Petr Štetiar <ynezz@true.cz>
>
> QUeued for 5.8, thanks!

The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f])
as the child node name. This was recently brought to my attention. Do we
want to follow suit here?

ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-31  1:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 20:59 [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED Petr Štetiar
2020-03-30 17:53 ` Maxime Ripard
2020-03-31  1:19   ` Chen-Yu Tsai [this message]
2020-03-31  8:26     ` Petr Štetiar
2020-03-31  9:00     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGb2v66+oT=qfu7oHTs3d_e2hd_8Fc_0ULhHRfMLmrdcfOoe=A@mail.gmail.com' \
    --to=wens@csie.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=ynezz@true.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).