From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 1/2] mmc: sunxi: fix support for new timings mode only SoCs
Date: Sun, 6 Aug 2017 10:01:39 +0800 [thread overview]
Message-ID: <CAGb2v66j-EFZ6P5uAXwtJB-+tMv0NSa2XS6QMm_B9GrDA3CzJA@mail.gmail.com> (raw)
In-Reply-To: <20170804213555.6024-1-icenowy@aosc.io>
On Sat, Aug 5, 2017 at 5:35 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> The A83T MMC support code introduces the timings mode switch, however
> such a switch doesn't exist on new SoCs with only new timings mode.
>
> Only execute the switch if the SoC really have the timings mode switch,
> to fix the regression shown on new timings mode only SoCs (A64, H5,
> etc).
>
> Fixes: b0600daebf31 ("mmc: sunxi: Support controllers that can use both
> old and new timings")
You could make it easier to read by aligning the wrapped line with
opening parenthesis and double quote.
And you don't need the newline here.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
This must have slipped through when I reworked the mmc quirks.
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
prev parent reply other threads:[~2017-08-06 2:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 21:35 [PATCH 1/2] mmc: sunxi: fix support for new timings mode only SoCs Icenowy Zheng
2017-08-04 21:35 ` [PATCH 2/2] mmc: sunxi: fix new timings mode on A64 EMMC (MMC2) controller Icenowy Zheng
2017-08-06 2:39 ` [linux-sunxi] " Chen-Yu Tsai
2017-08-06 3:20 ` Icenowy Zheng
2017-08-07 6:59 ` icenowy at aosc.io
2017-08-06 2:01 ` Chen-Yu Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v66j-EFZ6P5uAXwtJB-+tMv0NSa2XS6QMm_B9GrDA3CzJA@mail.gmail.com \
--to=wens@csie.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).