From mboxrd@z Thu Jan 1 00:00:00 1970 From: pankaj.dubey@samsung.com (Pankaj Dubey) Date: Wed, 28 Dec 2016 08:43:10 +0530 Subject: [PATCH] PCI: exynos: refactor exynos pcie driver In-Reply-To: <3335251.c58Y1Zf7PB@amdc3058> References: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com> <3335251.c58Y1Zf7PB@amdc3058> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bartlomiej, On 27 December 2016 at 19:05, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Friday, December 23, 2016 04:26:27 PM Pankaj Dubey wrote: >> From: Niyas Ahmed S T >> >> Currently Exynos PCIe driver is only supported for Exynos5440 SoC. >> This patch does refactoring of Exynos PCIe driver to extend support >> for other Exynos SoC. >> >> Following are the main changes done via this patch: >> 1) It adds separate structs for memory, clock resources. >> 2) It add exynos_pcie_ops struct which will allow us to support the >> differences in resources in different Exynos SoC. >> >> No functional change intended. >> >> Signed-off-by: Niyas Ahmed S T >> Signed-off-by: Pankaj Dubey > > I would also like to see the explanation for 1) (as already > requested by Jingoo). Otherwise it all looks fine to me: > > Reviewed-by: Bartlomiej Zolnierkiewicz > Thanks for review and Reviewed-by tag. In other thread as a reply to Jaehoon, I have explained reason behind point no 1, I hope this reason is sufficient to separate these resources from main exynos_pcie structs. Thanks, Pankaj Dubey > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html