From: Barry Song <baohua@kernel.org>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: sboyd@kernel.org, Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: clk-atlas6: fix return value check in atlas6_clk_init()
Date: Wed, 15 Jul 2020 21:23:20 +1200 [thread overview]
Message-ID: <CAGsJ_4z4QfmFxu=+8QgKz4qSSob+2K+EO5hukPjhgPYkvEuJmw@mail.gmail.com> (raw)
In-Reply-To: <20200713032143.21362-1-vulab@iscas.ac.cn>
Xu Wang <vulab@iscas.ac.cn> 于2020年7月13日周一 下午3:27写道：
>
> In case of error, the function clk_register() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Barry Song <baohua@kernel.org>
> ---
> drivers/clk/sirf/clk-atlas6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sirf/clk-atlas6.c b/drivers/clk/sirf/clk-atlas6.c
> index c84d5bab7ac2..b95483bb6a5e 100644
> --- a/drivers/clk/sirf/clk-atlas6.c
> +++ b/drivers/clk/sirf/clk-atlas6.c
> @@ -135,7 +135,7 @@ static void __init atlas6_clk_init(struct device_node *np)
>
> for (i = pll1; i < maxclk; i++) {
> atlas6_clks[i] = clk_register(NULL, atlas6_clk_hw_array[i]);
> - BUG_ON(!atlas6_clks[i]);
> + BUG_ON(IS_ERR(atlas6_clks[i]));
> }
> clk_register_clkdev(atlas6_clks[cpu], NULL, "cpu");
> clk_register_clkdev(atlas6_clks[io], NULL, "io");
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-15 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 3:21 [PATCH] clk: clk-atlas6: fix return value check in atlas6_clk_init() Xu Wang
2020-07-15 9:23 ` Barry Song [this message]
2020-07-28 1:22 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGsJ_4z4QfmFxu=+8QgKz4qSSob+2K+EO5hukPjhgPYkvEuJmw@mail.gmail.com' \
--to=baohua@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).