From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30FA9C61DA4 for ; Mon, 6 Feb 2023 14:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Da14ZgljeBSvJMdKKRYQAdtJlKHMG/W7MbGYHN1mNc=; b=tOm8zD2T3oGm63 QoskX/sfSY2+shOeK69XJlpqwb04ldadTrQKkizyWJ7/KwIVdkKSsbo/8n1FFNFYAxBWvR8nHgtbz 5t3368Q/6M/Co5wvcQCaRFWv8y8YHMMBgJBhjFyIw2nYcODekyVnfiIch8iYVxBLVZMPx8LOw8lPd UVlVN8XX6vIBZ5s08xDx9k2Dqn8TwuArAkDf665Z5uMk87kV/uOe9lOlJMIai9eH1eypZgV8qLdqQ J2oOrPeNrbTmUsjpQOqTT8Tu2TRJX4mF2vNFTI4jK/KXCi3ymQcD3sOHVAQ6fgMv0EOOOUr4luEqu /gfA3QLo5laA//9hba2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP2Ys-008n8U-Gr; Mon, 06 Feb 2023 14:33:38 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP2Yl-008n57-6C for linux-arm-kernel@lists.infradead.org; Mon, 06 Feb 2023 14:33:36 +0000 Received: by mail-ej1-x634.google.com with SMTP id hx15so34648059ejc.11 for ; Mon, 06 Feb 2023 06:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RHaeRZqGHYAtIxM6Dz50lpu040N8lRz141Rm2pL5rVo=; b=jF1s45DfufJwWZ57OB4BhZN/fdCEcCANg5872Lpc2HV2Ir2Mncxbo/xAhZJfUnR3L+ zj/iqQibSO2essYu11V5ZoaCOO1G8tKqVEw+x1gL3ETrubdC6B68mNHS4+lJGYXSzrXu orW5CjFvL/UrHYWJjZ8cV+5pZ+/s8jq4GoMsOmhkPKIWkNXm0D6Gnilexls3a7htxx6D /25skRRaDV+Gz0xrN/fO6uxRvlSPOWnSXL06w/EXUgmzB9QU+iA7gSZAByL4V9Z/WFL3 g4urT34lwmdyWPzF1tFaoARTuuhrRNCW3FK5ZrJQXnjAxjvMTBeUgl7MN1sDOzeoiag9 IQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RHaeRZqGHYAtIxM6Dz50lpu040N8lRz141Rm2pL5rVo=; b=6nSOP5fGLKiKaqtxBMZootk9VBVbmII5Zv4xNKiAwpo/bB7QIo9kJ8YfTQBl/UArU4 V28YKW2BN82RZQagX7YFLPx8oVVkdEvw3AnwIx0bbTBVW+rcB+CKEhBT48SsD3xUivuw RBb61hMCeE6JiR9MrkyQ/bHtttu3+kqRJFuNGWvTfEnxEVE+R2quJEqeiPHNoGdJhkRb 0I+g5EU8aZ3+7SnYJiUixag9AQYNACBTVVab6897WGkD+/UMktoBYpAdPJgHe24naXlC PamaIfLt/Rh7+7gib317FSBKI4g5L4V31yWKXRy4CQt9qh0QgGYG4ACqG3z39dkWs8jj 6ozw== X-Gm-Message-State: AO0yUKWXRNl2NwUBHA+n3Qh7CgD2SPJk1FI49HVCt5hU2+l/Pg8zM53N qJpCqPOZG1AVi+s49Yq0PKSmpeii9xUZ02THl3mTJw== X-Google-Smtp-Source: AK7set9F4u722OkpXBvTbwVo7eCQ7QLvmQTwkMqIg2LACU7M2aYX2ATRDdPXXoHFDCXc6U7xCq0cgsgND0rwHzgdHtY= X-Received: by 2002:a17:906:1803:b0:7c0:f45e:22ff with SMTP id v3-20020a170906180300b007c0f45e22ffmr6633853eje.104.1675694007671; Mon, 06 Feb 2023 06:33:27 -0800 (PST) MIME-Version: 1.0 References: <20230124131717.128660-5-bchihi@baylibre.com> <20230131153816.21709-1-bchihi@baylibre.com> <20230206140713.GB15176@linaro.org> In-Reply-To: <20230206140713.GB15176@linaro.org> From: Balsam CHIHI Date: Mon, 6 Feb 2023 15:32:51 +0100 Message-ID: Subject: Re: [PATCH v12] thermal: drivers: mediatek: Add the Low Voltage Thermal Sensor driver To: Daniel Lezcano Cc: Krzysztof Kozlowski , angelogioacchino.delregno@collabora.com, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org, ye.xingchen@zte.com.cn, p.zabel@pengutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, khilman@baylibre.com, james.lo@mediatek.com, rex-bc.chen@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_063331_506806_759DD4B6 X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On Mon, Feb 6, 2023 at 3:07 PM Daniel Lezcano wrote: > > On Wed, Feb 01, 2023 at 08:55:07AM +0100, Krzysztof Kozlowski wrote: > > On 31/01/2023 16:38, bchihi@baylibre.com wrote: > > > From: Balsam CHIHI > > > > > > The Low Voltage Thermal Sensor (LVTS) is a multiple sensors, multi > > > controllers contained in a thermal domain. > > > > > > A thermal domains can be the MCU or the AP. > > > > > > Each thermal domains contain up to seven controllers, each thermal > > > controller handle up to four thermal sensors. > > > > > > The LVTS has two Finite State Machines (FSM), one to handle the > > > functionin temperatures range like hot or cold temperature and another > > > one to handle monitoring trip point. The FSM notifies via interrupts > > > when a trip point is crossed. > > > > > > > (...) > > > > > + > > > +struct lvts_domain { > > > + struct lvts_ctrl *lvts_ctrl; > > > + struct reset_control *reset; > > > + struct clk *clk; > > > + int num_lvts_ctrl; > > > + void __iomem *base; > > > + size_t calib_len; > > > + u8 *calib; > > > +}; > > > + > > > +#ifdef CONFIG_MTK_LVTS_THERMAL_DEBUGFS > > > + > > > +static struct dentry *root; > > > > How do you handle two instances of driver? > > For now, we can put the entry in /sys/kernel/debug/ Yes, sure. I will do the necessary changes. > > I'm preparing a debugfs series for the thermal framework and that will provide > an entry to hook in for the sensors debugfs if available It would be a good feature! good luck! Best regards, Balsam. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel