From: Alexandru Ardelean <alex@shruggie.ro>
To: Andrei Coardos <aboutphysycs@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, michal.simek@amd.com,
p.zabel@pengutronix.de
Subject: Re: [PATCH] reset: zynqmp: removed unneeded call to platform_set_drvdata()
Date: Mon, 7 Aug 2023 15:02:08 +0300 [thread overview]
Message-ID: <CAH3L5QoC5rzTCr3SmODm49ms-ThAjaGkM2whoo2-=r9Pq_oUfQ@mail.gmail.com> (raw)
In-Reply-To: <20230807114344.15076-1-aboutphysycs@gmail.com>
On Mon, Aug 7, 2023 at 2:43 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/reset/reset-zynqmp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
> index 59dc0ff9af9e..510c168d635f 100644
> --- a/drivers/reset/reset-zynqmp.c
> +++ b/drivers/reset/reset-zynqmp.c
> @@ -107,8 +107,6 @@ static int zynqmp_reset_probe(struct platform_device *pdev)
> if (!priv->data)
> return -EINVAL;
>
> - platform_set_drvdata(pdev, priv);
> -
> priv->rcdev.ops = &zynqmp_reset_ops;
> priv->rcdev.owner = THIS_MODULE;
> priv->rcdev.of_node = pdev->dev.of_node;
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-07 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 11:43 [PATCH] reset: zynqmp: removed unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-07 12:02 ` Alexandru Ardelean [this message]
2023-08-08 13:47 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH3L5QoC5rzTCr3SmODm49ms-ThAjaGkM2whoo2-=r9Pq_oUfQ@mail.gmail.com' \
--to=alex@shruggie.ro \
--cc=aboutphysycs@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).