Re: [PATCH v5 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK

From: Adam Ford <aford173@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
	linux-clk@vger.kernel.org,  Fabio Estevam <festevam@gmail.com>,
	Abel Vesa <abelvesa@kernel.org>,
	 Alexander Stein <alexander.stein@ew.tq-group.com>,
	Jacky Bai <ping.bai@nxp.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	 Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	 Michael Turquette <mturquette@baylibre.com>,
	NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	Richard Cochran <richardcochran@gmail.com>,
	 Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	 Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK
Date: Mon, 27 Feb 2023 20:44:51 -0600	[thread overview]
Message-ID: <CAHCN7x+Jd+C2B+-igv=Pk0Ab4Tj7ecxRrdV85u5CSZ5DjFs5kA@mail.gmail.com> (raw)
In-Reply-To: <c3b3c08c-989b-3868-c74f-426b8f1733a5@denx.de>

On Mon, Feb 27, 2023 at 1:37 PM Marek Vasut <marex@denx.de> wrote:
>
> On 2/27/23 19:59, Marco Felsch wrote:
> [...]
>
> >> @@ -344,6 +384,18 @@ &i2c3 {
> >>      pinctrl-0 = <&pinctrl_i2c3>;
> >>      status = "okay";
> >>
> >> +    wm8960: codec@1a {
> >> +            #sound-dai-cells = <0>;
> >> +            compatible = "wlf,wm8960";
> >> +            reg = <0x1a>;
> >
> > The compatible should be the first property followed by the reg
> > property.
>
> See my reply to the mx8mn sound-sai-cells patch , I am not sure here.
> The rest is fixed in V6.
>
> >> +            clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SAI3_MCLK1>;
> >> +            clock-names = "mclk";
> >> +            wlf,shared-lrclk;
> >> +            wlf,hp-cfg = <3 2 3>;
> >> +            wlf,gpio-cfg = <1 3>;
> >> +            SPKVDD1-supply = <&reg_audio_pwr>;
> >> +    };
> >> +
> >>      pca6416: gpio@20 {
> >>              compatible = "ti,tca6416";
> >>              reg = <0x20>;
>
> [...]
>
> >> @@ -668,6 +730,18 @@ MX8MP_IOMUXC_UART3_TXD__UART1_DCE_RTS   0x140
> >>              >;
> >>      };
> >>
> >> +    pinctrl_sai3: sai3grp {
> >> +            fsl,pins = <
> >> +                    MX8MP_IOMUXC_SAI3_TXFS__AUDIOMIX_SAI3_TX_SYNC   0xd6
> >> +                    MX8MP_IOMUXC_SAI3_TXC__AUDIOMIX_SAI3_TX_BCLK    0xd6
> >> +                    MX8MP_IOMUXC_SAI3_RXD__AUDIOMIX_SAI3_RX_DATA00  0xd6
> >> +                    MX8MP_IOMUXC_SAI3_TXD__AUDIOMIX_SAI3_TX_DATA00  0xd6
> >> +                    MX8MP_IOMUXC_SAI3_MCLK__AUDIOMIX_SAI3_MCLK      0xd6
> >> +                    MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28              0xd6
> >
> > What is gpio04-io28 used for?
>
> Apparently unused, dropped.

Isn't that the headphone detect GPIO?

I think simple-audio-card,hp-det-gpio can reference it.

adam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel