From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0C9FC7EE2E for ; Tue, 28 Feb 2023 02:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1WAGgCXOTiRgbaUAIFq7eRQnheUoxOs9uXPQcB0/gZw=; b=ick02xAUXUmF7f hkMCVyFJfAspswxKrJW4W4LnvQX2EZjX9KMz/S31CmMa9BSWc/MDcbNR2c1j9ERHEYG6LrtQmOIQm WGtZ3QqdziyDXnGST36cVpuyld5XNjoJszgPB7vK+NnVOLs8SAwN1eUu4zeTakXAIgf9rj9wYkkrJ 2J2F/AKD2kltJnQaXq3A/S/h6LyK/2dmPrGRhLU1Xg2VIJX/tV2KXE7vTu/F5cqvvo/ML+Nf3Zjor BCfiZEXJxzCKG7R2Md7j5TriDWPR6WBlJkfwln8H68q6Cxe8RIshih2f14D1eUOJ/7t1awr4gD/X5 BEVTsVhjDc8GKWBBFtfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWpzH-00BqSm-9S; Tue, 28 Feb 2023 02:45:07 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWpzE-00BqRN-LZ for linux-arm-kernel@lists.infradead.org; Tue, 28 Feb 2023 02:45:05 +0000 Received: by mail-pl1-x630.google.com with SMTP id v11so5419595plz.8 for ; Mon, 27 Feb 2023 18:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Yp+cx5BFVXE61foSW4F34Ogh74kOmNMTmxNJN2cfT5Q=; b=BQz+FnfWKpBNmYZICc7SMMec1z0Ldj2tkC9abE8eTiaTU2FVW5NLrdm4hXsE1Vq0Hy vZ1Zz/Rr3d63/9dr6lexxY6ieM5UBwCUhiX2xNf/lmJ7ij6fGzHs95kj9lxa/jvziNUR 3fUjE7Wvqrn1Jhp8BkNyMRvSnmh9IwVagDdvjgH1isX7MY2CKbnXom6s7POeZTyaKVRS YzT5hH/2DIGdpB1z6xlvZhBCSVC4MHaRbbHWQGSa/Bs6xtCS0i2RB4JV/EIUKWnkVB2y qDnnOSbioNkdxjaTMXHGTiSnnRB4pN1xMaQV6tUOkoYl7skJMTx7dDpP0BKY+6MP3nuW VnxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yp+cx5BFVXE61foSW4F34Ogh74kOmNMTmxNJN2cfT5Q=; b=oLYQCKHpeZJQaWJBSicDtF+JwkmSYTkA/sYIIHBypFjv5uqt1kdqnzY2ap1PtUSOAf 9xT+HN9JMrBwHDnFes7k1Nd1+nVdOlXi8t6yDIe3TAUsWaKQHG6LV2xw29UfPMTKDqG/ +n36/OpKTAZBCFDjsZ9JQxoXWhmxU6x5jCBwRdlFqiu5nXIneg48Sg+1PXAFDNU7Ith2 TBjP9Lu3QjnjvLi1gHtl95uJuSeOGOAzSGiHnx/laSHFufnSVazA4/rRtF8/7LQTXK2d 2/u+FuO61j5o9FcGvWALxc+IW7gfghz7UptY+kliJ6MtO9LansYpWYMClhl4Yc9hPsGx dp7Q== X-Gm-Message-State: AO0yUKUi/72M4HNqEp8F/HXCSmFZgnp1x9CwyIrZ1d+Vk9vpD1R/8svC LwcaaCBr90V9uC3xTpA/8ULZcqAiLiJ0unZjp48= X-Google-Smtp-Source: AK7set/BXq9vpXNq1siAy5drrmiLTAQ574AKQS4/hXo9eMqASe+IMp4kQbtzlHHaTJXRDStPpn8tnZ099rjWvqlkaD4= X-Received: by 2002:a17:90a:8a04:b0:237:9ca5:4d5d with SMTP id w4-20020a17090a8a0400b002379ca54d5dmr534185pjn.6.1677552302654; Mon, 27 Feb 2023 18:45:02 -0800 (PST) MIME-Version: 1.0 References: <20230227174308.87286-1-marex@denx.de> <20230227174308.87286-5-marex@denx.de> <20230227185949.xaxltai4ksgrczmc@pengutronix.de> In-Reply-To: From: Adam Ford Date: Mon, 27 Feb 2023 20:44:51 -0600 Message-ID: Subject: Re: [PATCH v5 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK To: Marek Vasut Cc: Marco Felsch , linux-clk@vger.kernel.org, Fabio Estevam , Abel Vesa , Alexander Stein , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Luca Ceresoli , Lucas Stach , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_184504_729312_CC236F4A X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 27, 2023 at 1:37 PM Marek Vasut wrote: > > On 2/27/23 19:59, Marco Felsch wrote: > [...] > > >> @@ -344,6 +384,18 @@ &i2c3 { > >> pinctrl-0 = <&pinctrl_i2c3>; > >> status = "okay"; > >> > >> + wm8960: codec@1a { > >> + #sound-dai-cells = <0>; > >> + compatible = "wlf,wm8960"; > >> + reg = <0x1a>; > > > > The compatible should be the first property followed by the reg > > property. > > See my reply to the mx8mn sound-sai-cells patch , I am not sure here. > The rest is fixed in V6. > > >> + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SAI3_MCLK1>; > >> + clock-names = "mclk"; > >> + wlf,shared-lrclk; > >> + wlf,hp-cfg = <3 2 3>; > >> + wlf,gpio-cfg = <1 3>; > >> + SPKVDD1-supply = <®_audio_pwr>; > >> + }; > >> + > >> pca6416: gpio@20 { > >> compatible = "ti,tca6416"; > >> reg = <0x20>; > > [...] > > >> @@ -668,6 +730,18 @@ MX8MP_IOMUXC_UART3_TXD__UART1_DCE_RTS 0x140 > >> >; > >> }; > >> > >> + pinctrl_sai3: sai3grp { > >> + fsl,pins = < > >> + MX8MP_IOMUXC_SAI3_TXFS__AUDIOMIX_SAI3_TX_SYNC 0xd6 > >> + MX8MP_IOMUXC_SAI3_TXC__AUDIOMIX_SAI3_TX_BCLK 0xd6 > >> + MX8MP_IOMUXC_SAI3_RXD__AUDIOMIX_SAI3_RX_DATA00 0xd6 > >> + MX8MP_IOMUXC_SAI3_TXD__AUDIOMIX_SAI3_TX_DATA00 0xd6 > >> + MX8MP_IOMUXC_SAI3_MCLK__AUDIOMIX_SAI3_MCLK 0xd6 > >> + MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 0xd6 > > > > What is gpio04-io28 used for? > > Apparently unused, dropped. Isn't that the headphone detect GPIO? I think simple-audio-card,hp-det-gpio can reference it. adam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel