From: Amit Kucheria <amit.kucheria@verdurent.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: "moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
Alexey Brodkin <alexey.brodkin@synopsys.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux PM list <linux-pm@vger.kernel.org>,
James Hogan <jhogan@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
Guenter Roeck <groeck@chromium.org>,
Zhang Rui <rui.zhang@intel.com>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
Guan Xuetao <gxt@pku.edu.cn>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH 1/7] thermal/drivers/core: Remove the module Kconfig's option
Date: Wed, 24 Apr 2019 11:15:05 +0530 [thread overview]
Message-ID: <CAHLCerOs-8pAZFvEpxc-ktNV631LaLEmjCyObsYKKC0U29kLag@mail.gmail.com> (raw)
In-Reply-To: <20190423155208.GC16014@localhost.localdomain>
On Tue, Apr 23, 2019 at 9:22 PM Eduardo Valentin <edubezval@gmail.com> wrote:
>
> Hello,
>
> On Tue, Apr 02, 2019 at 06:12:44PM +0200, Daniel Lezcano wrote:
> > The module support for the thermal subsystem makes little sense:
> > - some subsystems relying on it are not modules, thus forcing the
> > framework to be compiled in
> > - it is compiled in for almost every configs, the remaining ones
> > are a few platforms where I don't see why we can not switch the thermal
> > to 'y'. The drivers can stay in tristate.
> > - platforms need the thermal to be ready as soon as possible at boot time
> > in order to mitigate
> >
> > Usually the subsystems framework are compiled-in and the plugs are as module.
> >
> > Remove the module option. The removal of the module related dead code will
> > come after this patch gets in or is acked.
>
>
> I remember some buzilla entry around this some time back.
>
> Rui, do you remember why you made this to be module?
>
> I dont have strong opinion here, but I would like to see
> a better description why we are going this direction rather
> than "most people dont use it as module". Was there any particular
> specific technical motivation?
Speaking for Qualcomm platforms, we want the thermal subsystem
available as soon as possible for boot time thermal mitigation since
faster boot times equals hotter cpus. Also the dependency on cpufreq
subsystem due to the cpufreq cooling device would be simplified with
this.
In fact, I now have a follow on patch to move thermal init earlier
than fs_initcall since we'd now not wait on modules to be available.
/Amit
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-24 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 16:12 [PATCH 1/7] thermal/drivers/core: Remove the module Kconfig's option Daniel Lezcano
2019-04-03 22:55 ` Paul Burton
2019-04-04 20:40 ` Robert Jarzmik
2019-04-23 15:52 ` Eduardo Valentin
2019-04-24 5:45 ` Amit Kucheria [this message]
2019-04-24 13:02 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerOs-8pAZFvEpxc-ktNV631LaLEmjCyObsYKKC0U29kLag@mail.gmail.com \
--to=amit.kucheria@verdurent.com \
--cc=akpm@linux-foundation.org \
--cc=alexey.brodkin@synopsys.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@zonque.org \
--cc=edubezval@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gxt@pku.edu.cn \
--cc=jhogan@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robert.jarzmik@free.fr \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).