From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53FF7C433F5 for ; Fri, 11 Mar 2022 23:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VVaDDcoCgIDl8HTCT3CHqJ1X8wqtuZb8avbTJLXdvPI=; b=CDCwE3smigBvBk Hjxm5fCRvYcRVVoynafl38tK9bQOoYDdoV9Xx4zn2TKNyXH1ZstgaGwmwj1hNZuuSFwH61rJVZNSW tDgUTL7dQTJoPcweytCnsvRGlrGzmF4pY7XsLQOwu3dKGAMulsvup0+qZ7gf6hpThXx/HmVYUFZNl W7uTxvwJB35m+SKgnKSIPqkLdlMitQyS7swRN2tes1zmcbDlp7zp7kW6SKD67n7fPDQoV5YH0Y2VA iaYf34x0/D2RcEhP+x5zgMKp22uhBdSCgaIw41o2Ftt2XpZ2uepYRwiMA+EmuivKtJyiHpMolmtDB JX53pmNPXRG3uD/eSl5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSoIs-000R8x-E7; Fri, 11 Mar 2022 23:04:10 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSoIo-000R8L-Ei for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 23:04:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86EA5B80F99 for ; Fri, 11 Mar 2022 23:04:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6D80C340E9 for ; Fri, 11 Mar 2022 23:04:02 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="WkaW5kUN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1647039837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iU768NbCOwlNRZFo6HjCf6YcGMUw9fVxw/WXICDda/c=; b=WkaW5kUNsUQoQ5lkd8lZRDDh+IUHOmYx/Er47DStC4efvN/eGUF1RwWhzFD4R4ch51tFjI +RtLGigGZja9J8m0esqaWpYZQiKs1/f3jtUSWcQ5Ae0RVJ4wyJxIOxJEqT/ohDZTZKo1HW TgRTIT/ohJG2IwCnwlzEksIYPmU0HFI= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id be3195a8 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Fri, 11 Mar 2022 23:03:57 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id x200so19816285ybe.6 for ; Fri, 11 Mar 2022 15:03:56 -0800 (PST) X-Gm-Message-State: AOAM531CIVp/vKOJtu+34Kk0yJzL+nTI/LiYuzlL2UlTEoMQvYEnpB2I 3YnGEmEv/JhHZ9jSLMn2P8Ksq4dzJLYXg1RXvIw= X-Google-Smtp-Source: ABdhPJzb+6m6mC9NJaH1gFTUli2BOSEieC6FDfMICSN651izpAZSkz4593eFwo5CLg+NhpPmYocblzZLNAOOTcyCckI= X-Received: by 2002:a05:6902:544:b0:628:df6d:a492 with SMTP id z4-20020a056902054400b00628df6da492mr10303321ybs.398.1647039833577; Fri, 11 Mar 2022 15:03:53 -0800 (PST) MIME-Version: 1.0 References: <20210610134459.28541-1-tianjia.zhang@linux.alibaba.com> <20210610134459.28541-2-tianjia.zhang@linux.alibaba.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Fri, 11 Mar 2022 16:03:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] crypto: sm4 - create SM4 library based on sm4 generic code To: Eric Biggers Cc: Herbert Xu , Tianjia Zhang , "David S. Miller" , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Gilad Ben-Yossef , Ard Biesheuvel , "Markku-Juhani O . Saarinen" , Jussi Kivilinna , X86 ML , Linux Crypto Mailing List , linux-arm-kernel , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220311_150406_961045_DD5D8CD1 X-CRM114-Status: GOOD ( 23.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tianjia, On Wed, Mar 2, 2022 at 3:23 PM Eric Biggers wrote: > > On Wed, Mar 02, 2022 at 01:26:13AM +0100, Jason A. Donenfeld wrote: > > On Wed, Mar 2, 2022 at 1:24 AM Herbert Xu wrote: > > > > > > On Tue, Mar 01, 2022 at 11:34:28AM +0100, Jason A. Donenfeld wrote: > > > > > lib/crypto/Kconfig | 3 + > > > > > lib/crypto/Makefile | 3 + > > > > > lib/crypto/sm4.c | 184 +++++++++++++++++++++++++++++++++++++++++++ > > > > > > > > If this is only used by the crypto API, it does not belong in > > > > lib/crypto. > > > > > > Nope there is no such rule. lib/crypto is fine if you're adding > > > code that is shared between crypto and arch/*/crypto. > > > > The sprawling madness continues then... Noted. > > I think it would make more sense for this code to be in crypto/, for the reason > that Jason gave. Were you planning on submitting a patch for this? Thanks, Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel