From: dromede@gmail.com (Marko Katić)
To: linux-arm-kernel@lists.infradead.org
Subject: pxa:spitz_pm.c: commit b6eede11 breaks spitz resume under certain conditions.
Date: Thu, 18 Oct 2012 09:28:14 -0000 [thread overview]
Message-ID: <CAHod+GcwNr6r_ZQFq-btPJ3E_keWKJhkCb2jP4CES6JTSyn8ow@mail.gmail.com> (raw)
In-Reply-To: <CAHod+Gd=aLbntWsX_S_26_XSUtG9DQYkki1Y+drq0+8GdnHfaw@mail.gmail.com>
> Almost there, but I guess we could do this better and less confusing by having
> another array, e.g. tosa_gpio18_config[], which is tosa specific, and only
> initialize that MFP setting in the tosa path.
>
>>
>> I also looked at the original sharp kernel sources.
>> Only tosa used the RDY signal for it's tc6393tx chip, other machines simply
>> configured gpio18 as output in their suspend routines.
Actually, tosa doesn't use sharpsl_pm. Tosa uses the pda-power framework.
I said that only tosa uses the RDY signal to point out that we
probably don't need
the mfp-config line in postsuspend. That being said, i still think
that the array ordering
fix is adequate. Maybe later we may remove the mfp-config line from
postsuspend when
we're absolutely sure it isn't necessary for devices that use spitz_pm.c.
next prev parent reply other threads:[~2012-10-18 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 19:29 pxa:spitz_pm.c: commit b6eede11 breaks spitz resume under certain conditions Marko Katić
2012-09-21 2:13 ` Eric Miao
[not found] ` <CAHod+Gc1L0pPZhnPL6Q2rx0KT=-VqdWaTd1FJt2aA9hTMZyeDg@mail.gmail.com>
2012-09-28 9:22 ` Marko Katić
[not found] ` <CAMPhdO8duNqisVL+FLc_0zgFTP+13r83XtRD0YbpdkzMuJov3Q@mail.gmail.com>
[not found] ` <CAHod+Gd=aLbntWsX_S_26_XSUtG9DQYkki1Y+drq0+8GdnHfaw@mail.gmail.com>
2012-10-18 9:28 ` Marko Katić [this message]
2012-10-19 11:37 ` Marko Katić
2012-10-23 3:10 ` Eric Miao
2012-10-23 12:53 ` Marko Katić
2012-10-24 3:31 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHod+GcwNr6r_ZQFq-btPJ3E_keWKJhkCb2jP4CES6JTSyn8ow@mail.gmail.com \
--to=dromede@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).