* [PATCH] arm: mm: fault: use string choices helper
@ 2025-06-17 0:06 Kuninori Morimoto
2025-06-17 6:19 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2025-06-17 0:06 UTC (permalink / raw)
To: Ard Biesheuvel, Kees Cook, Russell King, Yanjun Yang
Cc: Andy Shevchenko, Kees Cook, linux-arm-kernel
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mm/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
index ab01b51de559..b2d59d260a1f 100644
--- a/arch/arm/mm/fault.c
+++ b/arch/arm/mm/fault.c
@@ -136,7 +136,7 @@ static void die_kernel_fault(const char *msg, struct mm_struct *mm,
pr_alert("8<--- cut here ---\n");
pr_alert("Unable to handle kernel %s at virtual address %08lx when %s\n",
msg, addr, fsr & FSR_LNX_PF ? "execute" :
- fsr & FSR_WRITE ? "write" : "read");
+ str_write_read(fsr & FSR_WRITE));
show_pte(KERN_ALERT, mm, addr);
die("Oops", regs, fsr);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: mm: fault: use string choices helper
2025-06-17 0:06 [PATCH] arm: mm: fault: use string choices helper Kuninori Morimoto
@ 2025-06-17 6:19 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-06-17 6:19 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Ard Biesheuvel, Kees Cook, Russell King, Yanjun Yang,
Andy Shevchenko, linux-arm-kernel
On Tue, Jun 17, 2025 at 3:06 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
Missing commit message.
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
...
> pr_alert("Unable to handle kernel %s at virtual address %08lx when %s\n",
> msg, addr, fsr & FSR_LNX_PF ? "execute" :
> - fsr & FSR_WRITE ? "write" : "read");
> + str_write_read(fsr & FSR_WRITE));
Make it now one line with the ternary (either moving the last to the
previous, or resplit the previous by the parameter delimiter.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-17 6:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 0:06 [PATCH] arm: mm: fault: use string choices helper Kuninori Morimoto
2025-06-17 6:19 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).