From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Alexander Clouter <alex@digriz.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Russell King <linux@armlinux.org.uk>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andy Shevchenko <andy@kernel.org>, Kees Cook <kees@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm: orion5x: use string choices helper
Date: Tue, 17 Jun 2025 09:14:10 +0300 [thread overview]
Message-ID: <CAHp75VdeCyHdSdYvke0RVs_qtrhqbn_z1VFM22TCuNe2h8hFMQ@mail.gmail.com> (raw)
In-Reply-To: <87cyb3nm45.wl-kuninori.morimoto.gx@renesas.com>
On Tue, Jun 17, 2025 at 5:22 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> It updates format to keep "online/offline".
>
> - sprintf(buf, "%s\n", ...? "online" : "offline");
> + sprintf(buf, "%sline\n", ..., str_on_off(...));
> ^^^^
With all the respect to Andrew and his review, this is still NAK, but
now from me. Add the respective helper to the string_choices.h, the
proposed change is harder to read and it makes things confusing.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-17 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 2:22 [PATCH v2] arm: orion5x: use string choices helper Kuninori Morimoto
2025-06-17 6:14 ` Andy Shevchenko [this message]
2025-06-17 12:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdeCyHdSdYvke0RVs_qtrhqbn_z1VFM22TCuNe2h8hFMQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alex@digriz.org.uk \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kees@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).