From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Tom Joseph" <tjoseph@cadence.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com,
u-kumar1@ti.com
Subject: Re: [PATCH v2 12/15] phy: cadence-torrent: add suspend and resume support
Date: Fri, 26 Jan 2024 23:48:24 +0200 [thread overview]
Message-ID: <CAHp75Vei9O_mvR7o_esOxko1LnRKWgJ8HmheACtf46bGtWHKug@mail.gmail.com> (raw)
In-Reply-To: <20240102-j7200-pcie-s2r-v2-12-8e4f7d228ec2@bootlin.com>
On Fri, Jan 26, 2024 at 4:38 PM Thomas Richard
<thomas.richard@bootlin.com> wrote:
>
> Add suspend and resume support.
>
> The already_configured flag is cleared during suspend stage to force the
the suspend
> PHY initialization during the resume stage.
...
> + if (!cdns_phy->already_configured)
> + clk_disable_unprepare(cdns_phy->clk);
> + else
> + cdns_phy->already_configured = 0;
What's wrong with a positive check?
Why do you need unprepare clock?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-26 21:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 14:36 [PATCH v2 00/15] Add suspend to ram support for PCIe on J7200 Thomas Richard
2024-01-26 14:36 ` [PATCH v2 01/15] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq() Thomas Richard
2024-01-26 21:30 ` Andy Shevchenko
2024-01-27 20:59 ` Bartosz Golaszewski
2024-01-27 21:46 ` Andi Shyti
2024-02-05 6:58 ` Tony Lindgren
2024-01-26 14:36 ` [PATCH v2 02/15] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq Thomas Richard
2024-01-26 21:31 ` Andy Shevchenko
2024-01-27 21:53 ` Andi Shyti
2024-01-27 22:31 ` Linus Walleij
2024-01-29 22:49 ` Andi Shyti
2024-02-05 7:21 ` Tony Lindgren
2024-02-08 15:52 ` Thomas Richard
2024-01-26 14:36 ` [PATCH v2 03/15] i2c: omap: wakeup the controller during suspend() callback Thomas Richard
2024-01-29 22:48 ` Andi Shyti
2024-01-26 14:36 ` [PATCH v2 04/15] mux: add mux_chip_resume() function Thomas Richard
2024-01-26 21:28 ` Andy Shevchenko
2024-01-30 16:38 ` Thomas Richard
2024-01-29 22:54 ` Andi Shyti
2024-01-30 8:25 ` Peter Rosin
2024-01-30 16:24 ` Thomas Richard
2024-01-26 14:36 ` [PATCH v2 05/15] mux: mmio: add resume support Thomas Richard
2024-01-26 21:32 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 06/15] phy: ti: phy-j721e-wiz: make wiz_clock_init callable multiple times Thomas Richard
2024-01-26 21:38 ` Andy Shevchenko
2024-01-29 23:02 ` Andi Shyti
2024-01-26 14:36 ` [PATCH v2 07/15] phy: ti: phy-j721e-wiz: add resume support Thomas Richard
2024-01-26 21:42 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 08/15] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk Thomas Richard
2024-01-26 21:44 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 09/15] phy: cadence-torrent: register resets even if the phy is already configured Thomas Richard
2024-01-26 21:45 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 10/15] phy: cadence-torrent: add already_configured to struct cdns_torrent_phy Thomas Richard
2024-01-26 14:36 ` [PATCH v2 11/15] phy: cadence-torrent: remove noop_ops phy operations Thomas Richard
2024-01-26 14:36 ` [PATCH v2 12/15] phy: cadence-torrent: add suspend and resume support Thomas Richard
2024-01-26 21:48 ` Andy Shevchenko [this message]
2024-01-26 14:36 ` [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup() Thomas Richard
2024-01-26 21:43 ` Bjorn Helgaas
2024-01-26 21:50 ` Andy Shevchenko
2024-01-29 22:16 ` Bjorn Helgaas
2024-01-29 22:24 ` Bjorn Helgaas
2024-01-26 14:36 ` [PATCH v2 14/15] PCI: j721e: add reset GPIO to struct j721e_pcie Thomas Richard
2024-01-26 21:52 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 15/15] PCI: j721e: add suspend and resume support Thomas Richard
2024-01-26 21:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vei9O_mvR7o_esOxko1LnRKWgJ8HmheACtf46bGtWHKug@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@linaro.org \
--cc=jmkrzyszt@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).