From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C966C433F5 for ; Fri, 12 Nov 2021 00:38:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F33061267 for ; Fri, 12 Nov 2021 00:38:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1F33061267 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C8aXv5KyP8elEniOjkd9gqNmQ0HLsLSCyuTJniSu9hQ=; b=yfeNzm1ovaL8/7 0tqdxLXbb5w16w6b8TArV/xlwpnh3LadE2/9ntcvtP0lewXmVwQCqBnS8A15U1HEgNusuxjOX/10u LnL1xvT1iMlJx0FYfxvfBqYDfkxT9dwn4kb1xXtMwDCZcGYRvzOHjwHj6CW2tcuIeXyYx2IlFHrVJ Lmd9iWmb2631LaeLzSD5hQyBu989BnEwyPFSUBNRI14rcZwzqeAxTsOvoEiMF+IRQmLpW3rwCeKen eMGqe97vDcX3WgcAJgx90kVjO2qsaXKI8sWkwpxYwQD8SqecmHm7kj1SYkQQ7Vx6bSpdxTNC38h/S Gr140g1k6KCumX8vHDQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlKYz-0094Si-4u; Fri, 12 Nov 2021 00:37:05 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlKYu-0094SG-CY for linux-arm-kernel@lists.infradead.org; Fri, 12 Nov 2021 00:37:02 +0000 Received: by mail-pf1-x429.google.com with SMTP id z6so7012675pfe.7 for ; Thu, 11 Nov 2021 16:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z6wBzxs2vTAMcv/J9u+OybiBdroBp59bgycTGw8HIpM=; b=qUi+Sh/Y7/5cYaVesftwnN+AXUfY08JNi8xdCSfFL7QrR3oBfuGelJ2+HcBCGX7aLD 8vqPI03V9Bs88FH99EisjRgLrCIRkvzSj++iZ0kFR7e6ZkKRj7gEVVFweq7ExK/PA169 0UiGxOa5S+pybGuCDR7+f0t74CvrecGqSL2GISkoQYH6lczTJip7WbAoK1j65SYyR+XM gkJxNc3uXQCkCwM4pf6PpvQWaJUWonwgyfC0Z3BtihCq5PtUWVsrMmw2ByaJVxttOBN2 Tw3V2eVqygNoGRRz8krOfLNagAmg7pWNeJSt1If1diUHPJ/FeHj6q9dRMAb/oMWr4TzA 0GwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z6wBzxs2vTAMcv/J9u+OybiBdroBp59bgycTGw8HIpM=; b=ISE6UH2TbZNYvzme3vaxrI3woNLDaq9dj39TBzqxho5gsq65oQ4v/aNEoI72ftzzhl P5BhbH7B3MaQQTNfPoeX33c9c95lQfiNJX8xPqpfg/OE5PZlb6A0vjM897B9QCidK+C7 SOm24U277uvscIpw2y4bEqON4c1L6UzaTF+iqcq+zheAylpja2EmEbGYtr2M2zfmafRi TUNsIeCVkTlR6L6FPXmsGT6E27MpyxHrRo+amc8CKeexcJxKM8vQC4JKLpa/1g1f2FHb HbAZQ6bimfih8me3Oes4emCZdSf1xHrfEFnzj6/10DI13z/BCUsBUV7SdZD+UbXHSLjB v7lA== X-Gm-Message-State: AOAM530eV66ytcYRwj6ZN6MuZEQ7zqeAvuSon+vNIHGkPi05s5UXYUby ZjrmNUXkcowlsyJ1XnRMB5YWzjHaiQfo04gwxf18fg== X-Google-Smtp-Source: ABdhPJyEuWQYQMmqBAEeskiNnGVCSkkFSoDOsoWXBmUkyHvskYzQQ2kvrOnjM5RktCJ9LsGhLwGT688nLfPukZMoYX8= X-Received: by 2002:a63:191d:: with SMTP id z29mr1881558pgl.358.1636677419131; Thu, 11 Nov 2021 16:36:59 -0800 (PST) MIME-Version: 1.0 References: <20211111101456.584061-1-jagan@amarulasolutions.com> <20211111101456.584061-3-jagan@amarulasolutions.com> In-Reply-To: <20211111101456.584061-3-jagan@amarulasolutions.com> From: Tim Harvey Date: Thu, 11 Nov 2021 16:36:47 -0800 Message-ID: Subject: Re: [RFC PATCH v2 2/3] arm64: dts: imx8mm: Add MIPI DSI pipeline To: Jagan Teki Cc: Adam Ford , Fabio Estevam , Lucas Stach , Peng Fan , Shawn Guo , Marek Vasut , Frieder Schrempf , NXP Linux Team , Linux ARM Mailing List , DRI mailing list , linux-amarula , Matteo Lisi , Device Tree Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_163700_465470_62C8C836 X-CRM114-Status: GOOD ( 20.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 11, 2021 at 2:15 AM Jagan Teki wrote: > > Add MIPI DSI pipeline for i.MX8MM. > > Video pipeline start from eLCDIF to MIPI DSI and respective > Panel or Bridge on the backend side. > > Add support for it. Jagan, Thanks for your continued work on IMX8MM DSI support! It doesn't look like you sent this to the Device Tree mainling list so I added that to cc. > > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 55 +++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index caeb93313413..eddf3a467fd2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -188,6 +188,12 @@ clk_ext4: clock-ext4 { > clock-output-names = "clk_ext4"; > }; > > + mipi_phy: mipi-video-phy { > + compatible = "fsl,imx8mm-mipi-video-phy"; > + syscon = <&disp_blk_ctrl>; > + #phy-cells = <1>; > + }; > + > psci { > compatible = "arm,psci-1.0"; > method = "smc"; > @@ -1085,6 +1091,55 @@ lcdif: lcdif@32e00000 { > interrupts = ; > power-domains = <&disp_blk_ctrl IMX8MM_DISPBLK_PD_LCDIF>; > status = "disabled"; > + > + port { > + lcdif_out_dsi: endpoint { > + remote-endpoint = <&dsi_in_lcdif>; > + }; > + }; > + }; > + > + dsi: dsi@32e10000 { I wonder if this should this be 'mipi_dsi' like the CSI bindings Adam's submitted here: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20211106155427.753197-2-aford173@gmail.com/ > + compatible = "fsl,imx8mm-mipi-dsim"; > + reg = <0x32e10000 0x400>; > + clocks = <&clk IMX8MM_CLK_DSI_CORE>, > + <&clk IMX8MM_CLK_DSI_PHY_REF>; > + clock-names = "bus_clk", "sclk_mipi"; > + assigned-clocks = <&clk IMX8MM_CLK_DSI_CORE>, > + <&clk IMX8MM_VIDEO_PLL1_OUT>, > + <&clk IMX8MM_CLK_DSI_PHY_REF>; > + assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_266M>, > + <&clk IMX8MM_VIDEO_PLL1_BYPASS>, > + <&clk IMX8MM_VIDEO_PLL1_OUT>; > + assigned-clock-rates = <266000000>, <594000000>, <27000000>; > + interrupts = ; > + phys = <&mipi_phy 0>; > + phy-names = "dsim"; > + power-domains = <&disp_blk_ctrl IMX8MM_DISPBLK_PD_MIPI_DSI>; > + samsung,burst-clock-frequency = <891000000>; > + samsung,esc-clock-frequency = <54000000>; > + samsung,pll-clock-frequency = <27000000>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; I don't think the '#address-cells' and '#size-cells' are needed here but I defer to the dt experts! > + > + dsi_in_lcdif: endpoint@0 { > + reg = <0>; Per Adam's comment to my posting this should be just "port {" and we can get rid of the @0 and the "reg=0" Best regards, Tim > + remote-endpoint = <&lcdif_out_dsi>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + }; > + }; > }; > > disp_blk_ctrl: blk-ctrl@32e28000 { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel