From: r.sricharan@ti.com (R, Sricharan)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: LPAE: Fix alloc_init_section to flush all the pmd entries.
Date: Fri, 17 Aug 2012 16:33:07 +0530 [thread overview]
Message-ID: <CAJ7qFSfdZmzH=u9DV4MYeFyee5ntB2gOC1GOSDqNzMBYh0puoA@mail.gmail.com> (raw)
In-Reply-To: <1344249230-29835-1-git-send-email-r.sricharan@ti.com>
Hi,
On Mon, Aug 6, 2012 at 4:03 PM, R Sricharan <r.sricharan@ti.com> wrote:
> flush_pmd_entry flushes one cache line by MVA. This is
> called by alloc_init_section to flush the mapped pmd
> entries. But this is called outside the loop and when
> LPAE is enabled the number of pmd entries to be
> flushed can be across multiple cache lines. So call
> this inside the loop so that all the mapped entries are
> flushed.
>
> This is going to result in additional cache line
> flushes. There might be other better way to handle
> this.
>
> Signed-off-by: R Sricharan <r.sricharan@ti.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mm/mmu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index 0ed8808..02af3fe 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -619,7 +619,6 @@ static void __init alloc_init_section(pud_t *pud, unsigned long addr,
> * up one logical pointer to an L2 table.
> */
> if (type->prot_sect && ((addr | end | phys) & ~SECTION_MASK) == 0) {
> - pmd_t *p = pmd;
>
> #ifndef CONFIG_ARM_LPAE
> if (addr & SECTION_SIZE)
> @@ -629,9 +628,8 @@ static void __init alloc_init_section(pud_t *pud, unsigned long addr,
> do {
> *pmd = __pmd(phys | type->prot_sect);
> phys += SECTION_SIZE;
> + flush_pmd_entry(pmd);
> } while (pmd++, addr += SECTION_SIZE, addr != end);
> -
> - flush_pmd_entry(p);
> } else {
> /*
> * No need to loop; pte's aren't interested in the
Ping...
Thanks,
Sricharan
prev parent reply other threads:[~2012-08-17 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 10:33 [RFC PATCH] ARM: LPAE: Fix alloc_init_section to flush all the pmd entries R Sricharan
2012-08-17 11:03 ` R, Sricharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ7qFSfdZmzH=u9DV4MYeFyee5ntB2gOC1GOSDqNzMBYh0puoA@mail.gmail.com' \
--to=r.sricharan@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).