Re: [PATCH v3 10/11] coresight: docs: Create common sub-directory for coresight trace.

[Mike Leach <mike.leach@linaro.org>]

Hi,

OK redone with patch09 split, indexes sorted - coresight now has its
own sub-index.
v5 to follow with the docs only patches.

Mike

On Fri, 18 Oct 2019 at 18:31, Mathieu Poirier
<mathieu.poirier@linaro.org> wrote:
>
> On Fri, 18 Oct 2019 at 10:20, Mathieu Poirier
> <mathieu.poirier@linaro.org> wrote:
> >
> > On Tue, Oct 15, 2019 at 10:20:03PM +0100, Mike Leach wrote:
> > > There are two files in the Documentation/trace directory relating to
> > > coresight, with more to follow, so create a Documentation/trace/coresight
> > > directory and move existing files there. Update MAINTAINERS to reference
> > > this sub-directory rather than the individual files.
> > >
> > > Signed-off-by: Mike Leach <mike.leach@linaro.org>
> > > ---
> > >  Documentation/trace/{ => coresight}/coresight-cpu-debug.rst | 0
> > >  Documentation/trace/{ => coresight}/coresight.rst           | 2 +-
> > >  Documentation/trace/{ => coresight}/stm.rst                 | 0
> > >  MAINTAINERS                                                 | 3 +--
> > >  4 files changed, 2 insertions(+), 3 deletions(-)
> > >  rename Documentation/trace/{ => coresight}/coresight-cpu-debug.rst (100%)
> > >  rename Documentation/trace/{ => coresight}/coresight.rst (99%)
> > >  rename Documentation/trace/{ => coresight}/stm.rst (100%)
> > >
> > > diff --git a/Documentation/trace/coresight-cpu-debug.rst b/Documentation/trace/coresight/coresight-cpu-debug.rst
> > > similarity index 100%
> > > rename from Documentation/trace/coresight-cpu-debug.rst
> > > rename to Documentation/trace/coresight/coresight-cpu-debug.rst
> > > diff --git a/Documentation/trace/coresight.rst b/Documentation/trace/coresight/coresight.rst
> > > similarity index 99%
> > > rename from Documentation/trace/coresight.rst
> > > rename to Documentation/trace/coresight/coresight.rst
> > > index 72f4b7ef1bad..835e8aa0bf8c 100644
> > > --- a/Documentation/trace/coresight.rst
> > > +++ b/Documentation/trace/coresight/coresight.rst
> > > @@ -493,6 +493,6 @@ Details on how to use the generic STM API can be found here [#second]_.
> > >
> > >  .. [#first] Documentation/ABI/testing/sysfs-bus-coresight-devices-stm
> > >
> > > -.. [#second] Documentation/trace/stm.rst
> > > +.. [#second] Documentation/trace/coresight/stm.rst
> > >
> > >  .. [#third] https://github.com/Linaro/perf-opencsd
> > > diff --git a/Documentation/trace/stm.rst b/Documentation/trace/coresight/stm.rst
> > > similarity index 100%
> > > rename from Documentation/trace/stm.rst
> > > rename to Documentation/trace/coresight/stm.rst
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 296de2b51c83..f903160b507c 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1608,8 +1608,7 @@ R:      Suzuki K Poulose <suzuki.poulose@arm.com>
> > >  L:   linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > >  S:   Maintained
> > >  F:   drivers/hwtracing/coresight/*
> > > -F:   Documentation/trace/coresight.rst
> > > -F:   Documentation/trace/coresight-cpu-debug.rst
> > > +F:   Documentation/trace/coresight/*
> > >  F:   Documentation/devicetree/bindings/arm/coresight.txt
> > >  F:   Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
> > >  F:   Documentation/ABI/testing/sysfs-bus-coresight-devices-*
> >
> > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> I'm taking that back - please remove mentions of coresight files in
> Documentation/trace/index.rst.
>
> Since you do have to respin, please split patch 09.  And now that I
> have applied all the other patches, your next revision should be a
> documentation set.
>
> Thanks,
> Mathieu
> >
> > > --
> > > 2.17.1
> > >



-- 
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel