From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98FAEC433F5 for ; Wed, 18 May 2022 09:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=knM6oKMC/i1vo4CmQ8lqfkGqvM5qx/Qf5UWsvObIuOE=; b=vVP9k96q2+TUYG deEkytzbt10N5w8N2vUsqcnjTxI2ArHlxBo5YDEc7cH1lVVyjimmj9Oh9kwSbA0aT2EThQM1QyRdG rjepgaZFpkLKax0OgAR3nflnNB0g04MZjLFt8XVXhU19oh8//e46qHdSaSrJaOWi/S/5ROjcFBZRd sPuJ4JwgETwxTuX62eXIRyQfynD7iWFdPRO+6QMfQkFp4gU52+0XHtDKNcGtQHUpSCDo/WDg8lkZ0 HTejtg5CZnTUnYxbUP3d8HX8XCovoVUuwtzk6b/TxtWnV+jPMFlNCJbRtXYWmyvcv3ObDbqdT2FdU 5kY5fIODm82tMeN8fUXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrFeh-000jkW-Jg; Wed, 18 May 2022 09:07:43 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrFee-000ji2-QB for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 09:07:42 +0000 Received: by mail-lf1-x12e.google.com with SMTP id w14so2416237lfl.13 for ; Wed, 18 May 2022 02:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wcrsvOrOm+mRa378F80R7USaGzcRNkSgm1WTWIJU7Qs=; b=dOowfJdUkCgdm+X0sjpkSjkrWinBHywOfRCJNbbQg4ZKVRGegBTMgRLgdR+HsHFGKZ r4xFbL1vipCRMWGmh9nB0S8FKnGjgZbtewcVMVPp2bWC2O5toghr+ux4gKsXPzoghRsL WUOnQv3yOcw7YQOVrDk5ku5tDcNRyvk2u7JzYf93lhPHoYGlKPeYZMMpRm5144bV2zcT WKvj/zSILDcgH344tlgTJ/s606MgwrrA+qjyxf8zFhmnLzroOMdt5L3scY4FFq/gcHxV O3nplaMJWPnZBHVE3SMXQM6BNUvxKU0DNP0ZV6fdaX6iLjwlISaAEUpqQ6h78DIHQUHc rK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wcrsvOrOm+mRa378F80R7USaGzcRNkSgm1WTWIJU7Qs=; b=Jkj328a1nGTccpI8iKwT63GfjrrL0ujVnMN5Cfrf5ONXgsoVBAuk2BoU1sxVdsl83l frCRnFjOcd+A5U79VenAxrTL98LXTn1zJmwWc5Zy6gBCL7M9NXzz5wQRtx+VwpcygrGe NrDcFsQ0nKfEW8yFUnoeT2eRA7pOrjS5qaayC864Sim/Lw+EDPlU85e55hgVFCshavF1 3ZJZXyLcTnT9dw0M8qz0FyzLmubAsq5XKFRupFvV4vtPyE0qQpEvnkXBl9fBJ0up/Jv4 T9sTM9rre27YbUlMesEHQlxevETdu1WepHPrhgVNcGhVtCcpoPRqfuhMcQj3IqLKuLGS xzFA== X-Gm-Message-State: AOAM532rOm2OfXVkrjSUiZ0hFwfJ/OSzqgYHYAyAp83BAdpA3xpSID8+ tMyapNTciJCUnZU8cQIIcWdKP7L/Q4d/HvCzIHG5FA== X-Google-Smtp-Source: ABdhPJzAelqtBPGCxXlfVN3acRhTDjVF3HlQ8kO0+AOIyERK7gjO1Z1UPKDGisPXmDCihnikdsCzfF2/c2VeEisQqRI= X-Received: by 2002:a05:6512:168d:b0:471:6cb9:c20f with SMTP id bu13-20020a056512168d00b004716cb9c20fmr19895367lfb.229.1652864854579; Wed, 18 May 2022 02:07:34 -0700 (PDT) MIME-Version: 1.0 References: <20220308205000.27646-1-mike.leach@linaro.org> <20220308205000.27646-9-mike.leach@linaro.org> <71c11820-433d-755d-0eb4-797313d693f9@huawei.com> In-Reply-To: <71c11820-433d-755d-0eb4-797313d693f9@huawei.com> From: Mike Leach Date: Wed, 18 May 2022 10:07:23 +0100 Message-ID: Subject: Re: [PATCH 08/10] coresight: Remove legacy Trace ID allocation mechanism To: "liuqi (BA)" Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_020740_894071_8CC35629 X-CRM114-Status: GOOD ( 25.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi On Tue, 17 May 2022 at 04:56, liuqi (BA) wrote: > > Hi Mike, > > On 2022/3/9 4:49, Mike Leach wrote: > > This static 'cpu * 2 + seed' was outdated and broken for systems with high > > core counts (>46). > > > > This has been replaced by a dynamic allocation system. > > > > Signed-off-by: Mike Leach > > --- > > include/linux/coresight-pmu.h | 12 ------------ > > 1 file changed, 12 deletions(-) > > Seems coresight_get_trace_id() in tools/include/linux/coresight-pmu.h > need to be deleted too. > > Thanks, > Qi > Agreed - I'll sort it for the next release. Thanks Mike > > > > diff --git a/include/linux/coresight-pmu.h b/include/linux/coresight-pmu.h > > index 4ac5c081af93..bb4eb4de3c77 100644 > > --- a/include/linux/coresight-pmu.h > > +++ b/include/linux/coresight-pmu.h > > @@ -8,7 +8,6 @@ > > #define _LINUX_CORESIGHT_PMU_H > > > > #define CORESIGHT_ETM_PMU_NAME "cs_etm" > > -#define CORESIGHT_ETM_PMU_SEED 0x10 > > > > /* > > * Below are the definition of bit offsets for perf option, and works as > > @@ -32,15 +31,4 @@ > > #define ETM4_CFG_BIT_RETSTK 12 > > #define ETM4_CFG_BIT_VMID_OPT 15 > > > > -static inline int coresight_get_trace_id(int cpu) > > -{ > > - /* > > - * A trace ID of value 0 is invalid, so let's start at some > > - * random value that fits in 7 bits and go from there. Since > > - * the common convention is to have data trace IDs be I(N) + 1, > > - * set instruction trace IDs as a function of the CPU number. > > - */ > > - return (CORESIGHT_ETM_PMU_SEED + (cpu * 2)); > > -} > > - > > #endif > > > _______________________________________________ > CoreSight mailing list -- coresight@lists.linaro.org > To unsubscribe send an email to coresight-leave@lists.linaro.org -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel