From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1803EC83012 for ; Wed, 2 Dec 2020 12:24:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A137322203 for ; Wed, 2 Dec 2020 12:24:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A137322203 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fttW8Iy+lNjwPkCETaqvvEPC3Jxze+C2Tziybkcmw+8=; b=Qb7xKeimsUnQQ5nJCltCuXnY0 EGMnCmjYgmdlAE5BLXsRcbxyt4ywHnsO/Qlo6geHZhFwnyRgVbSxZMLJAMpNXNlj6L8QAdaprpKe1 RpNZ9BVmsLf/UszdAmvhZeQLgeYVZ+vwFNrGI2lWif4fcHqz6Pmu7ijjM1L/PpLgd2PIDSXbpbuLe yi9skdjDEYZLdlyDWQnesonHXWLmy3BFk+ZwUndWCGFgBGHJM6RYmmsqOq59NuR6DfOXwvGzwELy6 kHnKh5aethv6f17+qSpTd6Y3ZikvaMDFmQCqI2k4R2OMHBkZV0hkHDm04+rphn2n9kfhNkfUjprak bu97U4pZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRAm-00062d-5R; Wed, 02 Dec 2020 12:23:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRAj-00061j-CY for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 12:23:50 +0000 X-Gm-Message-State: AOAM533jmOnlZx+qLZ0NvSPl/o1tGj1NDapGMav1X3GvBBXaMKuxTH5v SBtDChQOcN2v2eplflOupxUHKQp+iQIlrIH4GXw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606911828; bh=oa7UfaUP3+xFmxloS25xR2K5dpFVJxrXIk+MwfRXBZY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kMYogxUxKcXGs8GpKM6ZF0u8wOqW40HJn37gmHCJ05psgxxLAWTqbWZG3VVd3lb5h BT6eP1XaVpPlfZtkGeith70uOCd+7pFPBR5AvF5ah9Br2QX/wqk+SYAsxXAuqWpet6 ngzACC+1cd6PJF6hT572GomlYn5YFUWQ9rpzsbO4= X-Google-Smtp-Source: ABdhPJyC/BitHigFIbOKUBueddX1xbZID1vUveQ/Aj0NJNpD8QfuK7AsqevTSakwULDKnR7Term8eac0hqFIyj83LOs= X-Received: by 2002:a05:6402:31b6:: with SMTP id dj22mr2256983edb.348.1606911826521; Wed, 02 Dec 2020 04:23:46 -0800 (PST) MIME-Version: 1.0 References: <20201201123932.12312-1-martin.kepplinger@puri.sm> <20201201123932.12312-8-martin.kepplinger@puri.sm> <20201202080321.GB6087@kozik-lap> <226e76a8-011e-ece5-d8fa-b52dbc81787b@puri.sm> In-Reply-To: <226e76a8-011e-ece5-d8fa-b52dbc81787b@puri.sm> From: Krzysztof Kozlowski Date: Wed, 2 Dec 2020 14:23:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq To: Martin Kepplinger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_072349_567512_8AE5168F X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, kernel@pengutronix.de, cdleonard@gmail.com, devicetree@vger.kernel.org, shawnguo@kernel.org, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-imx@nxp.com, festevam@gmail.com, catalin.marinas@arm.com, will@kernel.org, Georgi Djakov , linux-arm-kernel@lists.infradead.org, kernel@puri.sm Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2 Dec 2020 at 13:30, Martin Kepplinger wrote: > >>>>> -CONFIG_INTERCONNECT=y > >>>> > >>>> Why are you removing this line? > >>> > >>> savedefconfig removes it. INTERCONNECT_IMX below depends on it. > >> > >> It's save to remove it as other Interconnect options are directly > >> dependant. > > > > Ugh, my bad, it is not allowed to remove it. My review was too fast. > > INTERCONNECT_IMX depends on it, so the INTERCONNECT must stay, > > > > It is selected by TEGRA_MC which is independent here, so you should keep it. > > > > thanks for reviewing! Just to be clear: We're talking about defconfig, > so if I keep INTERCONNECT that means that I do `make savedefconfig` > which removes it (it's of course still enabled, just redundant in > defconfig output), and then *manually* add INTERCONNECT. That would > indicate that there's a Kconfig bug. I don't get the point. You should not send the savedefconfig output as is, without any adjustments and checks. You can run savedefconfig because it nicely puts your entries in the proper place, but it's not a bug that it removes features which we *want to keep*. Where is a bug in Kconfig? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel