From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E760C4CEC4 for ; Wed, 18 Sep 2019 13:08:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40F732067B for ; Wed, 18 Sep 2019 13:08:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MZLZeHi+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HkTpq5+C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40F732067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fmkI/LkDZEOUtJ5VelZP/mfe67ArxXh2UE5BH9y+ijg=; b=MZLZeHi+XrRxB8 w2ne4tsehB9mj5VvRHpoVimZP9YSnvDhGJSoBexyvoFR7UyjKjErg85NHJV6XVUxq4zpQ8bBTtAe3 Z0DRUdGGhn0AcRhL//I3rncNOc/y/DUHkXGvHz0JLQGYwPpcac9DW8I3Jxli9l68gZanyuwPPLvYg KY4GBjU8lsx/bv1mTOco4BlpZpjV/mN1d930RH/y6STQ6PiL3S+hjNLQDswhD1Rc/h0UKfSIH8Zw8 YVaSS0oNMvQ4GrR8MmH2zwqZVrUpSYSt9cEq8oEGjPZ22tgWgnSXzVJJE35tXg7aFEXW0d04dx3kl mZOVQFDBzD+uGb48Wtug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAZgr-0000Q8-HN; Wed, 18 Sep 2019 13:08:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAZge-0000PY-Qq for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2019 13:08:02 +0000 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F8D221897 for ; Wed, 18 Sep 2019 13:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568812070; bh=rj5WMPvEQEEDlEkrOcuDiRS34WbhKH/4aLvT8LmbHXM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HkTpq5+CByuJLJDwSrthSKsjXN0hKpfqPBHUURdLgqFG9pQzMkystKtHtUZkcVRG9 We5olk9m+0byrycIfNpv0/D3RpKmOUaLK/JMJQA9ww0uMy6aZi+4/Bahh9uhvPX/em vADBC0xYeKgnxRru0WPZgYYq+O93auE94vaHAndU= Received: by mail-ot1-f46.google.com with SMTP id y39so6242319ota.7 for ; Wed, 18 Sep 2019 06:07:50 -0700 (PDT) X-Gm-Message-State: APjAAAUBIqxbsUsD5fxvbL3Mrrcd1Viar+cdtws6U0RBgaR65WVWrvTu CXTEF24H+U5go/vi0t3xjKVLLaNLeUUbaXhZVdw= X-Google-Smtp-Source: APXvYqwwzw5VrS2kd6JSzP3MY3hp/cDqnCUwn6rD+GogeFn8UDSudHrPnW0AvhgZI930v5OwBzBSAmmjv49Yu3xnlIU= X-Received: by 2002:a9d:6f08:: with SMTP id n8mr2951063otq.128.1568812069398; Wed, 18 Sep 2019 06:07:49 -0700 (PDT) MIME-Version: 1.0 References: <20190907092007.9946-1-krzk@kernel.org> <20190907092007.9946-8-krzk@kernel.org> <20190918123654.GA318@bogus> In-Reply-To: <20190918123654.GA318@bogus> From: Krzysztof Kozlowski Date: Wed, 18 Sep 2019 15:07:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 08/11] dt-bindings: arm: samsung: Convert Exynos System Registers bindings to json-schema To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190918_060800_912840_795010F0 X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alessandro Zummo , Alexandre Belloni , Lars-Peter Clausen , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org, Sebastian Reichel , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler , Hartmut Knaack , linux-rtc@vger.kernel.org, Jonathan Cameron , =?UTF-8?Q?Pawe=C5=82_Chmiel?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 18 Sep 2019 at 14:36, Rob Herring wrote: > > On Sat, Sep 07, 2019 at 11:20:04AM +0200, Krzysztof Kozlowski wrote: > > Convert Samsung Exynos System Registers (SYSREG) bindings to DT schema > > format using json-schema. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Example somehow fails: > > Documentation/devicetree/bindings/arm/samsung/pmu.example.dt.yaml: > > system-controller@10040000: compatible:0: 'samsung,exynos5250-pmu' is > > not one of ['samsung,exynos4-sysreg', 'samsung,exynos5-sysreg'] > > > > It seems that PMU schema is applied to sysreq nodes (and vice-versa). > > --- > > .../bindings/arm/samsung/sysreg.txt | 19 ----------- > > .../bindings/arm/samsung/sysreg.yaml | 33 +++++++++++++++++++ > > 2 files changed, 33 insertions(+), 19 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/sysreg.txt > > create mode 100644 Documentation/devicetree/bindings/arm/samsung/sysreg.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > > deleted file mode 100644 > > index 4fced6e9d5e4..000000000000 > > --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > > +++ /dev/null > > @@ -1,19 +0,0 @@ > > -SAMSUNG S5P/Exynos SoC series System Registers (SYSREG) > > - > > -Properties: > > - - compatible : should contain two values. First value must be one from following list: > > - - "samsung,exynos4-sysreg" - for Exynos4 based SoCs, > > - - "samsung,exynos5-sysreg" - for Exynos5 based SoCs. > > - second value must be always "syscon". > > - - reg : offset and length of the register set. > > - > > -Example: > > - syscon@10010000 { > > - compatible = "samsung,exynos4-sysreg", "syscon"; > > - reg = <0x10010000 0x400>; > > - }; > > - > > - syscon@10050000 { > > - compatible = "samsung,exynos5-sysreg", "syscon"; > > - reg = <0x10050000 0x5000>; > > - }; > > diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.yaml b/Documentation/devicetree/bindings/arm/samsung/sysreg.yaml > > new file mode 100644 > > index 000000000000..a3d44646e441 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.yaml > > @@ -0,0 +1,33 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/samsung/sysreg.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung S5P/Exynos SoC series System Registers (SYSREG) > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - samsung,exynos4-sysreg > > + - samsung,exynos5-sysreg > > + - const: syscon > > The problem is this will by default match any node with 'syscon'. You > have to add a custom 'select' entry. See the LVDS panel bindings for an > example. > > I'd like to kill off 'syscon'... I see that panels use empty {} match but some other examples use custom select. The panel approach in my case does not actually check whether last compatible is syscon. I'll go then with a separate select approach. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel