From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D58CC43334 for ; Fri, 3 Jun 2022 04:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z8ghTHvcW1QqcKvj/Ff4PanCVdhAQ0WjgJFOwi80RRA=; b=xn/GWGbFi/gj7g nCX/BSSfUjpnPFJhzd+wEc82VIY1OQGQfrksOxdTLnZiFUzqt40OUp3HeD0w07R3SaT7gVWxhH1Oh iG5frsrlVjo2wRdQg/dLN9zlqe30Ky3MfTbwnLL5yCrdXaxLCcDAQaj/x8pA+gfuEMYAn5UBRs9GP EQuu3S6nWh2NKZRDWE94VVRd4diGZ+aZNW/XuRV1Gbkjb+4ld5+ntqNgAdjsL27bWyOYgAIrvmrrf vVvGlK970HxMB4JRmWzwsdyRPQTD9ey6MlNcE7AyS1/IRgJ5uqJnEVhRq3PACd4lTwonbSOHWxGQf 2/ikYNTpJ//PDge6yNWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwyVJ-005iic-4R; Fri, 03 Jun 2022 04:01:41 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwyVF-005igt-FF for linux-arm-kernel@lists.infradead.org; Fri, 03 Jun 2022 04:01:38 +0000 Received: by mail-ej1-x634.google.com with SMTP id s6so2036384eja.0 for ; Thu, 02 Jun 2022 21:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W8bVxKeCs+luEXxpnTLIbgpg19GNEZEh9tmWHWEe4S4=; b=fD7kHLPGCLB6BwqWqEUYpaRcFdRj6SfBXhNT8BN4I9zVIbzLaLp78HxuCGvWRZQMTi uyG/1hzIApR7fvPr0IySLfmaArCFTCp8JebyXa3+LDLDErePMizdjtRfFzLMYQpXcFiQ DZ2TCHIo3llis01Zupghoa06ycO+92zWx1r+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W8bVxKeCs+luEXxpnTLIbgpg19GNEZEh9tmWHWEe4S4=; b=VfpBl20ieMbEBSsScg86fDeTNgVbRI/PqNUIx/9sNxRjfkc47AfM419wHFV9lj2Eqg XnzhQKwVS2m1PgaH/Vy02+9w0eNtEExA4LGag4zGemluETiBgj07SdXvmt2VBL4biDbK QmQklVmxPqklrr7D9cDiZMOUDMt0jGp118dsKt1gTThT9KA5unxnD8jVCnZDQ4Pkm8D0 ZK9ClhstG+AfRh29CO7cLIxDaJ+nqSz3wWG2dCTZGTByFOtIUL5t8UxsHFs2dLZoPur/ bYIbElZQjZLCNotM92TjZPYuKn07kh4h8bAZ09WZ9PSiehlca5ejsN9FMHfc5VYL2IuP cVzw== X-Gm-Message-State: AOAM5303VDpybLJikq2FhGGkGn5F6Mt1WlemAR9L88k14CXp8W/a5gBA h5dj3GanLmjIkp5Q42cNHOEz4vs9MKjjNpSMtW9kDA== X-Google-Smtp-Source: ABdhPJyw/i2NBojqg3RSMKZ6XZsX0ph8P35ta717/u7cXFNMwFYFBna4UYDnpqAg0IP9EfLOD4BvkdnYqa5fefRVriI= X-Received: by 2002:a17:907:2ce2:b0:6ff:30e2:25c3 with SMTP id hz2-20020a1709072ce200b006ff30e225c3mr6928613ejc.494.1654228892918; Thu, 02 Jun 2022 21:01:32 -0700 (PDT) MIME-Version: 1.0 References: <20220601094637.1200634-1-hsinyi@chromium.org> <20220601094637.1200634-4-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Fri, 3 Jun 2022 12:01:06 +0800 Message-ID: Subject: Re: [PATCH v2 3/8] drm/panel: panel-edp: Implement .get_orientation callback To: Doug Anderson Cc: Chun-Kuang Hu , Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , "moderated list:ARM/Mediatek SoC support" , Rob Clark , Stephen Boyd , Rob Herring , Linux ARM , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_210137_581735_5A257EC7 X-CRM114-Status: GOOD ( 29.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 3, 2022 at 5:51 AM Doug Anderson wrote: > > Hi, > > On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > > > To return the orientation property to drm/kms driver. > > > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > --- > > drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c > > index 1732b4f56e38..a2133581a72d 100644 > > --- a/drivers/gpu/drm/panel/panel-edp.c > > +++ b/drivers/gpu/drm/panel/panel-edp.c > > @@ -609,6 +609,13 @@ static int panel_edp_get_timings(struct drm_panel *panel, > > return p->desc->num_timings; > > } > > > > +static enum drm_panel_orientation panel_edp_get_orientation(struct drm_panel *panel) > > +{ > > + struct panel_edp *p = to_panel_edp(panel); > > + > > + return p->orientation; > > +} > > + > > static int detected_panel_show(struct seq_file *s, void *data) > > { > > struct drm_panel *panel = s->private; > > @@ -637,6 +644,7 @@ static const struct drm_panel_funcs panel_edp_funcs = { > > .prepare = panel_edp_prepare, > > .enable = panel_edp_enable, > > .get_modes = panel_edp_get_modes, > > + .get_orientation = panel_edp_get_orientation, > > .get_timings = panel_edp_get_timings, > > .debugfs_init = panel_edp_debugfs_init, > > }; > > I'm curious: should we be removing the old > drm_connector_set_panel_orientation() from panel_edp_get_modes()? > ...or maybe you want to keep it for now because you're only adding > support to the mediatek driver and for other drivers the WARN_ON is > better than no orientation support at all? Right, for the drm/kms drivers that calls drm_connector_set_panel_orientation(), the drm_connector_set_panel_orientation() called in panels is no-op, but others they still need this to be called in the panel. > > Maybe you could put a comment next to the old > drm_connector_set_panel_orientation() saying that it's deprecated and > that drm drivers are expected to add a call to get_orientation()? Then > when people see the WARN_ON splat they'll quickly figure out how to > fix it. ...and eventually we can probably remove all the old calls > from get_modes() ? Sure, sounds good to me. I will add this. > > -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel